Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 14 Feb 2018 06:46:18 +1100
From:   "Tobin C. Harding" <me@tobin.cc>
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     Shunyong Yang <shunyong.yang@hxt-semitech.com>,
        linux-kernel@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Joey Zheng <yu.zheng@hxt-semitech.com>
Subject: Re: [PATCH] vsprintf: replace space with readable '=' before crng is
 ready
Message-ID: <20180213194618.GA2999@eros>
References: <1518502848-7694-1-git-send-email-shunyong.yang@hxt-semitech.com>
 <CAKwiHFiLQjFc3x9Q9=GEgnuiDPH_aBf7P1-=wPB7WtTo2ExDaA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKwiHFiLQjFc3x9Q9=GEgnuiDPH_aBf7P1-=wPB7WtTo2ExDaA@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 13, 2018 at 08:16:57AM +0100, Rasmus Villemoes wrote:
> On 13 February 2018 at 07:20, Shunyong Yang
> <shunyong.yang@hxt-semitech.com> wrote:
> 
> >
> > This patch replaces space with readable "=" when output needs padding.
> > Following is the output after applying the patch,
> 
> > Suggested-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> >
> >         if (unlikely(!have_filled_random_ptr_key)) {
> > +               char *ptrval_str = "(ptrval)";
> > +               char str[default_width + 1];
> > +               int len = strlen(ptrval_str);
> > +
> > +               if (default_width > len) {
> > +                       int pos;
> > +
> > +                       pos = (default_width - len) / 2;
> > +                       memset(str, '=', default_width);
> > +                       memcpy(str + pos + 1, ptrval_str + 1, len - 2);
> > +                       str[0] = '(';
> > +                       str[default_width - 1] = ')';
> > +                       str[default_width] = 0;
> > +                       ptrval_str = str;
> > +               }
> > +
> 
> I'm sorry, but that's way too convoluted.
> 
> >                 spec.field_width = default_width;
> >                 /* string length must be less than default_width */
> > -               return string(buf, end, "(ptrval)", spec);
> > +               return string(buf, end, ptrval_str, spec);
> >         }
> 
> I was thinking of just doing something like
> 
> -               return string(buf, end, "(ptrval)", spec);
> +               return string(buf, end, sizeof(void *) == 8 ?
> "(====ptrval====)" : "(ptrval)", spec);

Awesome.