Received: by 10.223.185.116 with SMTP id b49csp4224604wrg; Tue, 13 Feb 2018 15:11:45 -0800 (PST) X-Google-Smtp-Source: AH8x2262pRlWsNG6Dpdw11BeOyItQZY8XEGyVleuPWuUQRMxCH1HTtZ9HY58uWjFteiCYLXNlZ6L X-Received: by 10.101.81.68 with SMTP id g4mr2193465pgq.276.1518563505877; Tue, 13 Feb 2018 15:11:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518563505; cv=none; d=google.com; s=arc-20160816; b=urZpk/Z+CMqfhN/KbxtN/JWIkf6MFwkuzfwZ/4vVCRnlmSF09X3m3+ifs6YvDS1Ksf GYRH/4VXN4jCkbmwqWQyVh0QDdFVxjt+vKYEpGhxWyb4ZMlsmYQQ97feKv4sFeYsJ+eD 2st/X9lNf9X42mBamNBQUUbOxvpDDFcvLBqLmxG1G0pHGptTquotcjN2JJsMTU7CQKP+ nrcaF11j7fnkDjhd/5jX1Tqcj3pB5Tb4KQcd7EWxvfd/QPzJ09VyVzWh+ga6TNyh5LzD MH5nwS00HcmDUz46guu3HAJVp/U9QMurdVE0Vz1ayJ7Y9eBXW38cK3fv0/VehGuHAUj3 I21A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:arc-authentication-results; bh=RYgSBUDjDU2iuwhSfh2bfbTD+cQyW+HXIZIi7alpz90=; b=zEoZmLbIhh/pX3A2daq1XHrziYeZTvIslxIOLITRVye2avCB+O9KPvBZFg/Cp5gVb+ Kpg/HLuKqFA+nUIMqcZR3nwRu+cMZ/G4SP/JyK/lSJdMIAp1yTNyA7HoX0u6VxHfWbFc DIvRDasxIVJgqo75jyR77AaOneRwuyL1hl8HOWqqA2wCdFcXaTcXB1QzYmMRbn5Lg+Du nCwHIxL8xxv+2/iZyDRmcgXaplXXRFCcUfbT1Td6/pv3skLWWgDaMC2yOPCJb8F3NgKs LSPl0bVtZ/T9YmhQTej/qvULpIaleh/wm/jQTrSTUe1HDiY/Xrr4g8wZOSOl0TjbrQea gSvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f184si249719pgc.696.2018.02.13.15.11.30; Tue, 13 Feb 2018 15:11:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966069AbeBMXKy (ORCPT + 99 others); Tue, 13 Feb 2018 18:10:54 -0500 Received: from g4t3427.houston.hpe.com ([15.241.140.73]:35377 "EHLO g4t3427.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965783AbeBMXKx (ORCPT ); Tue, 13 Feb 2018 18:10:53 -0500 Received: from g4t3433.houston.hpecorp.net (g4t3433.houston.hpecorp.net [16.208.49.245]) by g4t3427.houston.hpe.com (Postfix) with ESMTP id 804E288; Tue, 13 Feb 2018 23:10:52 +0000 (UTC) Received: from anatevka.americas.hpqcorp.net (anatevka.americas.hpqcorp.net [10.34.81.6]) by g4t3433.houston.hpecorp.net (Postfix) with ESMTP id 2165358; Tue, 13 Feb 2018 23:10:52 +0000 (UTC) Date: Tue, 13 Feb 2018 16:10:51 -0700 From: Jerry Hoemann To: Guenter Roeck Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, rwright@hpe.com, maurice.a.saldivar@hpe.com Subject: Re: [PATCH v2 10/11] watchdog/hpwdt: remove allow_kdump module parameter. Message-ID: <20180213231051.GD22295@anatevka.americas.hpqcorp.net> Reply-To: Jerry.Hoemann@hpe.com References: <20180212052111.12010-1-jerry.hoemann@hpe.com> <20180212052111.12010-11-jerry.hoemann@hpe.com> <20180213182042.GA26558@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180213182042.GA26558@roeck-us.net> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 13, 2018 at 10:20:42AM -0800, Guenter Roeck wrote: > On Sun, Feb 11, 2018 at 10:21:10PM -0700, Jerry Hoemann wrote: > > The intent of this parameter is unclear and it sets up a > > race between the reset of the system by ASR and crashdump. > > > > The length of time between receipt of the pretimeout NMI > > and the ASR reset of the system is fixed by hardware. > > > > Turning the parameter off doesn't necessairly prevent a crash dump. > > Also, having the ASR reset occur while the system is crash dumping > > doesn't imply that the dump was hung given the short duration > > between the NMI and the reset. > > > > This parameter is not a substitute for having a architected watchdog > > crashdump hang detection paridigm. > > > > Signed-off-by: Jerry Hoemann > > --- > > drivers/watchdog/hpwdt.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > > index e9e54fe20804..bb0dcc8709b8 100644 > > --- a/drivers/watchdog/hpwdt.c > > +++ b/drivers/watchdog/hpwdt.c > > @@ -33,7 +33,6 @@ > > static unsigned int soft_margin = DEFAULT_MARGIN; /* in seconds */ > > static bool nowayout = WATCHDOG_NOWAYOUT; > > #ifdef CONFIG_HPWDT_NMI_DECODING > > -static unsigned int allow_kdump = 1; > > At the end of hpwdt_init_nmi_decoding(), there used to be a log message > showing the value of allow_kdump. Maybe that was removed in another patch, > but it really belongs to this patch, or am I missing something ? > > Guenter That got pulled into patch 6. I'll refactor the patches to include the message change here. -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett Packard Enterprise -----------------------------------------------------------------------------