Received: by 10.223.185.116 with SMTP id b49csp50920wrg; Tue, 13 Feb 2018 16:22:31 -0800 (PST) X-Google-Smtp-Source: AH8x224oarUL8g0TPP2DQGdcph8gh5hGLEZLD26DzRSk77RkIuoz49EhV186ifqQ3yC85dPgBn6N X-Received: by 10.99.107.73 with SMTP id g70mr2342242pgc.38.1518567751718; Tue, 13 Feb 2018 16:22:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518567751; cv=none; d=google.com; s=arc-20160816; b=KDgsFu051WFysuMC5ZhMEbiUMkotlnDXoByVcPiFQnsn9DQYQSl9jpY4KEbzz3fylF jgTaFhbKMx+TKygfGMGpYWDLQlXoh2M5nzWgQVKtCOmxXgtIPFzW5t2XlOeuyjSKrTV4 Rmthygtchf4kU4PT9gwcC1f3/mXEEIhr1t4paS/wnV2ldb1GxB1UcF4V6V93GkyhLH0+ 6Ciah+Hp1408uciLHB3o9zfbEK3ZfzRcT8hYUraXnUBRCLMfhEP9lPQ/jSxtDQlYlmhI hq6/sJSf13LYuUBUc/1Zm6MZGmRxzKOPbfCc+Nkzzr19ZXkOBDh+ufNuqmhpOVN6Lqt0 v08g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:arc-authentication-results; bh=YPbnBNNh3OfC1ZfbZTmcUKfufKKzO6+JywujMuDi6+I=; b=G1KsxFHarxT7Zd1VxFrhqDuO8W5weh+crBS8k7WzKb4TQ7JnSlR4h5T1rxhWOroibx +KgFhugtZIvMetpj8971Iax00E5AhgIYkLnisx2jnnf3MB4XE3UxEH+WdBN6pxQ5Gp84 hzqsj5npz9PFeM6vorbeAWEOxSCRQYSMMOy4obAth4YyT0LqEP35CoblDHMkrN4Qm20y WoOlPqBlQ+0j63cbzB1C5/3YwWA4esfbzlH08k9tzTBTjqXDRiHCDgKBC5WEwleFZJc8 xUVQR9efvbNoU6DRbJ6XGhbuNPEXS3ar4wQfkpdxN5UsXHfwoMO9VflmsxXrMIFdFKQX l0aA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k192si7242563pgc.299.2018.02.13.16.22.13; Tue, 13 Feb 2018 16:22:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966244AbeBNAVZ (ORCPT + 99 others); Tue, 13 Feb 2018 19:21:25 -0500 Received: from g9t5008.houston.hpe.com ([15.241.48.72]:46184 "EHLO g9t5008.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966200AbeBNAVX (ORCPT ); Tue, 13 Feb 2018 19:21:23 -0500 X-Greylist: delayed 154741 seconds by postgrey-1.27 at vger.kernel.org; Tue, 13 Feb 2018 19:21:23 EST Received: from g4t3433.houston.hpecorp.net (g4t3433.houston.hpecorp.net [16.208.49.245]) by g9t5008.houston.hpe.com (Postfix) with ESMTP id 221604C; Wed, 14 Feb 2018 00:21:23 +0000 (UTC) Received: from anatevka.americas.hpqcorp.net (anatevka.americas.hpqcorp.net [10.34.81.6]) by g4t3433.houston.hpecorp.net (Postfix) with ESMTP id BEC7555; Wed, 14 Feb 2018 00:21:22 +0000 (UTC) Date: Tue, 13 Feb 2018 17:21:22 -0700 From: Jerry Hoemann To: Guenter Roeck Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, rwright@hpe.com, maurice.a.saldivar@hpe.com Subject: Re: [PATCH v2 11/11] watchdog/hpwdt: Update driver version. Message-ID: <20180214002122.GG22295@anatevka.americas.hpqcorp.net> Reply-To: Jerry.Hoemann@hpe.com References: <20180212052111.12010-1-jerry.hoemann@hpe.com> <20180212052111.12010-12-jerry.hoemann@hpe.com> <20180213170725.GA19405@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180213170725.GA19405@roeck-us.net> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 13, 2018 at 09:07:25AM -0800, Guenter Roeck wrote: > On Sun, Feb 11, 2018 at 10:21:11PM -0700, Jerry Hoemann wrote: > > Update driver version number to reflect changes. > > > > Signed-off-by: Jerry Hoemann > > --- > > drivers/watchdog/hpwdt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > > index bb0dcc8709b8..78168e2f9b4e 100644 > > --- a/drivers/watchdog/hpwdt.c > > +++ b/drivers/watchdog/hpwdt.c > > @@ -23,7 +23,7 @@ > > > > #include > > > > -#define HPWDT_VERSION "1.4.0" > > +#define HPWDT_VERSION "2.0.0" > > I would suggest to drop the version entirely. History and experience shows > that it is not really useful. > > Guenter > HPE can and does replace drivers w/o updating the underlying kernel version. So having driver print its version has been very useful to me in debugging issues in other drivers. I want to maintain that in here. > > #define SECS_TO_TICKS(secs) ((secs) * 1000 / 128) > > #define TICKS_TO_SECS(ticks) ((ticks) * 128 / 1000) > > #define HPWDT_MAX_TIMER TICKS_TO_SECS(65535) > > -- > > 2.13.6 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett Packard Enterprise -----------------------------------------------------------------------------