Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: efi/apple-properties: Checking error handling in
 unmarshal_devices()
To:     Lukas Wunner <lukas@wunner.de>, linux-efi@vger.kernel.org
Cc:     Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
References: <145f8fac-9297-b362-d89f-886632e2507f@users.sourceforge.net>
 <20180213184033.GA24299@wunner.de>
From:   SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <af278523-44af-3483-8503-10ec93f7a6c6@users.sourceforge.net>
Date:   Wed, 14 Feb 2018 09:21:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180213184033.GA24299@wunner.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> While the allocator does print an error when allocations fail,
> it may not be immediately apparent to the user what the
> *consequences* are.  In this case, the consequence is that the
> device properties will not be available for consumption by
> drivers and they may fail to probe or behave in entirely
> unexpected ways.

Would it make sense to indicate such a questionable software situation
be any return code?


> Hence I deliberately printed an error message here so that the user
> can make the connection between erratic behavior of drivers later on
> and the memory allocation error here.

Do you find this terse message really sufficient?

Can the mentioned properties be required for the desired system configuration?

Regards,
Markus