Received: by 10.223.185.116 with SMTP id b49csp578167wrg; Wed, 14 Feb 2018 03:49:18 -0800 (PST) X-Google-Smtp-Source: AH8x224P/fnCazp1tO6M7jYxIl3xsuVl6uh1TuAw/k66yr37idxxlEBWUQ7i5OIxm/TIOSVIW6Xc X-Received: by 10.98.233.21 with SMTP id j21mr3987942pfh.123.1518608958829; Wed, 14 Feb 2018 03:49:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518608958; cv=none; d=google.com; s=arc-20160816; b=V04ZVnHORzEWwdDa7wLPEwLs4kFXMhsBKNOMFp8KoUg1v8xoHP9lPcgIiJxzc4l8fR DeiorLZUwksvIgKSTkVELi9T4voJ4BkKFVfqQl0TqokXEyTG00JBD05zLNU6F9tevWwS PAGAZ+0PbKD2mpF8gLwim3nS0GPOZ1h3+2cCe2F8IOuAy8gvzXNyTv3GH9JQQCR1O8xK UEEuCO2gNY880nRGof8Y6GC6UUG7Cj6pVU1YDHYhfLXCAMQUGUwuYUmCC45T6mA2PFjI JRzg9J9aVbpjxnxmulKC+U/Vr/WJXsMtk66GU4TNDEJb95Fx7Skf4EWumjO13ccU7sQw KuYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=eZy6e+BhNgSPIjL8IYUKSnUtETu4TtSOQjgXiclO9xY=; b=Dr48r2IeAPxWgttDlVmWwbK92l73g1lKgGeCY2bVELOW4tAUjBUDZ/nRK2Fg7JaInt i0wBcA83I6OOMzpGMfby0MHOu1uA+XOgHf+Gnb+3V7Cqp4x5DtxVqita+tj+tlxhJx8f ZcN6dX7DriuyCMNu5SMiH9ep9OO1RVbxoUUTuMVo2ABRpGwxOXT4aIwxtz1K0389vWOt wDR9xyoEEIIKGzd9PPkIznMhwrzWe3zZPd+J5RMmajr7vdOupydFB4f2FuJygGjr6i5W hbaZroB+TtqrzdIYr/1So4PoWHM+w+sVVOk+0ik4n+4ZhErwMQoi8qZfH65rfUKI0BWy SyWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10si6401152pge.338.2018.02.14.03.49.04; Wed, 14 Feb 2018 03:49:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967561AbeBNLsH (ORCPT + 99 others); Wed, 14 Feb 2018 06:48:07 -0500 Received: from a.mx.secunet.com ([62.96.220.36]:34836 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967355AbeBNLsF (ORCPT ); Wed, 14 Feb 2018 06:48:05 -0500 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id F2052201C2; Wed, 14 Feb 2018 12:48:03 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0m0DoWYRdaRv; Wed, 14 Feb 2018 12:48:03 +0100 (CET) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 70EA420078; Wed, 14 Feb 2018 12:48:03 +0100 (CET) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.361.1; Wed, 14 Feb 2018 12:48:03 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id EEE993180064; Wed, 14 Feb 2018 12:48:02 +0100 (CET) Date: Wed, 14 Feb 2018 12:48:02 +0100 From: Steffen Klassert To: Colin King CC: Herbert Xu , "David S . Miller" , Alexey Kuznetsov , "Hideaki YOSHIFUJI" , , , Subject: Re: [PATCH] esp4: remove redundant initialization of pointer esph Message-ID: <20180214114802.dc55jiwj4zwntewh@gauss3.secunet.de> References: <20180130145348.32202-1-colin.king@canonical.com> <20180202073750.t5gcqfp7cv7vdxiu@gauss3.secunet.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20180202073750.t5gcqfp7cv7vdxiu@gauss3.secunet.de> User-Agent: NeoMutt/20170609 (1.8.3) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: 93059895-F77A-4524-94CE-69E8F6C70BCA Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 02, 2018 at 08:37:50AM +0100, Steffen Klassert wrote: > On Tue, Jan 30, 2018 at 02:53:48PM +0000, Colin King wrote: > > From: Colin Ian King > > > > Pointer esph is being assigned a value that is never read, esph is > > re-assigned and only read inside an if statement, hence the > > initialization is redundant and can be removed. > > > > Cleans up clang warning: > > net/ipv4/esp4.c:657:21: warning: Value stored to 'esph' during > > its initialization is never read > > > > Signed-off-by: Colin Ian King > > I've queued this for ipsec-next, will be applied > after the merge window. Now applied to ipsec-next, thanks!