Received: by 10.223.185.116 with SMTP id b49csp648218wrg; Wed, 14 Feb 2018 04:58:25 -0800 (PST) X-Google-Smtp-Source: AH8x226obhxrFcsD4W8zkWMH+rYJ2DPKs7EEX5AaT7pxUGrWwhmRujsml4F9aGDfffwhIW5b1q/3 X-Received: by 2002:a17:902:5269:: with SMTP id z96-v6mr4511008plh.392.1518613105715; Wed, 14 Feb 2018 04:58:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518613105; cv=none; d=google.com; s=arc-20160816; b=X/Fn7OwVyQASWPs4u5QvMxDmHKas3/5VeONj/gzEHXxp0qToNNtTJN9++pFqYRSh6a XM5NibDIflLK5tU9Y2HVWL9Tcs0QHkDlQDWQ9w4Oh80V1bgxy3xNhGuEpZTZiXjrwFaL zffjqSBNsPQSBLG/2wzKyZKWVWsJdpgQLB9BtsURtWepngUw4pKgXIJw1l9VuN9e4xKu ZSK39ZvIjc6SxquyyvQLUvTuGxkozfqtvWhJv5GtGVufC/mR1IEJMgjt0tdiZscVUwT0 HPKtcE/inlHpenXkCUopUEZIMy9308qx4LfqbR9hKKNsmqOuFhTFr6X4rjhmTi6CR3wa HCRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=pAU7WW2XgBOKxTpnmpMK4hUmWUeekr5uYYgcXhST4sU=; b=hv1ssnxvNhwRpTO2AKeHaXQlE7+sAeAopgVXZ4sDYFvM9BVLFHKVxkByrylIP5S24X aURwouU6/SWhin9rFuaQ4WFm136mOqL41GgwfaySju88VeK5LSFVSEqLH3WlwIaUTzdT WmeVIxAXDQq8JynHOf5MdOfgFdNL/m82qga5rHymjkqU/wug44v14jnheRITFb9mWpB4 ZMG+5aaNAfCr0jiCKSRhsttIecGiDCjn/8fWbRqlXIiFeyKKtEPvqAX652rm2MxcdREz +zoPu++/pMtvWP7145EdO1kcoSv7aQM0YBsapB2ZXH7fxSFnV7UiO8B8bQQQsfUbLNMe E5vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=O8+KTUk3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a90-v6si2880152plc.592.2018.02.14.04.58.10; Wed, 14 Feb 2018 04:58:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=O8+KTUk3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967771AbeBNM5V (ORCPT + 99 others); Wed, 14 Feb 2018 07:57:21 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:50137 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967589AbeBNM5S (ORCPT ); Wed, 14 Feb 2018 07:57:18 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4CE4D209DA; Wed, 14 Feb 2018 07:57:18 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Wed, 14 Feb 2018 07:57:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=pAU7WW2XgBOKxTpnmpMK4hUmWUeek r5uYYgcXhST4sU=; b=O8+KTUk3Pg/cQi8+tnpHy0eyTxSpRQRkWH14XiAmHIqy1 IxBlvpZJR8JsYOH2KPdnWh5RtfWXxHmXWDhTmqmdy8HsgY3QajD7uXtvFxXo+nr6 9zDuNrGKAs45DyeCs/Sp+nIUNLO/MZWwwiJgAsrZ1ukQrtuETJj0MvAGgDM5IOZY 6hR0uTSzQrGD+gHwurJPIjTLh40SHTWlc76Uo00H5YYi7JB34SA0IXw9S1LOP6Mx mVaRQ/35/nt/UznbzviYCFA4fh0wT3whyElJS9SUF8J1GUn60gHOozRngqrSpAuv wkAzXB4mftnfeupDbAVJ96ZMChBDtCbU12YU2zxRQ== X-ME-Sender: Received: from localhost (lfbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.messagingengine.com (Postfix) with ESMTPA id DDB307E3D9; Wed, 14 Feb 2018 07:57:17 -0500 (EST) Date: Wed, 14 Feb 2018 13:57:20 +0100 From: Greg KH To: ShuFanLee Cc: heikki.krogerus@linux.intel.com, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, cy_huang@richtek.com, shufan_lee@richtek.com Subject: Re: [PATCH v2] staging: typec: handle vendor defined part and modify drp toggling flow Message-ID: <20180214125720.GB30479@kroah.com> References: <1518612334-24140-1-git-send-email-leechu729@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1518612334-24140-1-git-send-email-leechu729@gmail.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 14, 2018 at 08:45:34PM +0800, ShuFanLee wrote: > From: ShuFanLee > > Handle vendor defined behavior in tcpci_init, tcpci_set_vconn and export tcpci_irq. > More operations can be extended in tcpci_data if needed. > According to TCPCI specification, 4.4.5.2 ROLE_CONTROL, > TCPC shall not start DRP toggling until subsequently the TCPM > writes to the COMMAND register to start DRP toggling. > DRP toggling flow is chagned as following: > - Write DRP = 0 & Rd/Rd > - Write DRP = 1 > - Set LOOK4CONNECTION command > > Signed-off-by: ShuFanLee > --- > drivers/staging/typec/tcpci.c | 111 ++++++++++++++++++++++++++++++++++-------- > drivers/staging/typec/tcpci.h | 13 +++++ > 2 files changed, 103 insertions(+), 21 deletions(-) What changed from v1? And I have to ask, are there no ' ' characters in your name? thanks, greg k-h