Received: by 10.223.185.116 with SMTP id b49csp692158wrg; Wed, 14 Feb 2018 05:38:01 -0800 (PST) X-Google-Smtp-Source: AH8x227uKC/1tAnMAXwRBX4GqJXztoo2k5nXt5QxLp1HJm4TVhhPJsBet4t7ESiz4fWqmevsqKkf X-Received: by 10.98.48.2 with SMTP id w2mr4755864pfw.162.1518615481036; Wed, 14 Feb 2018 05:38:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518615481; cv=none; d=google.com; s=arc-20160816; b=yfwufj4TyRslrQxQ1O0vOBmA8Jkbnj8g6i56g4suYoyCJjLkDrvlnOEPhsKltLOjNa T+S7VAnoBQscv3Ma5s3Q7imfymlqT/1n13z38uuPwtjzA1ezgAug31jqJlkquTSK4ss/ DKlAcp9TN5HNtadds+cxRMUhJkqiUpXe0pffoSsHeBuo/v941MzNpLO8rfXbxTzzG7IZ HEIdtkGiEbXiqjIBdcRK2rF9xXCr1HBkYK80Kd+bbiNZVJSXeQETz5pVMVgThriEpecK jyOi5qQhAF2xxmMBe0lt4xbmnE0ZTCVYAuCF+xEBKvZrp40i1LlaqyvIy2PsL2bPkyP9 uaNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=vrkjKRg582590qm8WOXfQZNS6+c9qp7QPO1FDlhVIO4=; b=zF3cj4hLEtORiLDi5CawGkpjqBWL4ysgNWqp5iFZI6kSNB0cxX54xIfBIsWhj+mlKi 0Qzlo03fvuT/awlNpnam8192bapka0TKQfOho2tjbyWgQg2nUa2QYi2Nrz6QLw1W8H+M QTVP1W5vJrIF5ar+QSvX/+oI739vZPx4ftNXQ3mgaeykWqDlss0cphToCS+1ev4xlw5c 0RnK/7iXCExiuBzkdDMEyJq4s4Y/iA+Uh3/qrUFxH+KP5kIloJdQDNe53BglAKRfQUVr 711z/wwEz6GLC8KhTOyHOKO6b+wgYUJnfYpk2haKJiSH1g/B+0TqbSrxXczL7lM2+a4A cEoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=gBYylZUh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o12si1338981pfg.286.2018.02.14.05.37.46; Wed, 14 Feb 2018 05:38:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=gBYylZUh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030308AbeBNNhL (ORCPT + 99 others); Wed, 14 Feb 2018 08:37:11 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:46127 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030202AbeBNNhK (ORCPT ); Wed, 14 Feb 2018 08:37:10 -0500 Received: by mail-qt0-f195.google.com with SMTP id u6so7673167qtg.13; Wed, 14 Feb 2018 05:37:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=vrkjKRg582590qm8WOXfQZNS6+c9qp7QPO1FDlhVIO4=; b=gBYylZUhoWWtAPU2IJMIDkge6sVYZxiKa1bWHm4CQITeMRcNuaMa2G3h17kdDGwlse PganX16tGURXlXNjVQXkyOPdL9hOnXKjQbS5/FQPaa5Y+CZgs5/he7GUEblwteqghHuC cUeAkD5YCEkt9fQ0/+9HWVsmO85nRM0KwGagzNORxkK9eLSATt8Q9Ljg0gurwz7VJ5Pi AB6qd0tGNL7ldscSU4Nbzc1eegdhsb3AU+Ff+QHRgCJoAKZrhcLDMbbD2xVte+Fqb4kV Ufp3x4rP+Mg3oSQ7IRApmyvNiCCSXZWPS9AjqXN6Z49tkpxvi5NadEcN+ctRQLNoGTrH ceow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=vrkjKRg582590qm8WOXfQZNS6+c9qp7QPO1FDlhVIO4=; b=IUA7GWGbNOxi8DRmDI4FvwUP4RKgoOHNvrnadoTnPxET9OrdE1Awd7LiQQKoISPX/O fYKCWu3F2u2aXFrZFDUhOOtRH4GlMvcoVr9+PeJ2/oAJnuQSu9mMhu2FAPUjVgT6siAc 9R94Jp6Hr4IMVtM+iaTnXKOkpD6GZrsqsTDnE7l5WaxurkpDGZU5lZNuKCBGyX23KKIB DnPuSyYOUl0My+daMKS3KSALr0beZhDMgrGxx/aMfXcuwTR+1JkC8n/hrAdF1ASaNvJE JLNvUHzEwIpOJ2HC8N/gguuldnvLeVi2qMxAWjDVhOOaYkyCY6Ctc8V6V/x8l0c3//EZ er2g== X-Gm-Message-State: APf1xPD9oIngHCH/HY97wAUBl1a8hioNz97q47eRQ4ZGCXFPIue27cTQ LT8OvRMBCTpcy7lGOynJYigjeLb32Fj9I82EaapEf3ZA X-Received: by 10.200.27.2 with SMTP id y2mr7908682qtj.161.1518615429076; Wed, 14 Feb 2018 05:37:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.47.219 with HTTP; Wed, 14 Feb 2018 05:37:08 -0800 (PST) In-Reply-To: <1518515162-23663-5-git-send-email-jacopo+renesas@jmondi.org> References: <1518515162-23663-1-git-send-email-jacopo+renesas@jmondi.org> <1518515162-23663-5-git-send-email-jacopo+renesas@jmondi.org> From: Geert Uytterhoeven Date: Wed, 14 Feb 2018 14:37:08 +0100 X-Google-Sender-Auth: XGSlHxzMhCScpry1mBlTZq9diGQ Message-ID: Subject: Re: [PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support To: Jacopo Mondi Cc: Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel@lists.infradead.org, Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add initial PFC support for R-Car M3-N (r8a77965) SoC. > No groups or functions defined, just pin and registers enumeration. > > Signed-off-by: Jacopo Mondi Thanks for your patch! Looks mostly OK to me. You do want to compare with pfc-r8a7796.c: all differences not related to SATA_DEVSL, FSCLK, DU_DOTCLKIN2/3, and PRESET are issues that were fixed recently in pfc-r8a7796.c, and should apply to pfc-r8a77965.c, too. That leaves us with very few differences only, but it won't be trivial to have a combined M3-W/N PFC driver, I'm afraid. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds