Received: by 10.223.185.116 with SMTP id b49csp718942wrg; Wed, 14 Feb 2018 06:03:34 -0800 (PST) X-Google-Smtp-Source: AH8x227eswPxsJb+/Xg9YTEzHu0E3UT9AIXbxYXVV/C/7/qlyuSwUo+Sd686nkFX6MJEU/5ykUDg X-Received: by 2002:a17:902:7290:: with SMTP id d16-v6mr756147pll.303.1518617014813; Wed, 14 Feb 2018 06:03:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518617014; cv=none; d=google.com; s=arc-20160816; b=KbHTBgw4AgF9MofpqEV5QZzdv5NsEZqAxaoGHP7Yp0qXMpeNQZfBcbutL1EVE1+1s7 JOlQcRErMQGOhy8fSXeiHq7ANf8xV5POUY8RSP67KomcdMIz83VweG8Vg3MDeS9C8Yam gcHRPxEHLUhLuQQb+nNZ515yNYFEwCEH4OajLnL/6Zg8+TgeNWktLhljU/YZ/cF1GIVm HtTopfLGJbUYUM5085tMbRbBZU5+WifHsZA6ky2pnPzSOkgGhnEzqfQAZ+cdz8ws8aTc DJcSr/oY//lIspmuu8EbECn+vb7gSfG+INzeqAjq/rVTROnmcnh7GjBLOwOjDa1cDRYY eiwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dmarc-filter:arc-authentication-results; bh=ndBmNZM8+uflt1IwVtNnIeAfwZ1xlHQTC0j8qrJTEcQ=; b=Y/O0brzFD59effSdqxeSQi8XQCw0X4zR+avz33tSRf7677q7DyrcAoI85J0NCj51bs 7YOn+XBSgbRyk931fhxV7ltQD0iCmKItnXQjzrAVmSoiqyjDUXVBxkN4SF42ZqGirJP5 oquZv5iNe5WhOd+LAPRnZgsQkUfXOPJ9bM7x/JPqbJgMvEjsMBlmSTevJRfg/t6xXMzz vCDXfOyphJG89v6uKbn4eJi0MhvtlZnZL+8lYX5AdSiIgdcyZ9cE0sU1X9zDivXCb//e +iC97lrvIImTR8YbZlKJjpM544gX+q0eliPwPo1smorQ97lMdd+wM699BwKgna4MEVK1 MffQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e3si2365165pga.1.2018.02.14.06.03.05; Wed, 14 Feb 2018 06:03:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030673AbeBNOBZ (ORCPT + 99 others); Wed, 14 Feb 2018 09:01:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:44056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030582AbeBNOAJ (ORCPT ); Wed, 14 Feb 2018 09:00:09 -0500 Received: from saruman (jahogan.plus.com [212.159.75.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1859F2178D; Wed, 14 Feb 2018 14:00:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1859F2178D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jhogan@kernel.org Date: Wed, 14 Feb 2018 13:59:43 +0000 From: James Hogan To: Mathieu Malaterre Cc: Ralf Baechle , Marcin Nowakowski , Miodrag Dinic , Aleksandar Markovic , David Daney , linux-mips@linux-mips.org, LKML Subject: Re: [PATCH 2/2] MIPS: Remove a warning when PHYS_OFFSET is 0x0 Message-ID: <20180214135943.GG4290@saruman> References: <20171226113717.15074-1-malat@debian.org> <20171226113717.15074-2-malat@debian.org> <20180102093127.GM5027@jhogan-linux.mipstec.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nhYGnrYv1PEJ5gA2" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nhYGnrYv1PEJ5gA2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 14, 2018 at 11:35:44AM +0100, Mathieu Malaterre wrote: > On Tue, Jan 2, 2018 at 7:55 PM, Mathieu Malaterre wrot= e: > > Hi James, > > > > On Tue, Jan 2, 2018 at 10:31 AM, James Hogan wro= te: > >> On Tue, Dec 26, 2017 at 12:37:14PM +0100, Mathieu Malaterre wrote: > >>> Rewrite the comparison in `else if` statement, case where `min_low_pf= n > > >>> ARCH_PFN_OFFSET` has already been checked in the first `if` statement: > >>> > >>> if (min_low_pfn > ARCH_PFN_OFFSET) { > >>> > >>> Fix non-fatal warning: > >>> > >>> arch/mips/kernel/setup.c: In function =E2=80=98bootmem_init=E2=80=99: > >>> arch/mips/kernel/setup.c:461:25: warning: comparison of unsigned expr= ession < 0 is always false [-Wtype-limits] > >>> } else if (min_low_pfn < ARCH_PFN_OFFSET) { > >>> ^ > >> > >> What compiler version is that with out of interest? It isn't exactly n= ew > >> code. > > > > I've clarified in v2, that this happen during compilation using W=3D1 > > > > For reference: > > > > $ mipsel-linux-gnu-gcc -dumpversion > > 6.3.0 > > > > > >>> > >>> Signed-off-by: Mathieu Malaterre > >> > >> Reviewed-by: James Hogan > > > > Thanks ! >=20 > ping ? >=20 > https://patchwork.linux-mips.org/project/linux-mips/list/?series=3D623 Yep, both applied for 4.17. Thanks James --nhYGnrYv1PEJ5gA2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEd80NauSabkiESfLYbAtpk944dnoFAlqEQM4ACgkQbAtpk944 dnohwhAAtZHxZQ+Wpi+Qpsk4COdtQdH94ODF/fw5BoaLm6MA4YcFfrJDXicCL/Fp 0m4VDCZCDROrqtHWYyDHvweyJGVWmXf+j/9XXn/SKRwKNZonHm8Jgs99xIqP8V+C XLWNYj3mxFNtvkKe9QHgnFPSv51P7WU8SJnq+e59CYnOjHCzzlYBrFLDyZB7pOjN 7VsS3rM6RQAJgxP6lpTZznnrScn9hulqHFU2CGgSWccBBRypGQymkurm+wZvCgSP j1K/qUt1bqC36TS5T+WX5gEbO4/S0DoMO9ebRBDRSphNPPUM4cCpJb9t96lbeHss j0eDeSCj4uT5wR2x7+7YjYzum6IximlBrwE/V/xq0pw8oj+a0WemFea4np8Aikao Y/15lwcajk1qsUZjLHitlDUq8XF7ZsAz1PzrFja1ucPgG+rPuZ6YfWk5W94DHBJ+ 9jaKvluI4VN4jSfA0U5g0VklqBAvbfLok3S8EEQf04oZ4+QLMHfTLd2acODS2ek6 DJcA2EHAEezOeQTv1AjS8ephCLvxs4OeffXE7A78iBmcwsbsv2OotMbW9ib22pOB MPKnUjlcn5GTJk9dAtn9C5CdcKBVqJTrDxhS29RZ4c45dnY7497WpoedJjoc5sZ4 VFX7fFL3a0SwOKaipRlLz8sc7WbUa6v88MdjNFNKsqbpOHWgcMc= =wy3/ -----END PGP SIGNATURE----- --nhYGnrYv1PEJ5gA2--