Received: by 10.223.185.116 with SMTP id b49csp965681wrg; Wed, 14 Feb 2018 09:31:46 -0800 (PST) X-Google-Smtp-Source: AH8x22457LKAy7CnbK0Yw+MYkUZd5gSWsAZPbxRG384TCfbTbe06kom6CW4OCmMzakMG7qXuVlNK X-Received: by 10.98.105.199 with SMTP id e190mr5481394pfc.70.1518629505880; Wed, 14 Feb 2018 09:31:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518629505; cv=none; d=google.com; s=arc-20160816; b=gYa2ptZGyKc2cfI9j0SezXcwM9pPca6Vaji3NKRTXrhdlNzY1fbzZoCD+D/LPyf+P1 HJa5fv+qjEgP2jLyaz6ZujMuvcd8gurWWAiV4TjAXasa6MeBeU+BX6bnNIMUShehZxY5 2S5Yz74cwtjSiQkvXXUPpFisdhH1EG7nbHaVQEDe/1eB3XR+WqZ8x4nNe6RFrn64fWlV J3C0u+5+r6JwU/7CpT5iodQmnZWGxX+87DpZX9Ya+qoQSmbsFLFBvAAM5vpNOEV6YZWT GPKuet5ddg3XL4INb2gofO898ujkikH6skiw+Lg9uebptM/O4gm3pE8SUQPXI75Uiefq C6vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=8uZ3OnaLriKEZ7AOKljYfMr+WcZu+RDYaht4l2KHeg0=; b=SZjqW4eH6ET7PeiNtHlHcSjk4bn38rogoD7ZIEEJdSkPvOcig1qp3i87T35aNbRkWN vtOgivaNFYehDR8HBMgABBub4V3q+fLGJw0xpUpZUztWWYeypJGVmLIgK1bzvyAj0Ixh bhgOuzaDJmNneCyhSIELMbS3afmGdkHJsGzB3x1SuakQgYczOGRlOgKN2y+WvtVZBZx4 aZpwyeXrQ2VRIE0BgL9TwRsYIWSjIVHLgoBU+jCWdgvM38cz83v6Syo90wDEENSd5JfU utJF2wCvoOUwUxd/qgRB5hipeGIlKhTXc8nBTY6g57W0yBTk0sqiQw0ublCjGZc9XC/e dxaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f3-v6si1571703plf.289.2018.02.14.09.31.16; Wed, 14 Feb 2018 09:31:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161198AbeBNRaf (ORCPT + 99 others); Wed, 14 Feb 2018 12:30:35 -0500 Received: from gateway31.websitewelcome.com ([192.185.143.4]:42175 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161102AbeBNRae (ORCPT ); Wed, 14 Feb 2018 12:30:34 -0500 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 4BE802D2FB for ; Wed, 14 Feb 2018 11:30:31 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id m0t5eS8JFuMnym0t5e7U2q; Wed, 14 Feb 2018 11:30:31 -0600 Received: from [189.175.4.238] (port=47000 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.89_1) (envelope-from ) id 1em0t5-001MIe-5V; Wed, 14 Feb 2018 11:30:31 -0600 Date: Wed, 14 Feb 2018 11:30:29 -0600 From: "Gustavo A. R. Silva" To: Corey Minyard , Arnd Bergmann , Greg Kroah-Hartman Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] ipmi: kcs_bmc: mark expected switch fall-through in kcs_bmc_handle_data Message-ID: <20180214173029.GA15661@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.4.238 X-Source-L: No X-Exim-ID: 1em0t5-001MIe-5V X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.175.4.238]:47000 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1465255 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- This code was compiled with GCC 7.3.0 drivers/char/ipmi/kcs_bmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c index 3a3498a..6476bfb 100644 --- a/drivers/char/ipmi/kcs_bmc.c +++ b/drivers/char/ipmi/kcs_bmc.c @@ -95,6 +95,7 @@ static void kcs_bmc_handle_data(struct kcs_bmc *kcs_bmc) switch (kcs_bmc->phase) { case KCS_PHASE_WRITE_START: kcs_bmc->phase = KCS_PHASE_WRITE_DATA; + /* fall through */ case KCS_PHASE_WRITE_DATA: if (kcs_bmc->data_in_idx < KCS_MSG_BUFSIZ) { -- 2.7.4