Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 00/13] gpu: drm: amd: remove unused headers
To:     Corentin Labbe <clabbe@baylibre.com>, David1.Zhou@amd.com,
        airlied@linux.ie, alexander.deucher@amd.com,
        christian.koenig@amd.com
Cc:     dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <1518619577-19771-1-git-send-email-clabbe@baylibre.com>
From:   Tom St Denis <tom.stdenis@amd.com>
Message-ID: <3746a404-0811-0529-1e6a-faab5aaffe2e@amd.com>
Date:   Wed, 14 Feb 2018 14:35:58 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1518619577-19771-1-git-send-email-clabbe@baylibre.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2018 19:36:07.9328 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 27fc6a90-1579-42d3-96b1-08d573e23230
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0073
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This will break umr since we source the headers from the kernel.  The 
kernel might not use them but the different IP blocks have deltas that 
umr is aware of.

One might argue that we should then publish the headers somewhere else 
that is public but the kernel is our vehicle right now.

Thoughts Alex/Christian?

Tom


On 14/02/18 09:46 AM, Corentin Labbe wrote:
> Hello
> 
> This patchset remove several headers which are not used by any source
> file.
> 
> Regards
> 
> Change since v1:
> - splited in multiple patchs
> 
> Change since v2
> - Use --irreversible-delete for format-patch
> 
> Corentin Labbe (13):
>    drm/amd/include: remove unused asic_reg/oss headers
>    drm/amd/include: remove unused asic_reg/bif headers
>    drm/amd/include: remove unused asic_reg/dce headers
>    drm/amd/include: remove unused asic_reg/gca headers
>    drm/amd/include: remove unused asic_reg/gmc headers
>    drm/amd/include: remove unused asic_reg/smu headers
>    drm/amd/include: remove unused asic_reg/umc headers
>    drm/amd/include: remove unused asic_reg/uvd headers
>    drm/amd/include: remove unused asic_reg/vce headers
>    drm/amd/include: remove unused asic_reg/sdma headers
>    drm/amd/include: remove unused asic_reg/nbif headers
>    drm/amd/include: remove unused displayobject.h header
>    drm/amd/powerplay: remove unused headers
> 
>   .../drm/amd/include/asic_reg/bif/bif_5_0_enum.h    |  1198 --
>   .../drm/amd/include/asic_reg/bif/bif_5_1_enum.h    |  1068 -
>   .../drm/amd/include/asic_reg/dce/dce_11_2_enum.h   |  6813 ------
>   .../drm/amd/include/asic_reg/dce/dce_8_0_enum.h    |  1117 -
>   .../gpu/drm/amd/include/asic_reg/gca/gfx_8_1_d.h   |  2791 ---
>   .../drm/amd/include/asic_reg/gca/gfx_8_1_enum.h    |  6808 ------
>   .../drm/amd/include/asic_reg/gca/gfx_8_1_sh_mask.h | 21368 -------------------
>   .../drm/amd/include/asic_reg/gmc/gmc_8_1_enum.h    |  1198 --
>   .../drm/amd/include/asic_reg/gmc/gmc_8_2_enum.h    |  1068 -
>   .../amd/include/asic_reg/nbif/nbif_6_1_sh_mask.h   | 10281 ---------
>   .../drm/amd/include/asic_reg/oss/oss_2_4_enum.h    |  1340 --
>   .../drm/amd/include/asic_reg/oss/oss_3_0_1_enum.h  |  1464 --
>   .../drm/amd/include/asic_reg/oss/oss_3_0_enum.h    |  1497 --
>   .../amd/include/asic_reg/sdma0/sdma0_4_0_default.h |   286 -
>   .../amd/include/asic_reg/sdma1/sdma1_4_0_default.h |   282 -
>   .../gpu/drm/amd/include/asic_reg/smu/smu_6_0_d.h   |   148 -
>   .../drm/amd/include/asic_reg/smu/smu_6_0_sh_mask.h |   715 -
>   .../gpu/drm/amd/include/asic_reg/smu/smu_7_1_0_d.h |  1344 --
>   .../drm/amd/include/asic_reg/smu/smu_7_1_0_enum.h  |  1191 --
>   .../amd/include/asic_reg/smu/smu_7_1_0_sh_mask.h   |  5648 -----
>   .../drm/amd/include/asic_reg/smu/smu_7_1_1_enum.h  |  1205 --
>   .../drm/amd/include/asic_reg/smu/smu_7_1_2_enum.h  |  1246 --
>   .../drm/amd/include/asic_reg/smu/smu_7_1_3_enum.h  |  1282 --
>   .../drm/amd/include/asic_reg/smu/smu_8_0_enum.h    |  1072 -
>   .../drm/amd/include/asic_reg/umc/umc_6_0_default.h |    31 -
>   .../drm/amd/include/asic_reg/umc/umc_6_0_offset.h  |    52 -
>   .../drm/amd/include/asic_reg/uvd/uvd_4_0_sh_mask.h |   795 -
>   .../drm/amd/include/asic_reg/uvd/uvd_5_0_enum.h    |  1211 --
>   .../drm/amd/include/asic_reg/uvd/uvd_6_0_enum.h    |  1081 -
>   .../gpu/drm/amd/include/asic_reg/vce/vce_1_0_d.h   |    64 -
>   .../drm/amd/include/asic_reg/vce/vce_1_0_sh_mask.h |    99 -
>   drivers/gpu/drm/amd/include/displayobject.h        |   249 -
>   .../gpu/drm/amd/powerplay/inc/polaris10_ppsmc.h    |   412 -
>   drivers/gpu/drm/amd/powerplay/inc/pp_feature.h     |    67 -
>   34 files changed, 76491 deletions(-)
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/bif/bif_5_0_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/bif/bif_5_1_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/dce/dce_8_0_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/gca/gfx_8_1_d.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/gca/gfx_8_1_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/gca/gfx_8_1_sh_mask.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/gmc/gmc_8_1_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/gmc/gmc_8_2_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/nbif/nbif_6_1_sh_mask.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/oss/oss_2_4_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/oss/oss_3_0_1_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/oss/oss_3_0_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/sdma0/sdma0_4_0_default.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/sdma1/sdma1_4_0_default.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_6_0_d.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_6_0_sh_mask.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_0_d.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_0_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_0_sh_mask.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_1_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_2_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_7_1_3_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/smu/smu_8_0_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/umc/umc_6_0_default.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/umc/umc_6_0_offset.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/uvd/uvd_4_0_sh_mask.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/uvd/uvd_5_0_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/uvd/uvd_6_0_enum.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/vce/vce_1_0_d.h
>   delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/vce/vce_1_0_sh_mask.h
>   delete mode 100644 drivers/gpu/drm/amd/include/displayobject.h
>   delete mode 100644 drivers/gpu/drm/amd/powerplay/inc/polaris10_ppsmc.h
>   delete mode 100644 drivers/gpu/drm/amd/powerplay/inc/pp_feature.h
>