Received: by 10.223.185.116 with SMTP id b49csp1135695wrg; Wed, 14 Feb 2018 12:10:12 -0800 (PST) X-Google-Smtp-Source: AH8x225bS31+uQe0j90Myt/KX4xXwHXyBYJyV1hGXN2hhYYgJQfR6qNnbAq8GPOQ8qaOCG/+JdN2 X-Received: by 10.99.117.66 with SMTP id f2mr153831pgn.249.1518639012810; Wed, 14 Feb 2018 12:10:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518639012; cv=none; d=google.com; s=arc-20160816; b=i4fGKHrTo8BrCfOVQUErAhyk8U8rsEbSJZqU8421Tm5PLFqusW5U0X42hJJ1vdWigb fGZ2xKkwm6A3aHs1X4eAgmVB/h80bBFDZv9CTZ+U+AGKJDv5fj30hDwlu1g3focYQ3Fq Xmv6UZrdLhIUN4MD++h8JqY0uAXoKLuYc2PCqZJR0QskhMEWiIWAsN188rmdp2B8mwIW KXifJyvaVvoZJew68Pg50nqBEyiSIiwh7kRA9qx/Fmvv/zz8Qvl/yi0Dw3bEQRl/X1No 2V3urFxj2kr8FZ+DZ0nXNfyx/KSlEHBp51NMhQ7c/We2zalaUcUEPnylC0TeHEzitDkO O0qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=AzryBQLAo/L8UWFlAAXwN1s2phmOzfTzVrx6HPn9Ej0=; b=y0lBvdyluqwVOBHjoHvRpidJCadulL8QC2p8XjxVrHzu9B9czjG4W/DJiVhe3sKriK pIDPPE06pIEIT9YLwRCHUzlZ9feg7PyQSRGmpUdlGhDj1/+09GSAPf/NHstePhW1PnFa aLnBKHXVsO+pahWm+thQbuDUJuQmhP92QwANKUI7t3P/Xs0G4UyF7dblYcQ+7oRQQPFH jA8V4OpRhGmWIXJImCIf+nbJq86r2qVGzw8ggmxTLt+VFfpHuKdUrvHy1lWhNMw0UNv0 kQ7fP1F9Sls84blj8lgkCw+mK3ObVSBEbNsekhX4dttqszPnuw6w01O00LU7MxDffkIR fJfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x65si2170943pfa.74.2018.02.14.12.09.58; Wed, 14 Feb 2018 12:10:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033180AbeBNRAZ (ORCPT + 99 others); Wed, 14 Feb 2018 12:00:25 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:58855 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032961AbeBNRAY (ORCPT ); Wed, 14 Feb 2018 12:00:24 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1em0Pu-0001p5-99; Wed, 14 Feb 2018 18:00:22 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1em0Pt-0007O5-MS; Wed, 14 Feb 2018 18:00:21 +0100 Date: Wed, 14 Feb 2018 18:00:21 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Gavin Schenk Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, dcb314@hotmail.com, kernel@pengutronix.de Subject: Re: [PATCH] siox: fix possible buffer overflow in device_add_store Message-ID: <20180214170021.pf2di46t2ggfepim@pengutronix.de> References: <20180214142502.20787-1-g.schenk@eckelmann.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180214142502.20787-1-g.schenk@eckelmann.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Feb 14, 2018 at 03:25:02PM +0100, Gavin Schenk wrote: > Width 20 given in format string is larger than destination > buffer 'type[20]', use %19s to prevent overflowing it. > > Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX") > Reported-by: David Binderman > Signed-off-by: Gavin Schenk Reviewed-by: Uwe Kleine-K?nig Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |