Received: by 10.223.185.116 with SMTP id b49csp1138119wrg; Wed, 14 Feb 2018 12:12:39 -0800 (PST) X-Google-Smtp-Source: AH8x227qZSADzuyGNLwV21tiyU+wc7IokR5qxU/oe+dn6N1vTb5+cHMlIL9kulCTL5MKuswWKVR6 X-Received: by 10.167.131.83 with SMTP id z19mr236204pfm.242.1518639158882; Wed, 14 Feb 2018 12:12:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518639158; cv=none; d=google.com; s=arc-20160816; b=YMDqxp6L9YhS04KlL9xb38FzMdIzcB2YTOavfJO8OTYtLBOWN/hFZazBJ7xz1ql08Q FZ0OCUSSO/hANWt32ChHuL5Js9AjgvJBmdjwhs+tmGfy1zuU3mx+qm/0uL7hR8WUTnRk NourQ5xb1ZxeN+94tQG1tRESLuY7uHMo49BMCuP3wrVW+Z2sRpWBGtd0aY3fYnoe4Jd9 cCJgNEaxS+U0Gd8mnQ20MIGXYZxDS9Hn1HGNSPbl4r/daFeESRDNENWmn4RuWYW1Ds0B m4dOMkk+BhRRgWPtTdj5lOBJoh8zzKXHz4jK2dcDyxlpOshHLzsiuQ2gE7OmWaije0se Turg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=zuQuCk8miW2LLbptQ5HomWOraQVPYrvckvbU/4pahT4=; b=T80yVbn+rjd9syCq+r3VQDn88y4ZxgbgWY1rMG2L55DYRDn7IPluxV+pjkzYJSUMmY pW/nYmfPhfZyTII4RHTZrmXeVtIlvt6j7HdyF2nnZioQOni8dQlbd3JW1nGcEriIKq4u kGItqm3wHnepMgB/R1V1+VszsWd/3f2s6OtQXjhK1ptnR1rc6DgFlnibSjpFNU+f768D WE9G/gzBWAYms0W7ha3G7VcCgne0u90XzWn9A8XueTUu1UvxG+bfOm5y/giYn1yT0PCg VC6Cok89p+lKPrc9j8Fye5QAt/bkr4n4jPnwtGxEV+35VUF9FRvagynckQ5g5d7yxlTA pvHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=gNUVUEDT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i7si6634780pgq.209.2018.02.14.12.12.24; Wed, 14 Feb 2018 12:12:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=gNUVUEDT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162308AbeBNStl (ORCPT + 99 others); Wed, 14 Feb 2018 13:49:41 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:40926 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162271AbeBNSti (ORCPT ); Wed, 14 Feb 2018 13:49:38 -0500 Received: by mail-wm0-f66.google.com with SMTP id v123so23762754wmd.5 for ; Wed, 14 Feb 2018 10:49:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zuQuCk8miW2LLbptQ5HomWOraQVPYrvckvbU/4pahT4=; b=gNUVUEDTjDX6RPiUGbeqfGVfDjIA11A4VrzF7B8VMWPX8oIhTqF8txFT2hyGaH4tWQ 6v1p/mtBM6+3Bpo9yFfLA1yohS+UgpFZmCzXQUxdvKR8fo06OVCcE6pagRwwYSN99dNm tvNaG3SQqivbYpc9HTuAd56miq8slDe/hd+XzJoSWZ63VRCd0YMhCgWhoooY1pdQI7+V RrvzyGRY+jqRcsQqi7wtpgzxXZcJU8L7O2OFaU8G3cPqUKcXkROh4qD18qBlRjslgM2n GxG2wcoKAr7fZ2J/C7D2rp6DKmB1WqFbinNw3arr2GJDESVO0EvNJTUyaBOnUlPft/Zx vUxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zuQuCk8miW2LLbptQ5HomWOraQVPYrvckvbU/4pahT4=; b=kOf8TrbKPZA2SUk5/QET74/skWSWCa92B2wdFxCaOscb646iDI2fEpAoyoRSqLLNU2 3GgVIwNx1xWv7yMPQuP404BKtdvwsRdMFdfW/7gEty9THVYCWte26NygSgvhci7GYnw4 CYsUYHtDxyKcQe/WhBtX6C9bLuVsoP2MPPv6uXVbASKxnAmv/bUZr/wkR7Vtn6h8/3Cn WhLLDeaWSedPwAUUIYNwNneqdNaZe4Iz/+2WGbIXfLkbavYEbSOCGI+b+qKCwMRKhtGd kKrZuOuch59R5h+TXUkN8OqhM3jwLE5UBkqgfBJaVkN9FHxaZl0JQkryl9Yuhohc4r2V 2sTQ== X-Gm-Message-State: APf1xPB+s2hbVxff83+3pUBub+PfeHaEqz1MKtRuci4sDzxHBknye1CD QAUwvIT91uUc7UcuxYbCLWtbMw== X-Received: by 10.28.124.4 with SMTP id x4mr60901wmc.84.1518634177630; Wed, 14 Feb 2018 10:49:37 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [70.74.179.152]) by smtp.gmail.com with ESMTPSA id h14sm16083658wrb.29.2018.02.14.10.49.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Feb 2018 10:49:36 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.86_2) (envelope-from ) id 1em27X-00027d-3S; Wed, 14 Feb 2018 11:49:31 -0700 Date: Wed, 14 Feb 2018 11:49:31 -0700 From: Jason Gunthorpe To: Sowmini Varadhan Cc: Dmitry Vyukov , syzbot , David Miller , LKML , linux-rdma@vger.kernel.org, netdev , rds-devel@oss.oracle.com, Santosh Shilimkar , syzkaller-bugs@googlegroups.com Subject: Re: KASAN: use-after-free Read in rds_tcp_tune Message-ID: <20180214184931.GA1718@ziepe.ca> References: <001a1141a524c513ca05628d8ad4@google.com> <20180112183046.GA26098@oracle.com> <20180214152109.GF11528@oracle.com> <20180214153555.GG11528@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180214153555.GG11528@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 14, 2018 at 10:35:55AM -0500, Sowmini Varadhan wrote: > On (02/14/18 16:28), Dmitry Vyukov wrote: > > syzbot is probably not seeing this problem. However if you don't add > > the Reported-by tag to commit, nor provide syz fix tag, it will > > consider it as "open". One consequence of this is that it is still on > > our radars. Another consequence is that syzbot will never report bugs > > in rds_tcp_tune ever again as it thinks that it's the same known bug, > > so no point in bothering anybody. > > understood, I think I saw this in the original syzbot mail as well, > but I was hesitant to actually add the tag because the fix was > based on code-inspection only, and I would have felt more comfortable > about asserting the Reported-by if I'd done a clear-cut before/after > verification. I think the point is you have to clear it from syzbot to get it to even test your patches, even if you are not totally sure your patch fixes it? Jason