Received: by 10.223.185.116 with SMTP id b49csp1138245wrg; Wed, 14 Feb 2018 12:12:45 -0800 (PST) X-Google-Smtp-Source: AH8x224mqdLU7+ZjKKxZnZXFncur1xbRkeiKDVMAJSrbymtXhd1U9qujeucMF8og0Re7ByAAnZTM X-Received: by 2002:a17:902:6c41:: with SMTP id h1-v6mr186310pln.25.1518639165154; Wed, 14 Feb 2018 12:12:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518639165; cv=none; d=google.com; s=arc-20160816; b=0urzMSYN0NnDZADwt1eMhmeYijna2WKLPX+pFctBJudPIWcW6iZ9BYSgxjXKBWkgtM v7UG57Mync1HYUulsHAoU0o3R9DQkdG19txO+ql6G0W7NkgR/DT2/R5yybmI0ttV+y42 TRHxhvOFASbsdVnBiE07uH1OTGYlmYPfv1MOBViVrfFJDX+XRhIN30ybHnfd47/GooYm CK3bTWZZlDP5IM3NOA4QgiC39YCB8VCvGUkVrr0VaKa0ma8IZEBZr2v7WV3k9GPOHvb5 z9R6I3Tu8nhy7wO6z1iYWD9A9EZP5FYhlSQ26sivKHhdZKxAMqLg4GjOGaPxxlX+VBv5 np+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=JD8e4RLk7++p8jr/aF5hzgrlPGOBfUmuJNgoyJFkMV8=; b=OW+9OL0aeU5KvZw+RTQB87TwjVrYJPqYmcwqtiw6UbGEwuvZatFCfqeMLn6Ujzpva7 lBrTHNHw9mhUhpMg47YGOZ+1L89jcKP9v4hsNZXT4jtepZ0nl5Ha52IntwSWj5oe3KKe 1iAYsldYjrJaFFFY7KOnYVsQldgWR02mSPjDjqNEJkA17r1IV72w1SVotBMD29sjiSVF 1YK7GpDEsG3ydCSUZSnAL4HRuIxhp3N/B5y3d2A5SNn6lNF56wpOkaO0ihO+GYdTQ7Xa yw8FN5kp1jNMyU160EI7qkhYaRXVQ9wdg2s4MkQsb0Er6v+Ozc3oTyfzqFx4mz74Mgp+ Ys+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=coQGL3t9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si3437755plc.63.2018.02.14.12.12.30; Wed, 14 Feb 2018 12:12:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=coQGL3t9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162475AbeBNS7I (ORCPT + 99 others); Wed, 14 Feb 2018 13:59:08 -0500 Received: from mail-pl0-f44.google.com ([209.85.160.44]:40611 "EHLO mail-pl0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162460AbeBNS7E (ORCPT ); Wed, 14 Feb 2018 13:59:04 -0500 Received: by mail-pl0-f44.google.com with SMTP id g18so9045635plo.7 for ; Wed, 14 Feb 2018 10:59:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JD8e4RLk7++p8jr/aF5hzgrlPGOBfUmuJNgoyJFkMV8=; b=coQGL3t9qXbh1ksollJFcWPr7U84/Q61wl729Ep1iAsu0sWSfDLNaXh9G7BKpzrxh2 xDEF0nF4BIOV9mOIxz/n6SwN8TZQ5xJ013rkq+Ecb1yvYxFRNNpgw/RarE1T5zDd3SHA rR7+sYSfz8bfYTexnZJaqgSIip88aeF2r+Ud3RHpwmzyYxvYV4Da0D+tnssNhHMOjFLt n6+dselBUo87SjUDJ93Ksefw3wOpp/O0IuYr1kzaLSPbCNkOFWxC6NpgbgsNt8lFkboD 8E2BALT6EDRzV9rcEFOpV/oTbrnh9VjpWUZC+Jpzma4nFk1vuh27vz2G+zzVusgDBftA BFAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JD8e4RLk7++p8jr/aF5hzgrlPGOBfUmuJNgoyJFkMV8=; b=nu+7rCictI/6eK9FABYAHIX26Fqf9m3+JyounjAmsLxhS9X572CpjKHhyQkZL7MuXG WoJ8R6XQfsXXukpb4YZoWZECqTsLfqvTnWzF6PfGVuI0Aq0ugtzxGx4YQ1J5ngrXYf42 GVEb2Rt3fmtHIsUKAxFxf2EfDwA/5VDQOdvfo0YOz2U5IFQzPFkJE41HG3GxEn7eXgPj iGaRjU2oO9rbuLUzIKBPDz1+Q8WbBZWP6nvtzsXUXG6xa9vdxJMu1G0xDHi0q7k+ycrM h/al1zs5ddICYfJ/BEZVt29plvkcLxDrdruaVdrn5P3NWeBtyxyV0nqe3SlS2cYHUNIs BiwA== X-Gm-Message-State: APf1xPDqzQarK/QBVfFZsCQGWul9Wun47qRT67FlmMj7qlMtowDRaAeH a5VUv9n3QmsWiWQ0saGaZ8D1iWncl6IRO5OC8P5bzA== X-Received: by 2002:a17:902:8545:: with SMTP id d5-v6mr29939plo.306.1518634744224; Wed, 14 Feb 2018 10:59:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.236.140.151 with HTTP; Wed, 14 Feb 2018 10:58:43 -0800 (PST) In-Reply-To: <20180214184931.GA1718@ziepe.ca> References: <001a1141a524c513ca05628d8ad4@google.com> <20180112183046.GA26098@oracle.com> <20180214152109.GF11528@oracle.com> <20180214153555.GG11528@oracle.com> <20180214184931.GA1718@ziepe.ca> From: Dmitry Vyukov Date: Wed, 14 Feb 2018 19:58:43 +0100 Message-ID: Subject: Re: KASAN: use-after-free Read in rds_tcp_tune To: Jason Gunthorpe Cc: Sowmini Varadhan , syzbot , David Miller , LKML , linux-rdma@vger.kernel.org, netdev , rds-devel@oss.oracle.com, Santosh Shilimkar , syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 14, 2018 at 7:49 PM, Jason Gunthorpe wrote: > On Wed, Feb 14, 2018 at 10:35:55AM -0500, Sowmini Varadhan wrote: >> On (02/14/18 16:28), Dmitry Vyukov wrote: >> > syzbot is probably not seeing this problem. However if you don't add >> > the Reported-by tag to commit, nor provide syz fix tag, it will >> > consider it as "open". One consequence of this is that it is still on >> > our radars. Another consequence is that syzbot will never report bugs >> > in rds_tcp_tune ever again as it thinks that it's the same known bug, >> > so no point in bothering anybody. >> >> understood, I think I saw this in the original syzbot mail as well, >> but I was hesitant to actually add the tag because the fix was >> based on code-inspection only, and I would have felt more comfortable >> about asserting the Reported-by if I'd done a clear-cut before/after >> verification. > > I think the point is you have to clear it from syzbot to get it to > even test your patches, even if you are not totally sure your patch > fixes it? Sorry, I failed to parse this sentence. Can you please rephrase it?