Received: by 10.223.185.116 with SMTP id b49csp1140545wrg; Wed, 14 Feb 2018 12:14:55 -0800 (PST) X-Google-Smtp-Source: AH8x2256L7Xwrrrm/TJXgJaph+x9CkBM3geAKskz1BCvv4MT5z4Viq8GVThJjx2a1kCDt05j5PPi X-Received: by 10.98.147.85 with SMTP id b82mr227182pfe.203.1518639295423; Wed, 14 Feb 2018 12:14:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518639295; cv=none; d=google.com; s=arc-20160816; b=aVUSipYsx+AdsfB7xz7Zev0FUPCg7PSLAlgGSzzdEtFHyX56Z5raATXjvbjemwOzOW I/psXow4pS3IGDVNFANrMzlLCkDXj1kTWHPPuwrR/woYQCfAlJV8S8Q6zELxgm5ojOSR lRzvO29B/nSiIs+MJGPvHLQLwaviWe+aS4WVmwGP7mg3PnspxRUsBu0QThkyljIOUEi5 qV9HUG5D6C+RDHVXQp+Zy57jAhHHQOa3RNKifO89ahcR5MXXRGo2is6sz1GHibO7wcx2 wWrZUkWpOkv7fQOChb47grVPPnaWxjYws/r1yKcagEX0s5efDpMiBZ+gmeVShFhuXf1u Uivw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=vEz9YB0UrkrAbjiTyN8HuQJdoogns0Itw1B6X9ZvMgc=; b=X7s29p90SXrNxo8mQP/31hvVu+6sEqi20FVKCf9K7cuE6Ol01E+RCLv5ozc80ayRIN xGRSCO5wtYQOoxp+uwaC9n7FN1xMvvHIqkVdxDbW0+UL5KV6FkpRmAKnPO7x+0IEnRbK M6fa+c2+qD4tXN3Zdi/XUCOAuVAoV3GFO35pYVCX9GHXHV0npPoo5wKTsqXVfGFaH5Z2 bIVCpqeeVLNGZXVTCKpAxZYPqKt9hWnSV0sAJS/Sj+guHWu+E6ghcxBNrQV83ThZvizo fgV+WjtJAQvsgG/e4KoLJQ4iJoMn9guxF5nnDKcvULJYHUt4pgCReav+XUekfs372/Ws cSBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3-v6si9494554pld.148.2018.02.14.12.14.40; Wed, 14 Feb 2018 12:14:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967851AbeBNUGK (ORCPT + 99 others); Wed, 14 Feb 2018 15:06:10 -0500 Received: from smtprelay0161.hostedemail.com ([216.40.44.161]:46930 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S967707AbeBNUGJ (ORCPT ); Wed, 14 Feb 2018 15:06:09 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id D44B2182CF66C; Wed, 14 Feb 2018 20:06:06 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3873:3874:4250:4321:5007:8526:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13149:13230:13311:13357:13439:14096:14097:14659:21080:21433:21611:21627:30041:30054:30070:30090:30091,0,RBL:47.151.150.235:@perches.com:.lbl8.mailshell.net-62.8.0.100 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:20,LUA_SUMMARY:none X-HE-Tag: woman25_6f63d04d92e16 X-Filterd-Recvd-Size: 2044 Received: from XPS-9350 (unknown [47.151.150.235]) (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA; Wed, 14 Feb 2018 20:06:05 +0000 (UTC) Message-ID: <1518638764.3678.23.camel@perches.com> Subject: Re: [PATCH 0/2] Add kvzalloc_struct to complement kvzalloc_array From: Joe Perches To: Matthew Wilcox Cc: Kees Cook , Andrew Morton , Matthew Wilcox , Linux-MM , LKML , Kernel Hardening Date: Wed, 14 Feb 2018 12:06:04 -0800 In-Reply-To: <20180214195631.GC20627@bombadil.infradead.org> References: <20180214182618.14627-1-willy@infradead.org> <1518634058.3678.15.camel@perches.com> <1518636765.3678.19.camel@perches.com> <20180214193613.GB20627@bombadil.infradead.org> <1518637426.3678.21.camel@perches.com> <20180214195631.GC20627@bombadil.infradead.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-02-14 at 11:56 -0800, Matthew Wilcox wrote: > On Wed, Feb 14, 2018 at 11:43:46AM -0800, Joe Perches wrote: > > On Wed, 2018-02-14 at 11:36 -0800, Matthew Wilcox wrote: > > > If somebody wants them, then we can add them. > > > > Yeah, but I don't think any of it is necessary. > > > > How many of these struct+bufsize * count entries > > actually exist? > > Wrong question. How many of them currently exist that don't check for > integer overflow? How many of them will be added in the future that > will fail to check for integer overflow? > > I chose five at random to fix as demonstration that the API is good. > There are more; I imagine that Julia will be able to tell us how many. No such conversions exist in the patch series you submitted. What are those?