Date: Thu, 31 Jul 2003 16:04:43 +0200
From: David Weinehall <tao@acc.umu.se>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: vda@port.imtp.ilyichevsk.odessa.ua, Ren <l.s.r@web.de>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Inline vfat_strnicmp()
Message-ID: <20030731140442.GE16315@khan.acc.umu.se>
References: <20030727172150.15f8df7f.l.s.r@web.de> <87wue4udxl.fsf@devron.myhome.or.jp> <200307311224.h6VCOMj19676@Port.imtp.ilyichevsk.odessa.ua> <87r846yfag.fsf@devron.myhome.or.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87r846yfag.fsf@devron.myhome.or.jp>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1252
Lines: 33

On Thu, Jul 31, 2003 at 10:52:23PM +0900, OGAWA Hirofumi wrote:
> Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> writes:
> 
> > On 27 July 2003 19:33, OGAWA Hirofumi wrote:
> > > Ren <l.s.r@web.de> writes:
> > > 
> > > > the function vfat_strnicmp() has just one callsite. Inlining it
> > > > actually shrinks vfat.o slightly.
> > > 
> > > Thanks. I'll submit this patch to Linus.
> > 
> > Just to deinline it in some months?
> > 
> > Come on, automatically inlining static functions with
> > just one callsite is a compiler's job. Don't do it.
> 
> Unfortunately "gcc version 3.2.3 20030415 (Debian prerelease)"
> doesn't, at least.

And how big is the performance loss?  Is it even measurable?
And even if it is, is optimizing this really worth the trouble?


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/