Received: by 10.223.185.116 with SMTP id b49csp1216437wrg; Wed, 14 Feb 2018 13:30:14 -0800 (PST) X-Google-Smtp-Source: AH8x226NzoGy6DDaYIEjbof332/2j3Qippmsx+Of7g1kuWrE/HVL9WTgsX+8mLDT/3XjI0/py7ow X-Received: by 2002:a17:902:6083:: with SMTP id s3-v6mr376211plj.6.1518643813966; Wed, 14 Feb 2018 13:30:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518643813; cv=none; d=google.com; s=arc-20160816; b=ZCLrOVhTZxfttQSHBB65F1uOXmMki3L9Vm52+9nsr58udr4U3faPQ91dtzmfTaHLQr Q8n9zCddQ+6zm1a6QFvqiJmt7FJE3S+BG1RcOsx293nD94AfV44+u+zUNCZQkESCOQLL v58+NZm9zZgxrHEl2m4aiQs8PYtlKY49/PWR0+FNcdQYprCwaJ1yQOaYzk2w+x3XI/vb Wn14Hxx2ukxFGE1MLKTHI1RRJ3xywWTRnIbXrxFY2lt3Cgi6g72vlelUIQcbP7b1lDh9 NuU3Ul2HPl3RHYG4hARyHcFxTKl0p/1T3tSA0m/qFSIjrF7MQnrurNe+RMwlJ31YzeWB UYvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=IN3Vhpi17pxg8I8g8AVEzdsKE5/TM6h6hR4AkxkBAJQ=; b=cK6+uvz6tXfnqEM4TaOImNLumnJZ+Xn6HxEHmDwoep/HtO4j63JwfceXKeKi3V/bbf B47aZW5kHFiV3Be5LzOdrgMF6P3CDWdib2lahv7/Gn06Q6t/MRP+C7jB+0INfn0nA92P fuKuTe3Kbs2ZSBlcJTRirL0OCYVSmzX4KYU+mAmN840FoCbVgb0oKmoH5oxbBOZqJKVj xMY2LKVKUye7IjnzQt32R3hLoLZsX4LvmMw1BNLS3qFmLm0aLV1gAiZPKcBT5L8kvK5s EkReFVikf70dDuu+ZbmdMVv+f6peD5RuZUC/jQmuXwCDh9L7bBoxPpD6uRIhRpBCEdq3 P91A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nexb-com.20150623.gappssmtp.com header.s=20150623 header.b=BnChON7B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8-v6si2661919plz.36.2018.02.14.13.29.59; Wed, 14 Feb 2018 13:30:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nexb-com.20150623.gappssmtp.com header.s=20150623 header.b=BnChON7B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031372AbeBNV3V (ORCPT + 99 others); Wed, 14 Feb 2018 16:29:21 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:53554 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031127AbeBNV3T (ORCPT ); Wed, 14 Feb 2018 16:29:19 -0500 Received: by mail-wm0-f65.google.com with SMTP id t74so25364621wme.3 for ; Wed, 14 Feb 2018 13:29:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IN3Vhpi17pxg8I8g8AVEzdsKE5/TM6h6hR4AkxkBAJQ=; b=BnChON7BagHB0SFSq8MOLWa42U+s7OVw/AbZRxJyg9hBTXhyPHSGkkpHV8TCRH50yl tTbv28n888zl5svdOS4kWcOAkA2ecXpQxpN/M5jkns9XZoj4b8pSmeMfxl8KZdj7Mjkx JurN6kp4VCUrKKlDPqnZlStVOHtCbrym8cU8ALln10lPPk8mjLYvYGhOa01/ENUoQhSm IFOdz0sbNFkF+31n1ZfwIBUseAgbFn5n7RVlQ3sHTou2Kuxtt6yHoIbqLincKaNK3Cqg /fbYX6w8XAxflMojI/11oyjVWoHjBW8mFjR49S9gxRZt57WzJAdN+leq4Coq0AwK4LWc 57iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IN3Vhpi17pxg8I8g8AVEzdsKE5/TM6h6hR4AkxkBAJQ=; b=EETjbdHgFmsUXlWyxbkqJNxdGMr1Xvp3gHIZJxH/zBAV5tqYhuyWRcQ15aiDwLMhAR /Z0MzgG78NopNtwe0qqdDYMH3SBPMd15tn2tXSgeD6JjsgF+mpRwyjUjj803t9lIuo8M IP2SttV7/okRwcccKHSq9Y/FZacI7EsMBRt3dXs0+Q79/AZ8qnPyQKAeelBCWHZMbd5y mktS9MHYuR+8pWD8AM9RhOI9Iuvg4KdykwerDXiF2Zs4NSg5LixmbLdSiVgxJAFD0Exo 4uZfrrEiXEJL+Lo6eJQb5y2zwecxAH66s/rM0bjRMCDWwv3uJELI8ROn1bnBgySx3/qi WjJQ== X-Gm-Message-State: APf1xPB187Xi+ZxOMLv1MiD9m/hTri4dUEnZSFHYM8Gh++YUZi6qJ+aO shV7oxPmESvHkrNTVDsCMou4Hvr8ugEmsOsD2k2B1w== X-Received: by 10.28.230.208 with SMTP id e77mr290459wmi.147.1518643758381; Wed, 14 Feb 2018 13:29:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.195.139 with HTTP; Wed, 14 Feb 2018 13:28:37 -0800 (PST) In-Reply-To: References: <20180213120308.23879-1-rodrigorivascosta@gmail.com> From: Philippe Ombredanne Date: Wed, 14 Feb 2018 22:28:37 +0100 Message-ID: Subject: Re: [PATCH 1/3] HID: add driver for Valve Steam Controller To: Benjamin Tissoires Cc: Rodrigo Rivas Costa , Jiri Kosina , lkml , linux-input@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Benjamin, Rodrigo, On Wed, Feb 14, 2018 at 3:45 PM, Benjamin Tissoires wrote: > On Tue, Feb 13, 2018 at 1:03 PM, Rodrigo Rivas Costa wrote: >> --- /dev/null >> +++ b/drivers/hid/hid-steam.c >> @@ -0,0 +1,480 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Non standard header Benjamin: What do you mean by this? This is following the proper style for this line as documented (and discussed on list at great length) [1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst >> +/* >> + * HID driver for Valve Steam Controller >> + * >> + * Supports both the wired and wireless interfaces. >> + * >> + * Copyright (c) 2018 Rodrigo Rivas Costa >> + */ >> + >> +/* >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License as published by the Free >> + * Software Foundation; either version 2 of the License, or (at your option) >> + * any later version. >> + */ Rodrigo, Since you used the proper SPDX tag (in the proper style as explained in the doc), you can remove this boilerplate alright as it does double duty with the tag. -- Cordially Philippe Ombredanne