Received: by 10.223.185.116 with SMTP id b49csp1234418wrg; Wed, 14 Feb 2018 13:48:13 -0800 (PST) X-Google-Smtp-Source: AH8x22670oU5GyzyoMQogjWmJpVTu3nvZ/mn9NVwOTPMozJ3KR8uVIRz154q2FN4/Mbx0Mw92/mY X-Received: by 2002:a17:902:7895:: with SMTP id q21-v6mr424902pll.232.1518644893316; Wed, 14 Feb 2018 13:48:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518644893; cv=none; d=google.com; s=arc-20160816; b=0FBiK4J7cwAMpEqY8fDrnlnluta2usNIio0ct4njsnn06KjJbbWszqnOe60A8Hjb39 NuCXtNeq7Pv70PCTR0HN/8Mey68DSpaMR7KQAGVvV8cpHqZ1PAqw9AFlC3vMNaUpMtBe Lclj3At9meTQoh8utscVdD5IbwcrLoAmiI3FNme3XZtn6rVvBpRUa6OLpWE5Fjv6Jugc iiOTv5rysT8NZmcekwc05AKmvMt9+NIbsR8x2abdq/kx/2e4g+JtK3pGdfh5jmygLydK I5cLqyZ1nJuyR4HoHavLGQR+wgCYB+0MHfhAOndSayvNdZr2XXnWJ8bMMH+WSE0TCSEw nmHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:reply-to:dkim-signature :arc-authentication-results; bh=QvWA/VGBkrJmg7IkLhHS0FF7KXKbsoiWPJvgnWz2x6M=; b=xtCjL8es1pK34nwlWFgheSz4KKhxLe7eH97HBYjQGczS61OKj18jkjUEKXLLcsGi/Q ZbVyn5uUIXzZQcgNH4jmpqbz4s4CvVtYFEE4su68XWpzzSJLjoaNXyglP0hMkMRyBrN+ w+njApRyQcI3gkvqv3U1LE8mOQ8cm04gThFw3TxUjA9Mmrxu1YTITioPeE+B0StZoJmL kT9hhV58p8pYSCabJWXPWXXc5OwltqclFS2y7toblcuy09tlz0FznN/EidsD4MqIiHHQ y/DKw48KPCGZcKncWr2ltYFtXsXw64ocDpUZh0d3Myg01ZiK7/NUpzewBOGU/S2ZF5BI GJrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=lMYFbIF3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1si3109521pgc.802.2018.02.14.13.47.57; Wed, 14 Feb 2018 13:48:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=lMYFbIF3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031560AbeBNVqh (ORCPT + 99 others); Wed, 14 Feb 2018 16:46:37 -0500 Received: from mail-ot0-f196.google.com ([74.125.82.196]:40751 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031427AbeBNVqf (ORCPT ); Wed, 14 Feb 2018 16:46:35 -0500 Received: by mail-ot0-f196.google.com with SMTP id s4so21694920oth.7 for ; Wed, 14 Feb 2018 13:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=QvWA/VGBkrJmg7IkLhHS0FF7KXKbsoiWPJvgnWz2x6M=; b=lMYFbIF3rv6PXu7EZi596Q9CXhw4Zo95UL2Wj8waQ0MyfpAQzI2sUBnSzzENzjUeto 2bi/W+C09HB1H1FSSSiZOCCh4zVd2QYJ+VnAhcDaYgA7W9TZ6UUR/3eRKkfi+ofvC6Ch nLig84eSNg2MukjkM4DSHD6r1LhTe53jhfbrPsfihZkMxs1QCzYnExCigIpAf5tVmfKP aTUuwqfecvxNoXgoIo/lo2KkdGMWggJDHccjIo3uBHtvsq6MQxTRdKwNR18pR8S3nf1F riUAnBZ9dL2HQk/qBlaGpeWcRli5zgGhrhrlIBrZoXCBPM72WxQl6LAWv/UWiuLVFAZF zNXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=QvWA/VGBkrJmg7IkLhHS0FF7KXKbsoiWPJvgnWz2x6M=; b=nP9IHWUCTu/u8yeh8NrfktgrkN6Euia5pkVr/y7qlK2ov3OuNcDiPBPvrTLEwURg+H slXmX982cP47AhTbInuXkLgeGwa94A78NIiVWO/iYzhJCYku0vKJcZHQjnPk7rBg8Kze iMwTdyXclFynLGRyA6mneUVIJgSXVapuSmOo+91IQvZ4sJ7kYC++hEl5aqHudnS7tqtb 2W4X9thoPfx4u7VpfMOQrvB6RqytGTwlbycoc/uqtSYuXLrY5go9RVTOaoRJYhIy+eul yprGm6uCcoiYSRmX9O0PvfyNWr8Xcx8rE7b9lLRCMdbcrjuYFvPGDpg9qX9Lc24jDFRi BPLQ== X-Gm-Message-State: APf1xPDLTEC6ZxZFM3akYbe05siZAaLaWN61jDi5s3AxCLPbtGoq2pO/ 8aGwFd+0ppz+5OEUwHJGSA== X-Received: by 10.157.22.221 with SMTP id s29mr377994ots.115.1518644794849; Wed, 14 Feb 2018 13:46:34 -0800 (PST) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id b9sm7366181oih.23.2018.02.14.13.46.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Feb 2018 13:46:33 -0800 (PST) Received: from [192.168.27.3] (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPSA id 91E01688; Wed, 14 Feb 2018 15:46:32 -0600 (CST) Reply-To: minyard@acm.org Subject: Re: [PATCH] ipmi: kcs_bmc: mark expected switch fall-through in kcs_bmc_handle_data To: "Gustavo A. R. Silva" , Arnd Bergmann , Greg Kroah-Hartman Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, Haiyue Wang References: <20180214173029.GA15661@embeddedor.com> From: Corey Minyard Message-ID: <9098c6c8-83e5-5e1f-519b-68e14738c24a@acm.org> Date: Wed, 14 Feb 2018 15:46:31 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180214173029.GA15661@embeddedor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/14/2018 11:30 AM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. Thanks, queued for next release. -corey > Addresses-Coverity-ID: 1465255 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva > --- > This code was compiled with GCC 7.3.0 > > drivers/char/ipmi/kcs_bmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c > index 3a3498a..6476bfb 100644 > --- a/drivers/char/ipmi/kcs_bmc.c > +++ b/drivers/char/ipmi/kcs_bmc.c > @@ -95,6 +95,7 @@ static void kcs_bmc_handle_data(struct kcs_bmc *kcs_bmc) > switch (kcs_bmc->phase) { > case KCS_PHASE_WRITE_START: > kcs_bmc->phase = KCS_PHASE_WRITE_DATA; > + /* fall through */ > > case KCS_PHASE_WRITE_DATA: > if (kcs_bmc->data_in_idx < KCS_MSG_BUFSIZ) {