Received: by 10.223.185.116 with SMTP id b49csp1460299wrg; Wed, 14 Feb 2018 18:14:22 -0800 (PST) X-Google-Smtp-Source: AH8x2267qOkLj0GgK9WGtk/0FKJZ4EQr+W6z0lqldri1RHXxOMQrKVfWsv9CzxMdGszyK1zhgv1Z X-Received: by 2002:a17:902:7e85:: with SMTP id c5-v6mr1016253plm.110.1518660862867; Wed, 14 Feb 2018 18:14:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518660862; cv=none; d=google.com; s=arc-20160816; b=aRJWgxW9viWos3nF09ilzSTk0i28WUBsInz4L9/E/34uZuQZbtz1ciWMTr/Izcy6Du SPfhdxt0NoOYrL+9XNGD2q+Yg0PNBRVEQDXTX6Tgwfr3Y0JjVpeNmpI1wvoJyH1DSWp5 /NxI1Gqt4h1p69pyPBfkO7B+lEdDoVq+HUZm1I3enWqlMAkRygQKaxiWXiFSbuPJMaWe SHH1ORj2ueb5GbSiIo1c6nI5QR4M8AaULPbPyPOUeR+SNg+iY/I0etzwovpMCWaH5llu YoDSitDkLs0Qis2eK5XUWkleGeOtqYkzMgNuA9tCJKJTnDVnfIzZoVwIZSl7jJgWHD2I QODg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=umdJ786gMdqCh0pNUIMcLp0pbzcGAMM3Se4+iQHtxAw=; b=bLKxfoLhy1FLBRxvwsnGnX6G1W87Xr/acDnQLpvi8/h79SHcWTAeR0kB90l4BXTLvq lrAuTAtoVn1bcAUPOjSnwmtWh7Ugq6tMTZQl8VYImBuLe2P6XzgJ4j/tRu3YpArXfvzm nse1nO7jq5dH2Vc0iJs0yQcxAAPaFvRzBcZ+mkGc0CO7H5NZr8q6vZRatbLmZvZZKDtB Z/BYsmrKNvvaNTox+8MPs/QQ+GnY85er4t/eh4EcRJTd6gSachqtBQgeH+sMDVBG69uC suT1QEiSz3OfKr3/i2Kp7zZbzpi04cj2hOPMbMau7F+qSkrJrNoJ6ekpWxSS3jbizbeM 38vQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r90si894546pfg.219.2018.02.14.18.14.06; Wed, 14 Feb 2018 18:14:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032497AbeBOCN1 (ORCPT + 99 others); Wed, 14 Feb 2018 21:13:27 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:40618 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032454AbeBOCN0 (ORCPT ); Wed, 14 Feb 2018 21:13:26 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.87 #1 (Red Hat Linux)) id 1em933-0001dQ-QU; Thu, 15 Feb 2018 02:13:21 +0000 Date: Thu, 15 Feb 2018 02:13:21 +0000 From: Al Viro To: John Pittman Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer Message-ID: <20180215021321.GB30522@ZenIV.linux.org.uk> References: <1518658622-5931-1-git-send-email-jpittman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1518658622-5931-1-git-send-email-jpittman@redhat.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 14, 2018 at 08:37:02PM -0500, John Pittman wrote: > In quite a few files throughout the block layer, the bare 'unsigned' is > used rather than the preferred 'unsigned int'. Preferred by whom? > The issue was What is that "issue" and why is it a problem in the first place? > exposed by checkpatch.pl. Warnings encountered were: Oh, good - so presumably it does have some explanations beyond "The Most Holy checkpatch.pl Spake Unto Us"; could the esteemed sir share those with us?