Received: by 10.223.185.116 with SMTP id b49csp1494003wrg; Wed, 14 Feb 2018 18:56:19 -0800 (PST) X-Google-Smtp-Source: AH8x227+Nf9WHPx6670D0ElTBXfxzFY3Vx55TAcSggmNOrXHkW7uY4qZe1IKfP2NDWp511DWZthq X-Received: by 2002:a17:902:4643:: with SMTP id o61-v6mr1105373pld.103.1518663379430; Wed, 14 Feb 2018 18:56:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518663379; cv=none; d=google.com; s=arc-20160816; b=cA9Zv4sE0GeFazn/3mrChBtfSxpnRN/zHhVVgAvp8HC/RZwr3T5BhiU7ER0YMfjMFw 54+IcjeIK3KqWuz031lz3AuFPmCJaDeURp660xzhuYA7r+bVHbM2/Xob/ywTksuEhRGy nvRg6V8G8qwMv7gH07Yb6fT8XZEakpsPWMpiRmaBC688yY9sxnaeI7VnOff4pM81zwVz ajPS9FkmeUsDdZdB5tqyEIX4dzwz/2WaIzlcKtZGB5I7hvwYYRXDB8tSrPpb0q5zCgpE HRFzHKD6MqY5UrEjBEz6VI4w6XrXKlOytl52pfey/k2X85vzyLk1BtendDRWtxnEClEe PGbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:from:references:to:subject :arc-authentication-results; bh=27mpGaHOYSOUHchMtMRcU6rGL+cUdz7afTZpJABs+h0=; b=nSZpH0kZahOuUVFol6s4iXjxqVxG5CwJd2v6VYDEW7EEI2Hg2sLf4kb2DrQDSYpoG9 BQNMLRpCJYJRRl9CIL2QrgQ/jH0D386EqTNBKuMduLdweAWbeLJ7OH0mVTlkO2MQdqAF elL44qjp6sePlsTqMSdruka6YyiUQ/L/7cfNtedQYt0rQDnGWgMkJXHvUUxuXoXW/n60 BttFUDCf38kLijntJ0Q8cYk3Ej9FgorEytDTIPUeS828+Z45rGMoDC5huhyswLH6Njdg 9age91dEnRaPYm9Wp8d8RmeTLCsbTXMfjr9F+oXjAzR1eXStFJ13OCHapi1TY5ieHj8r yZTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a71si601264pge.378.2018.02.14.18.56.04; Wed, 14 Feb 2018 18:56:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032681AbeBOCzB (ORCPT + 99 others); Wed, 14 Feb 2018 21:55:01 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33268 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1032483AbeBOCzA (ORCPT ); Wed, 14 Feb 2018 21:55:00 -0500 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1F2s549189241 for ; Wed, 14 Feb 2018 21:54:59 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 2g4yxe3cbm-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 14 Feb 2018 21:54:59 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 15 Feb 2018 02:54:58 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 15 Feb 2018 02:54:55 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w1F2ssk728442626; Thu, 15 Feb 2018 02:54:54 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D4C19A4040; Thu, 15 Feb 2018 02:48:12 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A49C3A4051; Thu, 15 Feb 2018 02:48:10 +0000 (GMT) Received: from localhost.localdomain (unknown [9.77.195.158]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 15 Feb 2018 02:48:10 +0000 (GMT) Subject: Re: [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings To: Bart Van Assche , "chris@chris-wilson.co.uk" , "linux-kernel@vger.kernel.org" , "tvrtko.ursulin@intel.com" , "jthumshirn@suse.de" , "gregkh@linuxfoundation.org" , "axboe@kernel.dk" References: <20180214045804.9113-1-khandual@linux.vnet.ibm.com> <1518624228.3147.4.camel@wdc.com> From: Anshuman Khandual Date: Thu, 15 Feb 2018 08:24:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1518624228.3147.4.camel@wdc.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18021502-0040-0000-0000-0000040FDA11 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18021502-0041-0000-0000-00002613A2E3 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-15_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802150035 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/14/2018 09:33 PM, Bart Van Assche wrote: > On Wed, 2018-02-14 at 10:28 +0530, Anshuman Khandual wrote: >> +#define SG_CHAIN 0x01 >> +#define SG_EMARK 0x02 > > Hello Anshuman, > > As you probably know constants that do not have a suffix are of type int. Please > consider to add suffix "UL" to these constants to avoid that the compiler could > take an undesired decision when e.g. converting ~SG_CHAIN from int to unsigned > long. Sure, will do.