Received: by 10.223.185.116 with SMTP id b49csp1782191wrg; Thu, 15 Feb 2018 01:14:24 -0800 (PST) X-Google-Smtp-Source: AH8x224x7lAvMQ65LrVWZFhxTYQF7wiPtn6DFtHWH1oeDqZeC1s3KVaIG1QYPQSOSx3fYTmAWRt1 X-Received: by 2002:a17:902:788e:: with SMTP id q14-v6mr1925191pll.396.1518686064874; Thu, 15 Feb 2018 01:14:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518686064; cv=none; d=google.com; s=arc-20160816; b=Udgu1YHdy0bHtMXUZWnpAeLQevD/8jc1bT7/zQ0ZroGJElOmCDPxWZqIQNup1HsR9R 7py+bN6pOuJ0KU8QFnMSLzK2+vzoOMCybfEQp0csfMWMZA+fITytRNMDEFGNK0/Mnu72 cIrdhqeENwixeIZne55ifWOGJd82XLayr/7TnUgmZr96YUpwEfus8gI2JI+dAip5V+hn ELVZ1BEjygOOnuaRCWjel0RqyrXqnSSzRo5v6OKaGTjNdoioXPA/1YeuQ/gDWpXpU+w6 8jVXO/rThxcK79F3uuQ/KnBG9COsrhk7CLajNXdMC3eu5LrgQZemXIQuUzSzc09uKBDS kBog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :organization:in-reply-to:subject:cc:to:from :arc-authentication-results; bh=tSXAdKx7vXiK0usGiWu99jHr/fuLSBzVr+evOudzJKs=; b=YNECsHaKOIe0lQgtquV3va1yqeDHZSA4/k88ARBu5rL7BQJODVAnAzQVbvKVq8K8KC WIwBiYDPkiCYT2XjvH64TjInynX7j9egFLg0np9pr8heZB50uG3k8k/aEy4rTC2KWKOd jgW+TMbkOCPjvEN8+xDxUBIgwUTq1/sKxiRw64wOt6XCoZsnMbChSYOaJGiJ+Apa1waw LXuuFUPIxzp2eGRZ/vinaV+bnMbt6FSStlceNZJOm7B35OBduLUzs1+psY/fyiZlnapx WC55VFhst7gjmHpMmQnEe43uAj/qkbeqOkurUYIYAwDua3SUthG0ohs5zsohjSE1q6W3 t5Dg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6-v6si960114plj.159.2018.02.15.01.14.09; Thu, 15 Feb 2018 01:14:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755166AbeBOJN1 (ORCPT + 99 others); Thu, 15 Feb 2018 04:13:27 -0500 Received: from mga06.intel.com ([134.134.136.31]:41468 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755069AbeBOJNZ (ORCPT ); Thu, 15 Feb 2018 04:13:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Feb 2018 01:13:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,516,1511856000"; d="scan'208";a="30944742" Received: from jnikula-mobl2.fi.intel.com (HELO localhost) ([10.237.72.62]) by fmsmga001.fm.intel.com with ESMTP; 15 Feb 2018 01:13:22 -0800 From: Jani Nikula To: "Gustavo A. R. Silva" , Joonas Lahtinen , Rodrigo Vivi , David Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: Re: [PATCH] drm/i915/selftests: fix inconsistent IS_ERR and PTR_ERR In-Reply-To: <20180214211234.GA22341@embeddedgus> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180214211234.GA22341@embeddedgus> Date: Thu, 15 Feb 2018 11:13:15 +0200 Message-ID: <87vaey4nv8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Feb 2018, "Gustavo A. R. Silva" wrote: > Fix inconsistent IS_ERR and PTR_ERR in shrink_boom. > The proper pointer to use is _explode_ instead of _purge_. > > This issue was detected with the help of Coccinelle. > > Fixes: fe215c8bc426 ("drm/i915/selftests: add missing gtt shrinker test") > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Jani Nikula (Having some issues with fdo connections, thus not pushing.) > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > index d806427..89b6ca9 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > @@ -927,7 +927,7 @@ static int shrink_boom(struct drm_i915_private *i915, > > explode = fake_dma_object(i915, size); > if (IS_ERR(explode)) { > - err = PTR_ERR(purge); > + err = PTR_ERR(explode); > goto err_purge; > } -- Jani Nikula, Intel Open Source Technology Center