Received: by 10.223.185.116 with SMTP id b49csp1994932wrg; Thu, 15 Feb 2018 05:02:56 -0800 (PST) X-Google-Smtp-Source: AH8x224IBISZcmEgIxmtkJu0mPi5+CxP4eYuU8BWXXHhqCylO18G9zsUvrL4jaKllLIz4xfTdyPF X-Received: by 10.99.64.196 with SMTP id n187mr2163007pga.147.1518699776709; Thu, 15 Feb 2018 05:02:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518699776; cv=none; d=google.com; s=arc-20160816; b=RFnFceE7RrL/Ci3IC7oOdN1HbfEj8+oyEanpD/zCKcG1W3hpxOxh0Y9JlRyvVJYwt6 /7QibeGnx7wD6f6uJYNTJB4GYSHYFP1pZ/mROmf2lN8q+drBcp1VU+fOvJWqFslkBFqY L97cu8Q632RBsdEBUvRqQgFn6wvs13hr/7yCHjbvPPtQKfmABBXYo9arOsDu62OQnXkk 2bJpxKjx+hcO2K9cMV6eGo/D4Jud4rf+1q6AqL1bSbh9lLH+Ba+XYawV5qcKIrz/qiuQ YHXMusIjGiLBw/He41YimoWYycdQ1dVVunmzJVsubMIqRc5lvGua9jPZSPyNS8+tbFus Bh1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=LBd0QboLEcq75E4vN0DIe3/MRF2Q4fQ6XzREscftK0c=; b=XoTksk1cQ1C8bAWz/IM+N/Zxg2vpWOnhePxe6Kx9cFCyrke86PIRlOEmxAtUOX0CaY QmNHUy4VwOGJAwgmw5/nQ02oFisbZDGaKRBEG8NshXTwP0iHs4A80vlGRezw9eQAI3Wx 6CiHtXGKqVa3Pf0JtmdqoPlmCrOypLgfe1qdaV49TTq+iCK6jRz75fDSmqUt1jyZocMu 9q7NV7z0yw6iRSMRHFD6lAhHPJg+icfVHoUrr9ykagX0CEyKSbGal35FQkENg3dDuI2O j6QlDZTCw4iW4mEfLKa3olhFfUUV/vzBKGbxkD3scbfbLSuWU7Ag3mZYtq9VoNoUlJx2 gHsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i66si7607036pgc.445.2018.02.15.05.02.39; Thu, 15 Feb 2018 05:02:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031551AbeBONBH (ORCPT + 99 others); Thu, 15 Feb 2018 08:01:07 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:39327 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030561AbeBONBF (ORCPT ); Thu, 15 Feb 2018 08:01:05 -0500 Received: from localhost ([77.190.216.181]) by mrelayeu.kundenserver.de (mreue007 [212.227.15.167]) with ESMTPSA (Nemesis) id 0MdjxY-1f9UsU0kZg-00PLed; Thu, 15 Feb 2018 14:01:02 +0100 From: Lukas Senger To: giometti@enneenne.com Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] pps-gpio: implement echo pulses Date: Thu, 15 Feb 2018 13:59:19 +0100 Message-Id: <20180215125921.29494-1-lukas@fridolin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: References: X-Provags-ID: V03:K0:y7ItheQZqI3XEpIT9ys1k3fsUhjmVaKCgJUXGXu0HwzCCnRKGEy x1nmf3Ci617+HS8IwZkwbW+0QSh+2X6zL3otTCamcqhjs0jT1SoqJ7D+piqorNLmFVa6wSB Tj1qMalKMu9NZrTb5qAe23/gIzBn2clspEJr6Ksz/t26Dk8n7LuHvBRmTdly9SRfgnQbudu WR+7gL9PndecO2tYVxAAQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:5JWdw4gcXrE=:7j0oeZSchbA3cxeJv0NFy9 wO17UWH9p5HPamESKY0fonsKEFBorebwxWvhYgY4W6uyQsWNpmb0PPhADov4c9/pmRj863lpe hYGLhKFVCaa2v+Jgb/RWPwbxoJp0p7ZraJ5bIL/2Me+JskZeK4FM+8S409LIGGru72szjE7Fv 89dOTTyvGTs9ocsBx4wbpp3rBTODGbESaisUdFsNQS3vqpP/fFTkxB/PjjtWED+1YR7NwOdHn KTn3/l6Y1yapC62SiamGcgDDw1cVDZRuvjFUkAd9pAWtlhmu6SLFsUe11tSBGJO7y5C2AV8k2 REd7eQIRT/yQATr11A+BwRmCw5upLkNXOK8Do7AYSMT9pIpOvvIjZe4VzXNxcpxVAGh4FFZCU XXQtgQUZ4ntEyC66G3PIuaq7Bbevb8eTn7SxiHPfiGZArzuHWn8Qo3eh7Er4s/hyx0RTsOtVx lbpzPCTVn96DEBUHLkvCbeIKW8We8MO9z2tI/OOPTFm7oFh+MtZdaZmRiukAToeXQ8xWXrlmr Pa1vB2EkVuX5rE1hVjHUS1sXlJCK1LM+IZ+5sN46CtPRKVY5xsHS2lJzlwaS954n8a0QDBaOI rYqWrO56OWmdregyBtICvMeEnM34MsBQKVHPdcCxQWF3jP47WwYLqAPqT/xJTi62dg8IIuaMg PpEKn6ehKMA86B/Q4eODJugirZfgvHrk0x5Wk19ioF+Ko2t9PK3+1Z8c0a9GT+fBBfVP42ax6 KilWKMu12f8lv2vTrYgH7cxiqUEsXrzz+UiOEw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > No hardcoded stuff please! :-D I expected as much :) So I looked into it a bit more and came up with the patch below. It works for me but I'm unsure about two things in particular: In the __overrides__ section of the *.dts, why does gpiopin set reg and should echopin set this as well? In pps-gpio.c:135 how is pdata in the first part of this if-statement supposed to know about these values? Thanks, Lukas