Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180215131533.GL8219@piout.net>
References: <20180214005536.22739-1-david.daney@cavium.com>
 <CAHp75VcQm-gr0GRszBSRJSZOpdSutRyhVkw-BN_YAwhjaPM4yg@mail.gmail.com> <20180215131533.GL8219@piout.net>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 15 Feb 2018 16:35:38 +0200
Message-ID: <CAHp75VcnR2U3DgSCv5Lpj=UBQnzX7YCbvbxzv__cZmW_+VcidQ@mail.gmail.com>
Subject: Re: [PATCH v2] rtc: isl12026: Add driver.
To:     Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc:     David Daney <david.daney@cavium.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, linux-rtc@vger.kernel.org,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 15, 2018 at 3:15 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 15/02/2018 at 14:45:11 +0200, Andy Shevchenko wrote:
>> On Wed, Feb 14, 2018 at 2:55 AM, David Daney <david.daney@cavium.com> wrote:

>> > +#ifdef CONFIG_OF
>>
>> Remove this ugly #ifdef. Your driver OF only one.
>>
>
> Well, it is DT only because you asked for that on v1.

Yes, and I asked to remove these #ifdef:s there as well.

-- 
With Best Regards,
Andy Shevchenko