Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 15 Feb 2018 16:12:38 +0100
From:   Lukas Senger <lukas@fridolin.com>
To:     Rodolfo Giometti <giometti@enneenne.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog
Message-ID: <20180215161238.23e0c117@dinghy.localdomain>
In-Reply-To: <6c424674-e8f0-eaf1-c056-889e354b43b7@enneenne.com>
References: <ee4fdd16-0343-1a01-63a7-06046026659a@enneenne.com>
        <20180215125921.29494-1-lukas@fridolin.com>
        <20180215125921.29494-2-lukas@fridolin.com>
        <6c424674-e8f0-eaf1-c056-889e354b43b7@enneenne.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Why a void function? You should use it to toggle echoing GPIO... =8-o

RFC 2783 says to generate the echo pulse "as rapidly as possible" which
is why I do the toggling in the irq handler. However this leaves the
default echo function installed which just floods syslog.

Another problem with this patch is that it also is against my old one
and not against current kernel code.

Cheers,
Lukas