Received: by 10.223.185.116 with SMTP id b49csp2298343wrg; Thu, 15 Feb 2018 09:26:58 -0800 (PST) X-Google-Smtp-Source: AH8x224TpzdBhx8xQrs0Cb90JzP4D/Rpm8L667XBFtDEYfIpeNLInWBECM3LjCDH6SZaxiRDY5xS X-Received: by 10.98.18.65 with SMTP id a62mr3322047pfj.115.1518715618490; Thu, 15 Feb 2018 09:26:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518715618; cv=none; d=google.com; s=arc-20160816; b=cZkX5cIBE8Itej1s9gWrw4yTwXyer1729AfaIp0pKix2e9yABX4Kruh24UNQGEC+F8 BVj7U4Hfq3tsJmgtKqcTrayic9WC1Uc56DanI1RoaeJ/QebwLOqZN58tJISBPVpUJs1P 7BzwmHd0QlFLpVA1cT44/Qj15mjrV/AdTlaYWqRU16HczKg0QVLQrexGRM88eXGA7ZK9 449BzauYvzf7snAx8zEtaMCwl5osV2sYMlEVAsFldAOCXzEYlh3c65z7IEUGm3XSMrm4 tmqnK0F/In7qdxy5ooUbmhuH/MtwzftDVjgFsOrTYyemuRNkG+R0MF8KCjN34AQ/KAw/ YsKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organisation:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=G0RCyryktxich4SZr9CDzQZOBfVwzjvEnAsfNK7uzWo=; b=j2XQ884ZuHnTkuRAcaT0mMRS1jonSusOVhVIjvTUmea7IWSqO/OiiRW1XjGzqRgVfo O2/td1A0rtvr0zY4YQ/737ifvF6Fi9oBkeJnfnRlNVLKHM+TzZAwRFALf2tMPvo6aq2/ HAqYpnzW4bVtFYcOXOb4r2c1ceY9Mdi8A3gK4FeISbmI2bcHKHQeBkPpz0ft1JE5nN7f Rq83/Ct3Gi+9MBdaf45iC8GmuNCJA9+d2K8bIpxbDDuskkMPUusoBAOOHEoIfbuDI3Rw iDqs0tEA9Jgn7yTl6iUwjuZOmRVT3x8fqg2niMK3wQNxFzpu2nzJTGcsFPEaIxELjvNS LcVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@verge.net.au header.s=mail header.b=pQVgWwck; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s2si2927883pgo.362.2018.02.15.09.26.43; Thu, 15 Feb 2018 09:26:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@verge.net.au header.s=mail header.b=pQVgWwck; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1427320AbeBORZd (ORCPT + 99 others); Thu, 15 Feb 2018 12:25:33 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:50496 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1165131AbeBOPel (ORCPT ); Thu, 15 Feb 2018 10:34:41 -0500 Received: from reginn.horms.nl (52D9BC73.cm-11-1c.dynamic.ziggo.nl [82.217.188.115]) by kirsty.vergenet.net (Postfix) with ESMTPA id E55C425B833; Fri, 16 Feb 2018 02:34:39 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1518708880; bh=Mm8V3oQDKTi0tIVkNoX0Vub5SGJG8GowjruDfaL06hI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pQVgWwckrL/FVIWqljIFHlga8DIHXI1hEDwraVCdnOlkHVXh/DnWoL/iCz8IQ5yh9 vBNNh+Ny9rviEwtD4yzCYK3l/kjZLn8mbnYUGFzoASap9Xki/fBxnWWBXM8UKaNh0c 7Y6HhyXoxrMhQyb/b7MV8+j3++Ftv9Gled8b6JaA= Received: by reginn.horms.nl (Postfix, from userid 7100) id A05C49403FF; Thu, 15 Feb 2018 16:34:37 +0100 (CET) Date: Thu, 15 Feb 2018 16:34:37 +0100 From: Simon Horman To: Geert Uytterhoeven Cc: Jacopo Mondi , Magnus Damm , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel@lists.infradead.org, Linux-Renesas , Linux Kernel Mailing List Subject: Re: [PATCH 03/15] soc: renesas: Add R-Car M3-N support Message-ID: <20180215153436.77h46poeswto53lm@verge.net.au> References: <1518515162-23663-1-git-send-email-jacopo+renesas@jmondi.org> <1518515162-23663-4-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 14, 2018 at 01:48:27PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > Thanks for your patch! > > On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi > wrote: > > Add support for R-Car M3-N (r8a77965) power areas and reset. > > M3-N power areas are identical to M3-W ones, so just copy and rename > > them. > > They are not identical: > - M3-N does not have the CA53-related areas, > - M3-W does not have A3VP, > - M3-N does not have A2VC0 (M3-W also doesn't, according to latest > datasheet?). > > The datasheet also mentions A3SH, without further info about the register > block. I think we need to bring this up with Renesas. > > > .../bindings/power/renesas,rcar-sysc.txt | 1 + > > .../devicetree/bindings/reset/renesas,rst.txt | 1 + > > drivers/soc/renesas/Kconfig | 9 ++++-- > > drivers/soc/renesas/Makefile | 1 + > > drivers/soc/renesas/r8a77965-sysc.c | 37 ++++++++++++++++++++++ > > drivers/soc/renesas/rcar-rst.c | 1 + > > drivers/soc/renesas/rcar-sysc.c | 3 ++ > > drivers/soc/renesas/rcar-sysc.h | 1 + > > drivers/soc/renesas/renesas-soc.c | 8 +++++ > > include/dt-bindings/power/r8a77965-sysc.h | 31 ++++++++++++++++++ > > 10 files changed, 91 insertions(+), 2 deletions(-) > > create mode 100644 drivers/soc/renesas/r8a77965-sysc.c > > create mode 100644 include/dt-bindings/power/r8a77965-sysc.h > > The maintainer may ask you to split this patch by functionality... Yes, I would like this split up. I think "[PATCH 00/11] Add R8A77980/Condor board support" provides a good example.