Received: by 10.223.185.116 with SMTP id b49csp2318632wrg; Thu, 15 Feb 2018 09:46:04 -0800 (PST) X-Google-Smtp-Source: AH8x225XuEX6QTKLEMmiKDF67E/QaYO8X7WZDWuHmDqXUAR+T91uElFii9roJ2PYhzrfRRJtd2nz X-Received: by 10.98.64.9 with SMTP id n9mr3384768pfa.194.1518716764425; Thu, 15 Feb 2018 09:46:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518716764; cv=none; d=google.com; s=arc-20160816; b=WwV4t4390ir+bQzPANuJDwyE4fEXxkLbOeoiOiZSd4nPDFtIgc1/tnq+OgSk0+Lx7d nOsIrMdTEvqS9tuQwwNaXG40e0tH0JCbBxHx445TSw49RO03cGIhbTD42fYQjG99qwLn 8VCzqPmVrgDoktSMhR/O6CzPidwIFWCxiOOKCQXO3QSka8bL1cWKNjTZxSdSkPTN17+C Y7SRz/jplfpIIj5rYKpCGvLFDa9XdAa/Hm8NvCwVkbyvv8TnF4sNiBxZhKpZTCzO8FCp uYJLW2y4R8SDUeXmaYorvx1+WeUN3LEoJ4fqkGWB5Jer8sybg/a3wIUgK+JkQHuufUYe SRnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=EyEOvkUh4dWvZZ7XAc5q9Ab7NLXnbLKTD8OMLn0FVnI=; b=KtK9ttIu4faXq/HSsIH1UumCrQ/3SAZrRhjb08jmd3l8NMEe51yv+BH1HOf4N1lR4k lxrfEQD+NU0UGw58pUdHZPjiLULWraV2VGHu8F12BoKxk6O9/Roqc4l6q6Lrg3dFTGik qKeTDXdFuMFZZUJb4V+qYoJwdDFniz7RHjI2CHlNLRaqCRgnJvlaDbYpXEDHhrLdwDIi iPkX33zSorfOcrLsAiHXz70TpJjmXcA0rHjP6kOV7HA/C+PWENO5+JbPY/Q9tJq6Zzs9 YIzOinvHSPrizf0EXb4aiLGP4kso+fkqBv2WYSgczzV1/COvySlXFxXIso4Awz/Wwd5i FnJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x2-v6si4191784plv.672.2018.02.15.09.45.50; Thu, 15 Feb 2018 09:46:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946120AbeBORon (ORCPT + 99 others); Thu, 15 Feb 2018 12:44:43 -0500 Received: from gateway21.websitewelcome.com ([192.185.45.191]:13701 "EHLO gateway21.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164558AbeBORok (ORCPT ); Thu, 15 Feb 2018 12:44:40 -0500 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 9187040105EFC for ; Thu, 15 Feb 2018 11:44:39 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id mNaJeysUlcGlpmNaJewxrR; Thu, 15 Feb 2018 11:44:39 -0600 Received: from [189.175.4.238] (port=36216 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.89_1) (envelope-from ) id 1emNaJ-0013h9-4e; Thu, 15 Feb 2018 11:44:39 -0600 Date: Thu, 15 Feb 2018 11:44:35 -0600 From: "Gustavo A. R. Silva" To: Harshitha Ramamurthy , Jeff Kirsher Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower Message-ID: <20180215174435.GA19969@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.4.238 X-Source-L: No X-Exim-ID: 1emNaJ-0013h9-4e X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.175.4.238]:36216 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It seems this is a copy-paste error and that the proper variable to use in this particular case is _src_ instead of _dst_. Addresses-Coverity-ID: 1465282 ("Copy-paste error") Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters") Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c index 4955ce3..58be99e 100644 --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c @@ -2763,7 +2763,7 @@ static int i40evf_parse_cls_flower(struct i40evf_adapter *adapter, if (key->src) { filter->f.mask.tcp_spec.src_port |= cpu_to_be16(0xffff); - filter->f.data.tcp_spec.src_port = key->dst; + filter->f.data.tcp_spec.src_port = key->src; } } filter->f.field_flags = field_flags; -- 2.7.4