Received: by 10.223.185.116 with SMTP id b49csp2362338wrg; Thu, 15 Feb 2018 10:24:26 -0800 (PST) X-Google-Smtp-Source: AH8x224agDxegLBBUyivpKbfAGIuQ3xvjiarrBwsnGG89/pPXEe/8GRomnyAZQuSWjoUxOry5R/o X-Received: by 10.98.155.93 with SMTP id r90mr3175609pfd.132.1518719066153; Thu, 15 Feb 2018 10:24:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518719066; cv=none; d=google.com; s=arc-20160816; b=GPdWm2hFwaIyYJ9mJYlqcVScvfDlfnU7yZzyxDHKGZlIQVUmUZXrC+CE+IggHUUQ6r 19jHiJjyCBizXf0U+YHg9Y+owrBtimK+4xdjp5vjIRDdLKbUUvENsxbiBSWrf5eV+HoP wayOtdeaiphhAF+y3JdrJvbnSOcutcjLFSvRgImzOn4tOIWrTcQf5A6OvDrM28axxItB H3V1hEnhFZQNBNTU6hFKr8C21nc/psDcsycaXeUkvZBetGTI0AmG8RIktyBy3M6EbJWq sEYQlNOXZjVr/RcxfHv9OwgBwpERCfhO0cq3tzgUhh6zTDyyLZ+UktxNTrY5K2r6CEVx eVxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=yi7ZvcITYKrEEdISCj8734Oyu/lh1E1OHay//qSInCQ=; b=0Fr6z0ImQgZxmKDb6BT74CQQYq9L76UczxJxrpZJycLzeoN9WJdsydT8xWopFe2FIz TbEm9lBtV5sJsNBg+bYrKOTFQKg7QKDqTXs0+SEUL7Dw1qlqqTpM0Tg7kK9Z+FCTYdzC 8VY5jhC72cJX+pHQBgbUd+MzhZoYEt29tmywojbFRtfXJmre6+iDUoYL2EZUsCoT6CY3 As5hTl7sivU6nsIXWKcNhLqXp22aFu9Iscb25eR2EyKaNcNMa1pqlMbNAGhsYRhAjtfR D98gjsaJFei81xRV2X3hWHUKmioskrNUnD7jZiwtNO2rds6sdRPwH6fnrsxaOWszCqXm x2uQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7si128183pgp.442.2018.02.15.10.24.10; Thu, 15 Feb 2018 10:24:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1166351AbeBOSWm (ORCPT + 99 others); Thu, 15 Feb 2018 13:22:42 -0500 Received: from mga14.intel.com ([192.55.52.115]:3049 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1166306AbeBOSWK (ORCPT ); Thu, 15 Feb 2018 13:22:10 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Feb 2018 10:22:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,517,1511856000"; d="scan'208";a="35068989" Received: from jbkonno-saint14.jf.intel.com ([10.54.30.229]) by orsmga002.jf.intel.com with ESMTP; 15 Feb 2018 10:22:08 -0800 From: Joe Konno To: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ard.biesheuvel@linaro.org, matthew.garrett@nebula.com, jk@ozlabs.org, ak@linux.intel.com, tony.luck@intel.com Subject: [PATCH 2/2] efi: restrict top-level attribute permissions Date: Thu, 15 Feb 2018 10:22:08 -0800 Message-Id: <20180215182208.35003-3-joe.konno@linux.intel.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180215182208.35003-1-joe.konno@linux.intel.com> References: <20180215182208.35003-1-joe.konno@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Konno Restrict four top-level (/sys/firmware/efi) attributes to match systab. This is for consistency's sake, as well as hygiene. Cc: Ard Biesheuvel Cc: linux-efi@vger.kernel.org Cc: stable@vger.kernel.org Signed-off-by: Joe Konno --- drivers/firmware/efi/efi.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index cd42f66a7c85..9a1f6c85c8c7 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -167,11 +167,13 @@ static ssize_t fw_platform_size_show(struct kobject *kobj, return sprintf(buf, "%d\n", efi_enabled(EFI_64BIT) ? 64 : 32); } -static struct kobj_attribute efi_attr_fw_vendor = __ATTR_RO(fw_vendor); -static struct kobj_attribute efi_attr_runtime = __ATTR_RO(runtime); -static struct kobj_attribute efi_attr_config_table = __ATTR_RO(config_table); +static struct kobj_attribute efi_attr_fw_vendor = + __ATTR_RO_MODE(fw_vendor, 0400); +static struct kobj_attribute efi_attr_runtime = __ATTR_RO_MODE(runtime, 0400); +static struct kobj_attribute efi_attr_config_table = + __ATTR_RO_MODE(config_table, 0400); static struct kobj_attribute efi_attr_fw_platform_size = - __ATTR_RO(fw_platform_size); + __ATTR_RO_MODE(fw_platform_size, 0400); static struct attribute *efi_subsys_attrs[] = { &efi_attr_systab.attr, -- 2.14.1