Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 15 Feb 2018 16:08:45 +0100
From:   Lukas Senger <lukas@fridolin.com>
To:     Rodolfo Giometti <giometti@enneenne.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree
Message-ID: <20180215160845.72da12c3@dinghy.localdomain>
In-Reply-To: <eb34d5ef-2e99-5983-8bdd-bf6fd0dc8bd2@enneenne.com>
References: <ee4fdd16-0343-1a01-63a7-06046026659a@enneenne.com>
        <20180215125921.29494-1-lukas@fridolin.com>
        <20180215125921.29494-3-lukas@fridolin.com>
        <eb34d5ef-2e99-5983-8bdd-bf6fd0dc8bd2@enneenne.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > @@ -20,18 +21,20 @@
> >   		target = <&gpio>;
> >   		__overlay__ {
> >   			pps_pins: pps_pins@12 {
> > -				brcm,pins =     <18>;
> > -				brcm,function = <0>;    // in
> > -				brcm,pull =     <0>;    // off
> > +				brcm,pins =     <18 17>;
> > +				brcm,function = <0 1>;    // in
> > out
> > +				brcm,pull =     <0 0>;    // off
> > off  
> 
> These modifications are not PPS related.
> 
> >   			};
> >   		};
> >   	};
> >   
> >   	__overrides__ {
> > -		gpiopin = <&pps>,"gpios:4",
> > +		gpiopin = <&pps>,"in-gpios:4",
> >   			  <&pps>,"reg:0",
> >   			  <&pps_pins>,"brcm,pins:0",
> >   			  <&pps_pins>,"reg:0";
> > +		echopin = <&pps>,"out-gpios:4",
> > +			  <&pps_pins>,"brcm,pins:4";  
> 
> Ditto.

I don't understand why these modifications are unrelated. Especially
the echopin-option should exist, shouldn't it?

Cheers,
Lukas