Received: by 10.223.185.116 with SMTP id b49csp2633204wrg; Thu, 15 Feb 2018 15:04:41 -0800 (PST) X-Google-Smtp-Source: AH8x227QDBFpoxgvH6VBLffodX0wslvV2bp7cQP31u7J9R+Nj7qDJ1PdKfGnknbwrMKJUTgknRQZ X-Received: by 10.98.22.65 with SMTP id 62mr4072846pfw.211.1518735881120; Thu, 15 Feb 2018 15:04:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518735881; cv=none; d=google.com; s=arc-20160816; b=KQyYC9ml5jVDcznXTVbM+aDwJWswi0Ktz8CkPfI1oR4xOSWJ+hhzBPrSw1w+KCF2yw sNC1+P8p751ADWeRr8Kim/9v+B6iBCyhXM7jAXdU162afzug/neWo5xPOYV7mBq5ZLgH TgcPrx1fAKMrTEcrHhLKwR9kuhv0cM05HRW5y2Cg3HmVQ4XmqEXDdQ5C45HIAhaf7Vvu vzJii7+8Yj3kHHquruoJpC/8tEwt/hsfJyTZiHMD14ekPKjZxUPu0LdbNg28QCNcY2tR Z13hW9kUUh6jOiZASarT2erdihbVxTB5yTrqfnonwFIWNQYbyXfjWNS0d+qdvCQiCcWt wmDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=+FJdRzyyKIJBF/vd0Dh1pDFQrEJkKYUv6qlES4ZmbgM=; b=IJh0DDEjsOIvSFE5FPegS2wnprm51ZDzgt7zkKs2A0O8+7SGMEh9cVzatz863VIhUa 0n64r/vf3C5bna6M67jSwlFaA+LL483lvHs3RWk5L1jjsENfd6g6BOfgdZrcECW4G6Ek qkcT+k3/pZ7ZRfSbpOAxAEgVnlEbM7G7XFvGQGGujvJVVnuB1tgAFtnv8wqMuo/0gNYV yhbG3WV/hvdfjBy8YkzWDzVMPnhmUCVZFY+kmj6wL9igSbUfQqx1F8ZlqdfAsYJk8hdR HekLO1tAUqcdMZE6vgwFzAfPJ6FgRJB2RHbguETAJJmcAWbIXc3UiHDn6bcsNXCMkaQK jkmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t74si222137pgc.649.2018.02.15.15.04.25; Thu, 15 Feb 2018 15:04:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165104AbeBOPe3 (ORCPT + 99 others); Thu, 15 Feb 2018 10:34:29 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57154 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1165004AbeBOPeZ (ORCPT ); Thu, 15 Feb 2018 10:34:25 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id E0C4210D2; Thu, 15 Feb 2018 15:34:24 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Trond Myklebust Subject: [PATCH 4.14 109/195] NFS: Fix a race between mmap() and O_DIRECT Date: Thu, 15 Feb 2018 16:16:40 +0100 Message-Id: <20180215151711.138931942@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180215151705.738773577@linuxfoundation.org> References: <20180215151705.738773577@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Trond Myklebust commit e231c6879cfd44e4fffd384bb6dd7d313249a523 upstream. When locking the file in order to do O_DIRECT on it, we must unmap any mmapped ranges on the pagecache so that we can flush out the dirty data. Fixes: a5864c999de67 ("NFS: Do not serialise O_DIRECT reads and writes") Signed-off-by: Trond Myklebust Signed-off-by: Greg Kroah-Hartman --- fs/nfs/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/nfs/io.c +++ b/fs/nfs/io.c @@ -99,7 +99,7 @@ static void nfs_block_buffered(struct nf { if (!test_bit(NFS_INO_ODIRECT, &nfsi->flags)) { set_bit(NFS_INO_ODIRECT, &nfsi->flags); - nfs_wb_all(inode); + nfs_sync_mapping(inode->i_mapping); } }