Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268736AbTGaUtA (ORCPT ); Thu, 31 Jul 2003 16:49:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269204AbTGaUtA (ORCPT ); Thu, 31 Jul 2003 16:49:00 -0400 Received: from fw.osdl.org ([65.172.181.6]:51693 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S268736AbTGaUs7 (ORCPT ); Thu, 31 Jul 2003 16:48:59 -0400 Date: Thu, 31 Jul 2003 13:37:08 -0700 From: Andrew Morton To: Oleg Drokin Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] [2.5] reiserfs: fix races between link and unlink on same file Message-Id: <20030731133708.04bcd0c9.akpm@osdl.org> In-Reply-To: <20030731144204.GP14081@namesys.com> References: <20030731144204.GP14081@namesys.com> X-Mailer: Sylpheed version 0.9.4 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 711 Lines: 21 Oleg Drokin wrote: > > This patch (originally by Chris Mason) fixes link/unlink races in reiserfs. > Could you describe the race a little more please? Why is the VFS's hold of i_sem on the parent directory not sufficient? > + > + /* > + * we schedule before doing the add_save_link call, save the link > + * count so we don't race This comment would seem to imply lock_kernel()-based locking, but lock_kernel() is not held here. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/