Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8622921723
Date:   Thu, 15 Feb 2018 15:51:35 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Lina Iyer <ilina@codeaurora.org>
Cc:     andy.gross@linaro.org, david.brown@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        rnayak@codeaurora.org, bjorn.andersson@linaro.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in
 FTRACE
Message-ID: <20180215155135.187b1501@gandalf.local.home>
In-Reply-To: <20180215204118.GF23714@codeaurora.org>
References: <20180215173507.10989-1-ilina@codeaurora.org>
        <20180215173507.10989-4-ilina@codeaurora.org>
        <20180215204118.GF23714@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 15 Feb 2018 20:41:18 +0000
Lina Iyer <ilina@codeaurora.org> wrote:


> >--- a/drivers/soc/qcom/Makefile
> >+++ b/drivers/soc/qcom/Makefile
> >@@ -1,4 +1,5 @@
> > # SPDX-License-Identifier: GPL-2.0
> >+CFLAGS_trace-rpmh.o := -I$(src)  
> I did this here..

Needs to be:

 CFLAGS_rpmh-rsc.o

You need to use the C file that has the CREATE_TRACE_POINTS define.

-- Steve

> 
> ...
> 
> >+#undef TRACE_INCLUDE_PATH
> >+#define TRACE_INCLUDE_PATH ../../drivers/soc/qcom
> >+  
> Yet, I had to define the whole path here for it to compile. Per comments
> I should just need to do this -
> 
> #define TRACE_INCLUDE_PATH .
> 
> But it doesn't work. What am I missing?
> 
> >+#undef TRACE_INCLUDE_FILE
> >+#define TRACE_INCLUDE_FILE trace-rpmh
> >+
> >+#include <trace/define_trace.h>
> >--  
> 
> Thanks,
> Lina