Received: by 10.223.185.116 with SMTP id b49csp806973wrg; Fri, 16 Feb 2018 07:30:20 -0800 (PST) X-Google-Smtp-Source: AH8x226Pof3rBUbEmdZPxWL+XDqwpd9GLJwIo4EzJCYXxl92emxROwb5kDxGduRRG/eDOaDM3/EA X-Received: by 10.98.163.67 with SMTP id s64mr4935959pfe.67.1518795020254; Fri, 16 Feb 2018 07:30:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518795020; cv=none; d=google.com; s=arc-20160816; b=VuiCIVhayGw6GbMKWpIiSxl2hGqdRa72noicZmhm18lQzb72rAQuwZGG1gOP19E8Fg 6LLH5ZH4aj/QkhmAmpgz0bJCyGvTBPjBBbPFaO9UODVDd8sVSTjPh6cAYyGSjhqzPn/s dVVNLZcAhggqCzh7YTM6/YLzQImO6+LHrYwI2d/O3xKPCiB2NDXGTPGatFfURy4uM5iP SyGOIsMw6BrbkLKqmc5dswAshxLZAeL1s9PM4HRqK9JwfOHazIjbzJJu/P8KDkkv7JT5 TCAbRNbuLCMjTgBlmayJNMQRVtF2i3zj1dyGGc4uqVdUrr/zAFxbZaQSxsc/9GFjRtOa KOBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=H0v8TBHnCo530/dXnPIfaMc3l/8xizEulHHtOAxXCkw=; b=sB63F17wRuy1gatckOL0FCvPQGcABm1Y8n1IktAwLKVSAc/5gHqdkAjQkGHNJsv1FH gtxAG718cyIUQtpsgmcy1vc8VpHpl1DaOQlgZ9wx/d5xcZR+JrNgtuh6UuI5dnhL+3+d SoFsnJMegDG8J78cM+ENkrLr2G0ZJ0SnU7/V2/ksIFMZGiKoE6i/4vy9DPL0rxx8u5Kq QpZjkUeGqhUhvWt6AOavYkl7/dSEl/62YWfS3s8SRaU80Hb+JWgFsCeNbSp2GF5F339B 7N3nSWH+h+Pu3l+rj7QqkKUrTZa4NhfMMd3qFf8Q1rCmvagLSw6F0h/6ppF1EGxIuF2E 9pCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y2-v6si1644287pli.321.2018.02.16.07.30.05; Fri, 16 Feb 2018 07:30:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163477AbeBOVdp (ORCPT + 99 others); Thu, 15 Feb 2018 16:33:45 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40082 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1162678AbeBOVdm (ORCPT ); Thu, 15 Feb 2018 16:33:42 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 242AE4040858; Thu, 15 Feb 2018 21:33:42 +0000 (UTC) Received: from localhost (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9606213AEE2; Thu, 15 Feb 2018 21:33:41 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: linux-kernel@vger.kernel.org Cc: slp@redhat.com, bhe@redhat.com, mst@redhat.com, somlo@cmu.edu, xiaolong.ye@intel.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH v15 07/11] fw_cfg: remove inline from fw_cfg_read_blob() Date: Thu, 15 Feb 2018 22:33:08 +0100 Message-Id: <20180215213312.29234-8-marcandre.lureau@redhat.com> In-Reply-To: <20180215213312.29234-1-marcandre.lureau@redhat.com> References: <20180215213312.29234-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 15 Feb 2018 21:33:42 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 15 Feb 2018 21:33:42 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'marcandre.lureau@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function is not small and getting bigger. Let the compiler decide instead. No profiling done, hopefully unnecessary. Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 805372e8e50d..f6f90bef604c 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -59,8 +59,8 @@ static void fw_cfg_sel_endianness(u16 key) } /* read chunk of given fw_cfg blob (caller responsible for sanity-check) */ -static inline void fw_cfg_read_blob(u16 key, - void *buf, loff_t pos, size_t count) +static void fw_cfg_read_blob(u16 key, + void *buf, loff_t pos, size_t count) { u32 glk = -1U; acpi_status status; -- 2.16.1.73.g5832b7e9f2