Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: android: ion: Initialize dma_address of new sg
 list
To:     Liam Mark <lmark@codeaurora.org>,
        Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Sumit Semwal <sumit.semwal@linaro.org>, devel@driverdev.osuosl.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <alpine.DEB.2.02.1802092203150.2846@lmark-linux.qualcomm.com>
 <20180212065620.iqlzczhqzlrmel5n@mwanda>
 <alpine.DEB.2.02.1802121319370.2345@lmark-linux.qualcomm.com>
From:   Laura Abbott <labbott@redhat.com>
Message-ID: <9aa626cf-c122-55af-0c95-a9e9c12c6f19@redhat.com>
Date:   Thu, 15 Feb 2018 15:31:31 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1802121319370.2345@lmark-linux.qualcomm.com>
Content-Type: text/plain; charset=iso-8859-7; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/12/2018 01:25 PM, Liam Mark wrote:
> 
> On Mon, 12 Feb 2018, Dan Carpenter wrote:
> 
>> On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote:
>>> Fix the dup_sg_table function to initialize the dma_address of the new
>>> sg list entries instead of the source dma_address entries.
>>>
>>> Fixes: 17fd283f3870 ("staging: android: ion: Duplicate sg_table")
>>> Signed-off-by: Liam Mark <lmark@codeaurora.org>
>>
>> How did you find this bug?  What are the user visible effects of this
>> bug?  I'm probably going to ask you to send a v2 patch with a new
>> changelog depending on the answers to these questions.
> 
> I noticed the bug when reading through the code, I haven?t seen any
> visible effects of this bug.
> 
>  From looking at the code I don?t see any obvious ways that this bug would
> introduce any issues with the current code base.
> 
> Liam
> 

Given the way we duplicate the sg_list this should be harmless but you
are right it's cleaner if we initialize the new list. You can add my
Ack when you update with a new change log clarifying this.

Thanks,
Laura