Received: by 10.223.185.116 with SMTP id b49csp994020wrg; Fri, 16 Feb 2018 10:28:15 -0800 (PST) X-Google-Smtp-Source: AH8x2264SzC9oVQfxCSw3FOv+pcfJLb1y78eZ72QuYgR4ZlbBdoJ0Mq5DWciBlSiW5xqSrE+G+4n X-Received: by 10.101.100.147 with SMTP id e19mr5897992pgv.88.1518805695125; Fri, 16 Feb 2018 10:28:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518805695; cv=none; d=google.com; s=arc-20160816; b=A1QGuJ2LDZMJgEVdjkwtZF22qgyDmozelwYRnMb0PUtLeY8WFkRStmvSqsV4XMmM0t G29zMuul2S3qgN+BZci+n8SwWdfkFXDNWmQ/WnyWL19KIu8u4InY8GHf6eqPtK8ITSmm RPAlDpk0S4eFh6Sd/wLyUAzBN0RYgoyUXkbeycRzJZbT9WHNxaeDm+E/3S4WiTNcqD8C Z/z3lEvZ7Tv+w6LMaFDRM3Lpfti5UpKoEDU4vhpVsIr0UB58lfDZtdLVjqjw0xCKg++h 3qA76qZqsCfXyjIBDEFBTEGL5+3b20OVXMgZ0JfGqAO5XBDcATOrizVMifUWFnmIBZb1 Nt7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=1X3yDE+bEmpjr2gT7DXlQ511Jkbx5GL/WV7np0Cgu1k=; b=Rxts/qnmliXlhsy9EqqMmvC0+qhpiQhoQgWmZaUlLM3JlsZ71l+F1CW9u2DdWyTdeb wGqP08G+a3aviQ1Eg9UZoieJMMe/iecfGX91g7cI1SlpWcdZtPiubJFfyn8tx2ilAb8h S5HmVTsGMygoiTdYzIbPz+P8ySscFO7VnKyG3S+i23OK5/d35nnzXlusNzQWokP+82K8 JqBruBdwxkV0dXqvfhjWfMeB5SO0rYXAeYyxr5+GuFDZ8540KJcV/SiynN6SBxhLhuBa iSq0umCubPq1By5heInV/owiwHEFxksntRMagYFjv6uZt4ALmr8T4uaGB8/EjPtMcFv9 FgDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w16si4198780pge.666.2018.02.16.10.28.00; Fri, 16 Feb 2018 10:28:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1167511AbeBOXpK (ORCPT + 99 others); Thu, 15 Feb 2018 18:45:10 -0500 Received: from g2t2352.austin.hpe.com ([15.233.44.25]:52529 "EHLO g2t2352.austin.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1167453AbeBOXpF (ORCPT ); Thu, 15 Feb 2018 18:45:05 -0500 Received: from g2t2360.austin.hpecorp.net (g2t2360.austin.hpecorp.net [16.196.225.135]) by g2t2352.austin.hpe.com (Postfix) with ESMTP id A619BB1; Thu, 15 Feb 2018 23:45:04 +0000 (UTC) Received: from anatevka.ftc.rdlabs.hpecorp.net (anatevka.americas.hpqcorp.net [10.34.81.6]) by g2t2360.austin.hpecorp.net (Postfix) with ESMTP id 3351C39; Thu, 15 Feb 2018 23:45:04 +0000 (UTC) From: Jerry Hoemann To: wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, rwright@hpe.com, maurice.a.saldivar@hpe.com, mingo@kernel.org, marcus.folkesson@gmail.com, Jerry Hoemann Subject: [PATCH v3 10/11] watchdog/hpwdt: remove allow_kdump module parameter. Date: Thu, 15 Feb 2018 16:43:59 -0700 Message-Id: <20180215234400.5022-11-jerry.hoemann@hpe.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180215234400.5022-1-jerry.hoemann@hpe.com> References: <20180215234400.5022-1-jerry.hoemann@hpe.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The intent of this parameter is unclear and it sets up a race between the reset of the system by ASR and crashdump. The length of time between receipt of the pretimeout NMI and the ASR reset of the system is fixed by hardware. Turning the parameter off doesn't necessairly prevent a crash dump. Also, having the ASR reset occur while the system is crash dumping doesn't imply that the dump was hung given the short duration between the NMI and the reset. This parameter is not a substitute for having a architected watchdog crashdump hang detection paridigm. Signed-off-by: Jerry Hoemann --- drivers/watchdog/hpwdt.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index 654e22b84c80..6e71106f4e4c 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -33,7 +33,6 @@ static unsigned int soft_margin = DEFAULT_MARGIN; /* in seconds */ static bool nowayout = WATCHDOG_NOWAYOUT; #ifdef CONFIG_HPWDT_NMI_DECODING -static unsigned int allow_kdump = 1; static bool pretimeout = 1; #else static bool pretimeout; @@ -144,8 +143,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs) if (iLO5 && (ulReason == NMI_UNKNOWN) && !mynmi) return NMI_DONE; - if (allow_kdump) - hpwdt_stop(&hpwdt_dev); + hpwdt_stop(&hpwdt_dev); hex_byte_pack(panic_msg, mynmi); nmi_panic(regs, panic_msg); @@ -184,10 +182,7 @@ static int hpwdt_init_nmi_decoding(struct pci_dev *dev) if (retval) goto error2; - dev_info(&dev->dev, - "HPE Watchdog Timer Driver: NMI decoding initialized" - ", allow kernel dump: %s (default = 1/ON)\n", - (allow_kdump == 0) ? "OFF" : "ON"); + dev_info(&dev->dev, "HPE Watchdog Timer Driver: NMI decoding initialized\n"); return 0; error2: @@ -346,9 +341,6 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); #ifdef CONFIG_HPWDT_NMI_DECODING /* { */ -module_param(allow_kdump, int, 0); -MODULE_PARM_DESC(allow_kdump, "Start a kernel dump after NMI occurs"); - module_param(pretimeout, bool, 0); MODULE_PARM_DESC(pretimeout, "Watchdog pretimeout enabled"); #endif /* } */ -- 2.13.6