Received: by 10.223.185.116 with SMTP id b49csp1010398wrg; Fri, 16 Feb 2018 10:45:45 -0800 (PST) X-Google-Smtp-Source: AH8x226ywxdr1u/ofQ9PM8SGW5D6Xu0ELnfhLEOCxycvjoqgUyZfaEOblQ60wOFQZkhmxVLRjlzQ X-Received: by 10.98.159.200 with SMTP id v69mr6929410pfk.236.1518806745404; Fri, 16 Feb 2018 10:45:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518806745; cv=none; d=google.com; s=arc-20160816; b=Lc1/+kDuFERX6YdPXpE4nXpVq60Xu4B5gpkfFgtI0d4eyu/pSUiSc2nepFP89Gatrn iQWIpJukssgoIUPCuJRHYt6lpLZDMg+Cb1263iHHvEvr527LP6v6FyAe34ZoxRKcNbzR OMLQuwqRXxIU6UfZC0YXhumiH+bHdTm/BhJznc28ilMG4NC3Q6a8GWsYVQ/l3Df8yASm C2XFs9Smo+K7abonHYhxzkgWk8chiF1DdOjBGf4M9z9ZpIct3Qq7ZkKW81YZl8ohKjab +cdjsiViRZZ3Vn46aVbJ7XFhXbQbcO6T3qsWCOgvcokx5MWaop+sQIvhLaW1Dqz63S5j y4Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=9iUNHGd9OAxaAXILoF2dHZZk3BYkflPzbIVLSGocick=; b=BFo/4ccxBiGKdOJ4puvsryijZpodhvJoBgz422EAc0USdldYwXdX91LZhY4jFLeXpx vpXw3fJ56PafnEegU3nIoZPAlc2S+QiNav34GXllVf+z2kpCtUTwZNxjnRA3JK8Q1RuC 73IACT1MHbE1TTVPPwcPqytfgUEBRDGYRz5D0va6zPJfPlt60Gc4yjNOPjXdBJf7u6gj YmAz9XGlHCS90e+ckcvdkS5zjwdaAwaVbd3fjSmjPjskANkUYR3XDuB6oTBqM0tBBjBd YGo5FVnWHtGIwWSA4uTZbx0nNnDkNZk7vVFgEdqYv5oQnFfKyVJBq7AuUJ0mMI3LXcaV IQ0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=gXw5jbCd; dkim=pass header.i=@codeaurora.org header.s=default header.b=FtRYJ13x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f15-v6si4840333plr.336.2018.02.16.10.45.30; Fri, 16 Feb 2018 10:45:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=gXw5jbCd; dkim=pass header.i=@codeaurora.org header.s=default header.b=FtRYJ13x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752515AbeBPEsx (ORCPT + 99 others); Thu, 15 Feb 2018 23:48:53 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52492 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbeBPEsq (ORCPT ); Thu, 15 Feb 2018 23:48:46 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 24F7160A36; Fri, 16 Feb 2018 04:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1518756526; bh=35tfnOzcBjm0xfBjb9bttJwt7uGaciG9vuPmNagxxmo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=gXw5jbCdswumdWRFlSwbvRfzJ1UEo0OIpxHU26WXxjSLFwqTM6ULsOJrBRKIWIFr0 KW4xvcRUHeIGTkAxA6EPIDTa8y4WZG/eapcr0busHDSawfH6gliUKvbSvgJNY/pAhb /RhglthLG0AWgjPCk5HEKLO9iUa/CBgsxJSmZv54= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.201.3.39] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sricharan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A46A560385; Fri, 16 Feb 2018 04:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1518756525; bh=35tfnOzcBjm0xfBjb9bttJwt7uGaciG9vuPmNagxxmo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=FtRYJ13xFhAuF4HIYAJUlZB/PrZjpm8HHS3eis8lUZtfQKsVg6dM+5jRGqi4QViP0 +q9+/DzHzREwA+rl3OczYxp01ZNj0rLkTEZb6vtm0jlqawz9eeUzvqUdF+oyiJs0bL Plpisu494JfoTcPsW/qlEc7WTvB7njkuvtMJYHQc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A46A560385 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org Subject: Re: [PATCH 08/12] i2c: qup: change completion timeout according to transfer length To: Abhishek Sahu , Andy Gross , Wolfram Sang Cc: David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <1517644697-30806-1-git-send-email-absahu@codeaurora.org> <1517644697-30806-9-git-send-email-absahu@codeaurora.org> From: Sricharan R Message-ID: <7dcbac1f-edaf-aecf-8e58-04d243384758@codeaurora.org> Date: Fri, 16 Feb 2018 10:18:40 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1517644697-30806-9-git-send-email-absahu@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/3/2018 1:28 PM, Abhishek Sahu wrote: > Currently the completion timeout is being taken according to > maximum transfer length which is too high if SCL is operating in > high frequency. This patch calculates timeout on the basis of > one-byte transfer time and uses the same for completion timeout. > > Signed-off-by: Abhishek Sahu > --- > drivers/i2c/busses/i2c-qup.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c > index a91fc70..6df65ea 100644 > --- a/drivers/i2c/busses/i2c-qup.c > +++ b/drivers/i2c/busses/i2c-qup.c > @@ -130,8 +130,8 @@ > #define MX_TX_RX_LEN SZ_64K > #define MX_BLOCKS (MX_TX_RX_LEN / QUP_READ_LIMIT) > > -/* Max timeout in ms for 32k bytes */ > -#define TOUT_MAX 300 > +/* Min timeout for i2c transfers */ > +#define TOUT_MIN 2 > may be you can mention, why is this 2 ? Regards, Sricharan > /* Default values. Use these if FW query fails */ > #define DEFAULT_CLK_FREQ 100000 > @@ -172,6 +172,7 @@ struct qup_i2c_dev { > int in_blk_sz; > > unsigned long one_byte_t; > + unsigned long xfer_timeout; > struct qup_i2c_block blk; > > struct i2c_msg *msg; > @@ -845,7 +846,7 @@ static int qup_i2c_bam_do_xfer(struct qup_i2c_dev *qup, struct i2c_msg *msg, > dma_async_issue_pending(qup->brx.dma); > } > > - if (!wait_for_completion_timeout(&qup->xfer, TOUT_MAX * HZ)) { > + if (!wait_for_completion_timeout(&qup->xfer, qup->xfer_timeout)) { > dev_err(qup->dev, "normal trans timed out\n"); > ret = -ETIMEDOUT; > } > @@ -1601,6 +1602,8 @@ static int qup_i2c_probe(struct platform_device *pdev) > */ > one_bit_t = (USEC_PER_SEC / clk_freq) + 1; > qup->one_byte_t = one_bit_t * 9; > + qup->xfer_timeout = TOUT_MIN * HZ + > + usecs_to_jiffies(MX_TX_RX_LEN * qup->one_byte_t); > > dev_dbg(qup->dev, "IN:block:%d, fifo:%d, OUT:block:%d, fifo:%d\n", > qup->in_blk_sz, qup->in_fifo_sz, > -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation