Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ipmi: kcs_bmc: mark expected switch fall-through in
 kcs_bmc_handle_data
To:     minyard@acm.org, "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <20180214173029.GA15661@embeddedor.com>
 <9098c6c8-83e5-5e1f-519b-68e14738c24a@acm.org>
From:   "Wang, Haiyue" <haiyue.wang@linux.intel.com>
Message-ID: <3b2c65e6-a8bd-9b6c-5b13-c1d80f546215@linux.intel.com>
Date:   Fri, 16 Feb 2018 16:27:01 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <9098c6c8-83e5-5e1f-519b-68e14738c24a@acm.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2018-02-15 05:46, Corey Minyard wrote:
> On 02/14/2018 11:30 AM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>
> Thanks, queued for next release.
>
> -corey
>
>> Addresses-Coverity-ID: 1465255 ("Missing break in switch")
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>> This code was compiled with GCC 7.3.0
>>
>>   drivers/char/ipmi/kcs_bmc.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c
>> index 3a3498a..6476bfb 100644
>> --- a/drivers/char/ipmi/kcs_bmc.c
>> +++ b/drivers/char/ipmi/kcs_bmc.c
>> @@ -95,6 +95,7 @@ static void kcs_bmc_handle_data(struct kcs_bmc 
>> *kcs_bmc)
>>       switch (kcs_bmc->phase) {
>>       case KCS_PHASE_WRITE_START:
>>           kcs_bmc->phase = KCS_PHASE_WRITE_DATA;
>> +        /* fall through */
Thanks, Gustavo. I see many modules have '/* fall through */', but I 
thought it was a just C comment, I didn't
add it for making code clean. Learned it, thank you! :-)
>>         case KCS_PHASE_WRITE_DATA:
>>           if (kcs_bmc->data_in_idx < KCS_MSG_BUFSIZ) {
>
>