Received: by 10.223.185.116 with SMTP id b49csp1017333wrg; Fri, 16 Feb 2018 10:53:50 -0800 (PST) X-Google-Smtp-Source: AH8x224XHg69gowLjE71isfenv+oseNDaRnY4/nacuMTFyp75XEl1aJVSkLNfEgSlI0Zfwa9zmtn X-Received: by 10.98.105.199 with SMTP id e190mr7010548pfc.70.1518807230660; Fri, 16 Feb 2018 10:53:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518807230; cv=none; d=google.com; s=arc-20160816; b=xS0pieAmkuDSVxRLWP6sdsNTqMUUaWDriw59qUWRytnEjQjZO1xg/LhYcA3Q0ugXN0 /wHLB6A4LCy+7SKjmw+7v0H+IFsQPqkcuFvox/icVozzJSEJ9z/GQvDnOTkXmzHxIKGl nvAIsshftPzLrfMdpZRgE15UZ3HuiJyRIh2AJcq+zcOZoRDE9FDQmskAeOB1cIx+aVj6 tauOMO8aeXjfRH5wJaXhclVzT7Uety1EZSGQvW3gKoWrOc4UWiBVVe5Z3tAZbs1QGHjR 5kIsZ/vb4l3q78R3IVshoUKUQkH9YYTGtaq5nQ0lOcRA5da/ZOpRwDzZGGJhR3uT6dVh R59g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=YZYffRDRV4iUEWu6wGKQFtuJLJ7JKTzDBii4mlWc3ZU=; b=qUsMM+Q0QEwmWq9dXJx9GN9EgEVc4TLeRSH37535v+p5/Z40EtLbVUFJP6onrJkdGY 6ak9HXAfKod2XA+6DEdRmJL0uMKxg59YRMCJzS8pOWj6B4k1BRwXXk327pMSExdikF+o MkV64dm4/AsNf5d5iiQuF7d9TRqvaXxs8cHQWZMv3A88wtf1dt69ACr0hS7zC8GKMstn kqB18cEU+zbI5RRNNlVIgYWUTvw0lJFi7kJNbW8nqcWxpdo5WJhNOCS9oDDIPzFOPvJC WaO2rNm1qcViTrgMrkhL7PjWkoPmZz8ms7M7asJKaNxS7hKDMFxsxLCE90dwg9amGPUF dA+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=RpInzmdB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j186si38731pgc.578.2018.02.16.10.53.36; Fri, 16 Feb 2018 10:53:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=RpInzmdB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757849AbeBPJUX (ORCPT + 99 others); Fri, 16 Feb 2018 04:20:23 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:46950 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757435AbeBPJUV (ORCPT ); Fri, 16 Feb 2018 04:20:21 -0500 Received: by mail-qt0-f194.google.com with SMTP id u6so2956831qtg.13; Fri, 16 Feb 2018 01:20:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=YZYffRDRV4iUEWu6wGKQFtuJLJ7JKTzDBii4mlWc3ZU=; b=RpInzmdBEMSf/5j+Yw74RgkHZwRUTFr03WBVVCmFKfqI/75oASsC7eb3cMeRmKQk4I KTeUe0hwF0Vwb2qfgTylyPyvWaN1iN7xzuCp72eQ+1AQ2HKQcm/8axcY0pm1rQYpUU7X xrsQB4g+jHkKYLHjyhuNx2GlLgXK9tvBAIkM/iBQJutIb0Xa0lqVpSnQ9UaHsSHOqK4T RmZiFrbp1MT58pk3Cz7y+MzhDLwIK4b7Yg24ebqtfFALrjZju5iaaZmaV/Pl0m8KdSm4 teJEkrBlqUHYET6kkHksTdfhLYxyNHvD0tshBp+bhAD2SPsXvzP/hwLbZNwwYJRGoops ISgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=YZYffRDRV4iUEWu6wGKQFtuJLJ7JKTzDBii4mlWc3ZU=; b=AwdQ6QKZkYenQBcMmbbjqKh9Ka3lPmEAvm2yZzCzTZMzbbfSNuyAtL+7bqazw14J0g rfQCSQoKM6s4/lk+Fs8p6wpcpPZhJMbkm/SQOwBGB5AbKUSQ0WRkk97xRDFT0GM4HNXM cS2B7kvxPBCSXC+z2XEwMBMycVCZGBLadXreOMfw0fmG7LI2zxgK1jYBdgjoeyZFf4Bu QjRBJnbJP4hhjJ8eGZTSmpd+BmId+ewIiuOORo6F1UxxBo1bLvoSU5a+yAZ1sF2HttiW zmuZfl3eW6bEXZ44qQS/o2xS/lMKkfAkED8TASqdNWP4WubrnAboPjayg76eeBjKlfXz OBKA== X-Gm-Message-State: APf1xPAkieozICbFXoM7U9I9spcuw9O5kTNPHMJCSz0H+2gDuwl8PaY9 OZRsv29/UPejanietVukx7mu3NMDC3oDOobkwmc= X-Received: by 10.200.112.1 with SMTP id x1mr8690339qtm.138.1518772820823; Fri, 16 Feb 2018 01:20:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.47.219 with HTTP; Fri, 16 Feb 2018 01:20:20 -0800 (PST) In-Reply-To: <1518515162-23663-6-git-send-email-jacopo+renesas@jmondi.org> References: <1518515162-23663-1-git-send-email-jacopo+renesas@jmondi.org> <1518515162-23663-6-git-send-email-jacopo+renesas@jmondi.org> From: Geert Uytterhoeven Date: Fri, 16 Feb 2018 10:20:20 +0100 X-Google-Sender-Auth: 4sE__txqEEDP-vZaMVwC6ZolLfE Message-ID: Subject: Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support To: Jacopo Mondi Cc: Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel@lists.infradead.org, Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > @@ -0,0 +1,495 @@ > +// SPDX-License-Identifier: GPL-2. > +/* > + * Device Tree Source for the r8a77965 SoC > + * > + * Copyright (C) 2018 Jacopo Mondi > + * > + * Based on r8a7796.dtsi > + * Copyright (C) 2016 Renesas Electronics Corp. > + */ > + > +#include For the initial submission, it's better to use hardcoded numbers than the R8A77965_CLK_* definitions, as the latter go in through a different tree. Hence you should replace above include by #include and replace R8A77965_CLK_* by hardcoded numbers in all r8a77965.dtsi patches. > +#include > +#include For the initial submission, it's better to use hardcoded numbers than the R8A77965_PD_* definitions, as the latter go in through a different tree. Hence you should drop the above include, and replace R8A77965_PD_* by hardcoded numbers in all r8a77965.dtsi patches. The hardcoded numbers can be replaced by symbolic definitions later, when the definitions have hit mainline. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds