Received: by 10.223.185.116 with SMTP id b49csp1027778wrg; Fri, 16 Feb 2018 11:04:42 -0800 (PST) X-Google-Smtp-Source: AH8x2243j1UsIhWOnRkU0R9nIA+kAOVyDIa8k0pxKAVy0rkEh8+Q3oztHBeGAOqMrqcu+lDi86aA X-Received: by 2002:a17:902:1e5:: with SMTP id b92-v6mr6694621plb.383.1518807882029; Fri, 16 Feb 2018 11:04:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518807881; cv=none; d=google.com; s=arc-20160816; b=rwtYeRtWQzgiJ2M9K6m0ZthBrAfOTjTFw2Y7b9kby6aBjWIGyq7CcbAxc4OBqQ5k3c SFkAreEo8J13tKGzyphG1tVRO3ChIFm9Qi8rm09+tYlBff7KoEp1a8279eVFk9pxbj7U a0DCAa0tIee6S47t6wya1Y0SIgzg2FbDJqvMRgt+wRuK2swV22BnCmHtUXeSmFpTx9or iGhu/1RdktTNBkS4tuikCR9wts0/vuFXKze1qeJd/Xp7bETAo3g51hA9WabiJ/xaMc/a qaVY7eMTI8rLZQYPwMP1UKwq6s3Rj4yuSwHAouwq7/1Z27y6HASOYkEkEd0Hdk1s+uCD Sdbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=NWbYFuZDIjBEzNX2Iy5fbdzaw8smpfm79ECLYzfdk7o=; b=mtcgLB16whxn+2jWoc+dRZ86eIbyQEEocML72XQUtZ9h/J8iwcRR8WdS3zCeTOy30X hTCYqX+viWk1fEAgXstx4qICXgXRgSL1Xl4os7eAurXCtFiwH6G72GqEaN/IwpMQPjmp cSWzG/TSXg7C5+DENIZG1IPmdFOcimX0Ksc/EAv0S/tt9CKQ1eQ/xFDlw+xUOeBGcp2d VyERiOqgTsxOVnHKO1rO7WDsROAR3Kf/SOduTnm5N21WnednXrnX/dsexe2onlkuefVA DDmZrt1FsgOsCn6LutBtQYNIdViZgMlUL7jHFCZf0uyr9fqyqDkd5SE4p603YLyE7AiG JEfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=d7vaUy3F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l25si147904pgc.127.2018.02.16.11.04.27; Fri, 16 Feb 2018 11:04:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=d7vaUy3F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965468AbeBPLyn (ORCPT + 99 others); Fri, 16 Feb 2018 06:54:43 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:51658 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965036AbeBPLyl (ORCPT ); Fri, 16 Feb 2018 06:54:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NWbYFuZDIjBEzNX2Iy5fbdzaw8smpfm79ECLYzfdk7o=; b=d7vaUy3FDMEiGXq/+VRYDsqAe HKiwpH7b53lGaafhEJjABC9fhNBur0y+dFLSmzgHQjoX1KKssChvznLFhC7oOxBGDvJyX0CS/9/9z vKn4Yxww5m+UKyvvVr2haaMJpoKbRuV74kXB29hIProxy/VnwcYMwRoHjEzk25txmFY3w=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1emeb6-00041X-SR; Fri, 16 Feb 2018 11:54:36 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1emeb6-0004Kq-6h; Fri, 16 Feb 2018 11:54:36 +0000 Date: Fri, 16 Feb 2018 11:54:36 +0000 From: Mark Brown To: Cosmin-Gabriel Samoila Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, robh@kernel.org, mihai.serban@gmail.com, linux-imx@nxp.com, shegjiu.wang@nxp.com, daniel.baluta@nxp.com, linux-kernel@vger.kernel.org, Junichi Wakasugi , Mihai Serban , Shengjiu Wang Subject: Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver Message-ID: <20180216115436.GF5886@sirena.org.uk> References: <1518614467-20613-1-git-send-email-cosmin.samoila@nxp.com> <1518614467-20613-2-git-send-email-cosmin.samoila@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V4b9U9vrdWczvw78" Content-Disposition: inline In-Reply-To: <1518614467-20613-2-git-send-email-cosmin.samoila@nxp.com> X-Cookie: To order, call toll-free. User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --V4b9U9vrdWczvw78 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 14, 2018 at 03:21:06PM +0200, Cosmin-Gabriel Samoila wrote: > --- /dev/null > +++ b/sound/soc/codecs/ak4458.c > @@ -0,0 +1,659 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Audio driver for AK4458 DAC > + * Please don't mix C and C++ comments line this, just make the entire block a C++ comment. Since this looks otherwise good I'll apply this, please send a followup patch fixing the above. --V4b9U9vrdWczvw78 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlqGxnsACgkQJNaLcl1U h9A0cwf+M273FLdr5luerf/pSFQ8Ill9TfoBPOaPdnMWysZTvUhHiCrx5/okTE4C m8gS2iBV7pF09JiC5+NjJu8n8mAdQQQ6ISTJewZVsRMEuDoBE022DIXVrCTzaCZO WtaT+nemH/7RA6E4gzHaY17Rl00+xlKER6PdM6jj8sTwNJ2Z3dsUq64Q6wEOJzrZ 6fxcGkWdrfrwqvmmI6U8ipqXThDII4SCfIm5TDtmhsOTnzYcCM5NYNQlGbsDoseI rHK02ILoHYXDUQQodHJSmm/7/8bD+CuIcFVoI1eyWPr6n/M4cwWutTi5tYrDzQGz ybJthCJww6lsxe6vWy4xkfq3+BSOcQ== =YIZA -----END PGP SIGNATURE----- --V4b9U9vrdWczvw78--