Received: by 10.223.185.116 with SMTP id b49csp1036743wrg; Fri, 16 Feb 2018 11:14:08 -0800 (PST) X-Google-Smtp-Source: AH8x224ywqpybg5gtGvkyjhWzvK2VmedPatFYh1ZHEJOzq2B45Is9p4PXhtOnCvH6HQ4mCkU1HeC X-Received: by 10.98.90.132 with SMTP id o126mr6906499pfb.239.1518808448810; Fri, 16 Feb 2018 11:14:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518808448; cv=none; d=google.com; s=arc-20160816; b=o2JKtF7umdm6bfYOZcORvB12qbCSJEaQT3QcIaUheebhwNK+4hFgyJSNLl5AsYGxil intc7PIiU3kELW/8UtZUjfBJwUwTCSnPRmXY+C2WY6B8rgpPkCmfMinwEHfS7Ksc4j3v gdJjJRlnrV/u3Q75vZDECHUodN3qskMys2atUc+mKZ5FCvdo5L3xHvmBL5lSSxT5v+AH tfC5OTpaG9Xm9OeJQvYxd2VpDDKcrP0TwnBIxbEM4ZWAHPGX92Tcf9fAV2BhEajKZSm6 om+LKbq9WH6bjwXdYxkTCVx/a5lNQcRMJGFSHs6dwg3lLSR3pCG+3nJmDUwJ04dXTvqD aU4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=Yd9o/UtAniMdj8XDdObPuVfT+dO3GG06YwZC5KEIc60=; b=Oc7hfSKtEYZYuYxAYUe1Bljvj1xuQx7+SUwWfjiNUDNGrI7zMTddxaNuOOoYA3l6sK /scj/maJC+bUy/5zS7PV+Jwp5HGggxxuVxu7CnnIt1SsGNViN6QL/ZqHqwOFAi3Cfuof 1z8vlKsJt2gvNT7Vnyyx0EM5R2txl/iFSTjvrwPCdYKCyUH9jeMW90VdZYljv0RjPEaz cjs3NG4IVQa6rt6KXWuQerVz5Pa8YBOJ3PIJp0pb2XI79SOoaY/Q+GCXkx5XpnowlZlK /cNzH24y/0yFUcVzTLCg5kvun9HbQvVpvrhupqOEKSkksNNxXg/jdPjNwWyCbDZVbhWX B8OQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a35-v6si1859859pli.781.2018.02.16.11.13.54; Fri, 16 Feb 2018 11:14:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034618AbeBPO5H (ORCPT + 99 others); Fri, 16 Feb 2018 09:57:07 -0500 Received: from osg.samsung.com ([64.30.133.232]:36896 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033834AbeBPO5G (ORCPT ); Fri, 16 Feb 2018 09:57:06 -0500 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id 61AC034987; Fri, 16 Feb 2018 06:57:05 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eVqbUM3Pa3aO; Fri, 16 Feb 2018 06:56:55 -0800 (PST) Received: from vento.lan (177.17.248.146.dynamic.adsl.gvt.net.br [177.17.248.146]) by osg.samsung.com (Postfix) with ESMTPSA id F2BB93497E; Fri, 16 Feb 2018 06:56:53 -0800 (PST) Date: Fri, 16 Feb 2018 12:56:51 -0200 From: Mauro Carvalho Chehab To: Markus Heiser Cc: Linux Doc Mailing List , Mauro Carvalho Chehab , LKML , Jonathan Corbet , Jani Nikula Subject: Re: [PATCH 4/6] scripts: kernel-doc: support in-line comments on nested structs/unions Message-ID: <20180216125651.45401575@vento.lan> In-Reply-To: <54EF06CB-C31F-476D-B674-579E9385D635@darmarit.de> References: <54EF06CB-C31F-476D-B674-579E9385D635@darmarit.de> Organization: Samsung X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, 16 Feb 2018 15:52:33 +0100 Markus Heiser escreveu: > > Am 16.02.2018 um 14:48 schrieb Mauro Carvalho Chehab : > > > > The parser at kernel-doc rejects names with dots in the middle. > > Fix it, in order to support nested structs/unions. > > > > Tested-by: Jani Nikula > > Signed-off-by: Mauro Carvalho Chehab > > --- > > scripts/kernel-doc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/kernel-doc b/scripts/kernel-doc > > index fee8952037b1..06d7f3f2c094 100755 > > --- a/scripts/kernel-doc > > +++ b/scripts/kernel-doc > > @@ -363,7 +363,7 @@ my $doc_sect = $doc_com . > > my $doc_content = $doc_com_body . '(.*)'; > > my $doc_block = $doc_com . 'DOC:\s*(.*)?'; > > my $doc_inline_start = '^\s*/\*\*\s*$'; > > -my $doc_inline_sect = '\s*\*\s*(@[\w\s]+):(.*)'; > > +my $doc_inline_sect = '\s*\*\s*(@\s*[\w][\w\.]*\s*):(.*)'; > > Thanks! > > FWIW: added similar patch to python variant of kernel-doc: > > https://github.com/return42/linuxdoc/commit/5c5da9a > > rendered example: > > https://return42.github.io/linuxdoc/linuxdoc-howto/all-in-a-tumble.html#struct-my-long-struct On a quick look, on your example, bar2.barbar description looks different than what we get from the perl version. There, it generates it as: ``bar2.barbar`` Description for **barbar** inside **foo.bar2** Regards, Mauro