Received: by 10.223.185.116 with SMTP id b49csp1037597wrg; Fri, 16 Feb 2018 11:15:02 -0800 (PST) X-Google-Smtp-Source: AH8x226BDZUEEfCfVhq1qreBFVcIZFjAP51JQ18q+Rggo4QtzaGHNwZs/G2jjko86S+f8oh6nHxV X-Received: by 2002:a17:902:1486:: with SMTP id k6-v6mr6931201pla.376.1518808502159; Fri, 16 Feb 2018 11:15:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518808502; cv=none; d=google.com; s=arc-20160816; b=oBVQ64mZe/bF+wFGZCObQDIhciZ4R0/HHuEIeoUuweJzePYBAUe/WE1eoFMGm1W7Vu DNJ+Mmd8cgR+vko3X9Pvrl9GU++wW5EGLs4XlLDsQ507WTaPopyoCM64X3fgzMM7wNbW LRHfaL+ujkxiGwKVhxoPmorkeZvjYG6MJNMNQzfdL9hjFBoUr1phaeyrd22TVJEiP+Fk gWrfM+SNEksWSz1OmOuIvuXrzQaaxroH9E18ixz+YDUF64ILa5nQjkp0HyO50B3L1gwK goXxgfXae7SLB1Ljvhknnk4OfeJI7KTczRfk6B1dVUsDMTezVNsZXsXIMVUd3JkBjMvV siYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:arc-authentication-results; bh=psWL57KS76CWjWHuKPQN1W67rT7CmN/0JV2JNbobbog=; b=fkzRkJ2YM4uRsNkBtjvDAiP96tNFEGnbZDzwRcx2v8dpcvzw+8CVBa3/Zt++c633GD //raMSyok2zGotji+9cjjltSWYf5XtqV4rEAIELY2TvKGJ17QCRaVgIeFN6QU+tBsnZ6 oPNBT5JmqNitwly7kopDAFNbgsCRePrAXT4KsgN/QEy07ypyg4086Wqizja8/Oc6l3Ki 4WxPXUP2pv6ci+1yVeH/388wZBx+2m7EBaKAExJsQ83RnH8iuy8rQ9NYnFaJ8VCFvhN9 WRx5WrNpAGi0V9DHKz4Lg9AvatDq/jXCSrPw5/a+kOyxiAHZcdLopbIgTZhz8sc/ZCUn 7TtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u7si154019pgq.712.2018.02.16.11.14.47; Fri, 16 Feb 2018 11:15:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034535AbeBPOwm convert rfc822-to-8bit (ORCPT + 99 others); Fri, 16 Feb 2018 09:52:42 -0500 Received: from smtp3-1.goneo.de ([85.220.129.38]:42656 "EHLO smtp3-1.goneo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034503AbeBPOwk (ORCPT ); Fri, 16 Feb 2018 09:52:40 -0500 Received: from localhost (localhost [127.0.0.1]) by smtp3.goneo.de (Postfix) with ESMTP id C353623F417; Fri, 16 Feb 2018 15:52:37 +0100 (CET) X-Virus-Scanned: by goneo X-Spam-Flag: NO X-Spam-Score: -2.801 X-Spam-Level: X-Spam-Status: No, score=-2.801 tagged_above=-999 tests=[ALL_TRUSTED=-1, AWL=0.099, BAYES_00=-1.9] autolearn=ham Received: from smtp3.goneo.de ([127.0.0.1]) by localhost (smtp3.goneo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nh_swd9NjOae; Fri, 16 Feb 2018 15:52:36 +0100 (CET) Received: from [192.168.1.112] (dyndsl-031-150-100-249.ewe-ip-backbone.de [31.150.100.249]) by smtp3.goneo.de (Postfix) with ESMTPSA id 6A9D723FA15; Fri, 16 Feb 2018 15:52:34 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH 4/6] scripts: kernel-doc: support in-line comments on nested structs/unions From: Markus Heiser In-Reply-To: Date: Fri, 16 Feb 2018 15:52:33 +0100 Cc: Linux Doc Mailing List , Mauro Carvalho Chehab , LKML , Jonathan Corbet , Jani Nikula Content-Transfer-Encoding: 8BIT Message-Id: <54EF06CB-C31F-476D-B674-579E9385D635@darmarit.de> References: To: Mauro Carvalho Chehab X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 16.02.2018 um 14:48 schrieb Mauro Carvalho Chehab : > > The parser at kernel-doc rejects names with dots in the middle. > Fix it, in order to support nested structs/unions. > > Tested-by: Jani Nikula > Signed-off-by: Mauro Carvalho Chehab > --- > scripts/kernel-doc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kernel-doc b/scripts/kernel-doc > index fee8952037b1..06d7f3f2c094 100755 > --- a/scripts/kernel-doc > +++ b/scripts/kernel-doc > @@ -363,7 +363,7 @@ my $doc_sect = $doc_com . > my $doc_content = $doc_com_body . '(.*)'; > my $doc_block = $doc_com . 'DOC:\s*(.*)?'; > my $doc_inline_start = '^\s*/\*\*\s*$'; > -my $doc_inline_sect = '\s*\*\s*(@[\w\s]+):(.*)'; > +my $doc_inline_sect = '\s*\*\s*(@\s*[\w][\w\.]*\s*):(.*)'; Thanks! FWIW: added similar patch to python variant of kernel-doc: https://github.com/return42/linuxdoc/commit/5c5da9a rendered example: https://return42.github.io/linuxdoc/linuxdoc-howto/all-in-a-tumble.html#struct-my-long-struct -- Markus --