Received: by 10.223.185.116 with SMTP id b49csp1041471wrg; Fri, 16 Feb 2018 11:19:29 -0800 (PST) X-Google-Smtp-Source: AH8x2266SKNL9XIsjd9zeFdLYiJIdvMlGG2B0AVvA/6tY455SvelQG5JfL/6nf+F7wfN2goGvb/h X-Received: by 10.98.5.129 with SMTP id 123mr6985829pff.75.1518808769237; Fri, 16 Feb 2018 11:19:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518808769; cv=none; d=google.com; s=arc-20160816; b=fZR1vNTIUwy2+m1Ptgp7kaA7NNhaie9TLxXJXBTUE+k/4NuszN/4naozBeVxQFdcRi DKnXC6lOFotBnG5sien9XusOYyZfbrdb3P023ttePq9nIFaEhz/b7E64UphKqpcU8ao/ M9HVNI1d/MukwGYdIKyyp8s4J1kOPvIWRcJEsXnSX6nSD+6EAnRI+iAASLHO3+Y2jRAv V+Luqn7XA8BMKBp6/321VTno6g1jwqJdOmG6xVe8i7OETzRCCF6QQsQ1WIGSZhfNL8wu Aynf6xNw2FJRrt/MFmahZIyaSDLM1ivyqcuOvN88EPx0Abl435Cs2EzpWjPZ+uT+euKj 6T/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=7Z0qDSIEB4edDSjt6Pj1F5SfZUD92yAN0uaVN7YmtlE=; b=JoNbEmN3Xag0VpZxQJTcvP9FGOdHiy5o7dDJMjwBrxo6nIepv0jChnmdmQkQcVOmuX gBvgaer4CezchUqAzZbdOEGCQmnJqR+JRdp38rONLSn39TcHkKrTIO3wMMV1BZux+RFv fT5ZbFB8x7ItZXUT0bLcZBEog8V9KxWmetJSyD1iPtf3ksOVtuuiaS0vGE3ickoYfyLh 3iHy1TdiJDgRa/vwFWs9790Tus55P4F2ih8XXFt9QerOLTJxve9T9Xy6ovy/lxxAkiSK YaFucj3cEfCQQti+Rq5sLHM27B1zLXMlKwaYFMpIz/iid1lXSQJeVFFvqx71eTG3HhNy Eoxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lf766cQi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b10si1790041pge.563.2018.02.16.11.19.14; Fri, 16 Feb 2018 11:19:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lf766cQi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031797AbeBPQ3a (ORCPT + 99 others); Fri, 16 Feb 2018 11:29:30 -0500 Received: from mail-it0-f49.google.com ([209.85.214.49]:37090 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbeBPQ33 (ORCPT ); Fri, 16 Feb 2018 11:29:29 -0500 Received: by mail-it0-f49.google.com with SMTP id d10so2475863itj.2 for ; Fri, 16 Feb 2018 08:29:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7Z0qDSIEB4edDSjt6Pj1F5SfZUD92yAN0uaVN7YmtlE=; b=lf766cQiYt2/fYzYb9e7Nb6tQbQcvTZqeHS9wqJpFWewU6vtVTkWJ4pWQ5UCqmoXCJ ALgCtc4IH189FkgcOlTEbLq43blPBMDClg6/XZzenuvI8Awzb53gt4g13Mw10u4T34f1 Dsxoq3h+0r8JK1yjsO7Q7mrTD2fzOIr/oZzw1PShOIz/0+Dlbxal8ppxvdz6X/U5QOok tckEO0vf/4CE5GTiS6HCwR2eBJJoNcUWEoQ60qInpVvBqBhec891PBLqZydYvyiZABtK NOmMc/DqLsqTgM2RbpHWbkvO0J/bqbFcK+eWSce885puJNKxcfpK7sbOvlnaoZNiN2fT 6Ibg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7Z0qDSIEB4edDSjt6Pj1F5SfZUD92yAN0uaVN7YmtlE=; b=Jsi+/+5vsPL1k4PMee92lnCil9K05sEVZiwN5khQ5Qxn2vUV3VW3p7MBBt6NNo0mmy KX5VV5jOJn72VY1Cc4e0SLNjdG4Z52bmbwHViTGSYA1IO9VPFgEj/3H/+mgD0X3E/xjm FTmF2X1ZMIZVk2KKNT3bX20lhkD+cPkocpqvMNQ6euLxHz8nwThAManYqgFiyssxjE0k WeQ9O31tv/hIHMmolUWNlHCu2clkfem/lz0u0uJG2y5k1bUPNat59urfxBMOEzoE48O6 RQjsHXwM+om3HOkGwKFn1YVypVMuto6YPv9HzFopinKWuTAfMcWjJ8rfKfkvCr0RfKPf qWnQ== X-Gm-Message-State: APf1xPBVCOfC6Ds1J6zhtl4LgH5/UBdhCiJcW64p0Kfoz7AtkU3QI4Gt DPnS1cJ0pKAEpe4eny2NUGlp1nmVofjO599nE5Pw3Q== X-Received: by 10.36.129.196 with SMTP id q187mr9128394itd.95.1518798568300; Fri, 16 Feb 2018 08:29:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.128.36 with HTTP; Fri, 16 Feb 2018 08:29:27 -0800 (PST) In-Reply-To: <4be4e462-61be-53a9-b0e1-3508466d1645@redhat.com> References: <1517938181-15317-1-git-send-email-dwmw@amazon.co.uk> <1517938181-15317-8-git-send-email-dwmw@amazon.co.uk> <4be4e462-61be-53a9-b0e1-3508466d1645@redhat.com> From: Jim Mattson Date: Fri, 16 Feb 2018 08:29:27 -0800 Message-ID: Subject: Re: [PATCH 7/9] KVM/VMX: Emulate MSR_IA32_ARCH_CAPABILITIES To: Paolo Bonzini Cc: David Woodhouse , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , LKML , kvm list , KarimAllah Ahmed , Greg Kroah-Hartman , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 16, 2018 at 6:18 AM, Paolo Bonzini wrote: > Uhm, taking contents from the hardware is wrong (guess why---live > migration). I'll send a revert of those two lines. Hardware seems like a reasonable place to get the default value (cf. the VMX capability MSRs). Should these two lines just be moved to vmx_create_cpu?