Received: by 10.223.185.116 with SMTP id b49csp1044044wrg; Fri, 16 Feb 2018 11:22:33 -0800 (PST) X-Google-Smtp-Source: AH8x225iXqRob/z/jvjmtX8lSCm3Ee+PqTZf2pOTSD9WXLXuqhhWdCDUc8T50g+eyTu7NTqMmNpk X-Received: by 2002:a17:902:4201:: with SMTP id g1-v6mr6760923pld.62.1518808953820; Fri, 16 Feb 2018 11:22:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518808953; cv=none; d=google.com; s=arc-20160816; b=vJAeOQVS75XNhGO6uy1diaFG4aDmUqx5DgiCntQh4BDV8NUlFQ3XIVPUjx9SsJeAY8 ZYB+xswanEU7UggxTJDODjyIujbGVwTzzoBTR+IDQgDrrPUiVzCzBI67KOdklX87r7cR GC61ucJJMzYWoL8nYMrk/nrIFsSPvX2mlnJLj2IFsnC/82rAvs8vcRll5/27akDF5axX TP34cyVwzJcMmU/bTy5HfpCnvHsPxSMb5xBpQeZTGojnH7Otvlz0EzyVMSzHVDvDOMGS YPRcp0b8lCF3HCPfUSez2/qW6UrZ1gUy2RsDKV/MvVTMywp0H/u7IwsxhBtZ/WTSwPgn 7zJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=wYEPHYemIy7ln3DDQspdyyBnsHRZkHXVWEEyRrosF7Q=; b=LeMMZ4r9Id7y5f8hE7/jsD8VyP+nLw/d0SksdfoFEL267CzSsq6INpcVsfToSxq41I SonkN6VDMUn1t0Ch+GZP+3Y9fC+grJjxsjwSx6akdZbXnBqE4pYQLoZeZz5X/1Eg5hIA p6yb5bCfQS/sm1IO7C2JsVlem35bXFEZB4FjTbBRamTyAV5RZ+vaecdoX0lBZvo2YzG4 Bh1w8YU7EEaL4d5lRfdcbNIsNbjKqUtKM2fMgbLir8phXneIhHpQKywhYEzs0U0wNE8i k0mGf0a8vG2e9o8LeFCW4FwOTABd06nfqurWrlvAsvvNrtVK2zd7CfspEJzPr/dTYwNM GGvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=CDjhv6Lt; dkim=pass header.i=@codeaurora.org header.s=default header.b=TXRCWFAv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d24-v6si12339plr.243.2018.02.16.11.22.19; Fri, 16 Feb 2018 11:22:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=CDjhv6Lt; dkim=pass header.i=@codeaurora.org header.s=default header.b=TXRCWFAv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162551AbeBPR5P (ORCPT + 99 others); Fri, 16 Feb 2018 12:57:15 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:32808 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161687AbeBPR5O (ORCPT ); Fri, 16 Feb 2018 12:57:14 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 132FD60B67; Fri, 16 Feb 2018 17:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1518803834; bh=1iLiitc9RTVjP1zg4CMKTk/JLMcVLgyhTztM74QGAkA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=CDjhv6LtvR9extUf9f+J8N60LO7Lzv1A/8qasmmtbHTMgH8+CowvCQmOFYM7Llcwo NJ+zyUkGfcsKB4ONMFq7ZOkWQz225Hz1FhjvchJeGdNaMR4VPmLwp3fY38HRIjWKcN s5hqmwDe7YR3y81lakAfPvKqUqRmjyUHi6HlIg90= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from lmark-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lmark@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2226360558; Fri, 16 Feb 2018 17:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1518803833; bh=1iLiitc9RTVjP1zg4CMKTk/JLMcVLgyhTztM74QGAkA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TXRCWFAvbO7esOgzGxBFVSIPiQMRzXWRYce5EfmfmOJp3nmbxuau7Loyb9ii2DkSi o9EkHR/luIOp8Zijunw/t1+2D8WB+6YqsFeegyx3A1yaECcZlTZx/SZzGF03VzdLVr MgeIPG+bsI7LGjcAQ9NzC+8nMvatnTONWa8OMPUU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2226360558 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=lmark@codeaurora.org Date: Fri, 16 Feb 2018 09:57:12 -0800 (PST) From: Liam Mark X-X-Sender: lmark@lmark-linux.qualcomm.com To: Greg KH cc: Laura Abbott , Sumit Semwal , devel@driverdev.osuosl.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: android: ion: Initialize dma_address of new sg list In-Reply-To: <20180216162353.GA13019@kroah.com> Message-ID: References: <20180216162353.GA13019@kroah.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Feb 2018, Greg KH wrote: > On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote: > > Fix the dup_sg_table function to initialize the dma_address of the new > > sg list entries instead of the source dma_address entries. > > > > Fixes: 17fd283f3870 ("staging: android: ion: Duplicate sg_table") > > So this should be sent to the stable trees as well, right? > > Please add that when you resend... My understanding was that I should only send this to the stable branch if it fixes a real bug. Both myself and Laura can't see any actual problems that result from this issue, the change is more to help future proof the code. My commit message wasn't clear about this and could have mislead people into thinking there was a bug. I will update the commit message to make it clear that this issue doesn't currently result in any problem. Do you still want me to send it to the stable trees? Thanks, Liam Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project