Received: by 10.223.185.116 with SMTP id b49csp1053132wrg; Fri, 16 Feb 2018 11:33:05 -0800 (PST) X-Google-Smtp-Source: AH8x227z6yjmQoc0MIFvj83hR0h0kocqI5rTwIfUykTN/STk1xF8nwBGHftzO5begNnHyqCiWNQ0 X-Received: by 2002:a17:902:a50b:: with SMTP id s11-v6mr1754483plq.440.1518809585036; Fri, 16 Feb 2018 11:33:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518809585; cv=none; d=google.com; s=arc-20160816; b=Lf2/Tp9z0C+ljzVfIbjOlD+a29YxOBL8JEOQRTgbyO8MWBo5r1W42gQ1oZgWymDxqA Q1Gw/fseLFKm1+opFv5xNED+E2HKZJUu3mnfLGfikParSfoYsgdm2R/CF4GTCe/BbU8o YfeFUNAh+rWd2nsejxO5Vs7SSLKQ4xbkUCEp3AmuAD0YgQSegUmlkbV+s/ig3RiYw06X 2Etssj4jXHaRkfhbtn/c8NtSW9aO442Tz91N4LoGBKu8tbZ7O03Fg3k0os89Ffl/bTBZ ochPwthjyYVJ7y0Yu5px8CR1Sw9rZCBcD4ai7AjHa3r5VHA1Y4ZzTWYZTnOE0iotQIRD tB0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=GN/GifERuEZ0CsCMZZpP6d4SLlCHPmk3mT8GRnjQG6A=; b=yJjUbI+y/lPEUOZ1RN2j1DduOLxz9NXVoZhFtmxj7atKzCz5ospoD1xse5B21ymNrt NBifyHNdJ3+ho+NulyFz8NNpx3lye2D72aiutul0VeMMYpIoJXJDe6Ez/SBMvR+/NG3a 2RRgSww/P6BAMdwEeI5Rvodsk1EJY0YVHz6qqSShOJC2eqOOu84Afmhc1IfgWFwiT6vU c5gmj0GkXSq/9Bq3clUi/ukrh93RwpMTnd1HXTG+CpHYDCX00pIU4PYEJ0jBUbV2XkXs jOeF2Awh3E1ZLrs1NZeBIKH5bnTiyBrdOlH/+sXKyOEZQkmpVF0VIfvuED2sHwIs1P7C TdWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 30-v6si202523pla.812.2018.02.16.11.32.49; Fri, 16 Feb 2018 11:33:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1167461AbeBOXpB (ORCPT + 99 others); Thu, 15 Feb 2018 18:45:01 -0500 Received: from g2t2352.austin.hpe.com ([15.233.44.25]:52425 "EHLO g2t2352.austin.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164340AbeBOXo7 (ORCPT ); Thu, 15 Feb 2018 18:44:59 -0500 Received: from g2t2360.austin.hpecorp.net (g2t2360.austin.hpecorp.net [16.196.225.135]) by g2t2352.austin.hpe.com (Postfix) with ESMTP id 37E7585; Thu, 15 Feb 2018 23:44:59 +0000 (UTC) Received: from anatevka.ftc.rdlabs.hpecorp.net (anatevka.americas.hpqcorp.net [10.34.81.6]) by g2t2360.austin.hpecorp.net (Postfix) with ESMTP id AD22237; Thu, 15 Feb 2018 23:44:58 +0000 (UTC) From: Jerry Hoemann To: wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, rwright@hpe.com, maurice.a.saldivar@hpe.com, mingo@kernel.org, marcus.folkesson@gmail.com, Jerry Hoemann Subject: [PATCH v3 00/11] watchdog/hpwdt: Update driver to use watchdog core. Date: Thu, 15 Feb 2018 16:43:49 -0700 Message-Id: <20180215234400.5022-1-jerry.hoemann@hpe.com> X-Mailer: git-send-email 2.13.6 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org == v3 == Incorperating code review feedback. Following modifications were made: 1) Patch 0003: Use existing hex_byte_pack instead of creating new function. 2) Patch 0005: Redacted change in module_param permission. 3) Patch 0006: switch from pr_debug etc., to dev_dbg where possible. 4) Patch 0006: No longer updating soft_margin post module load. 5) Patch 0006: Initialize hpwdt_dev.parent before registering watchdog. 6) Patch 0006: Redacted change to dev_info message w.r.t. allow_kdump 7) Patch 0006 & 0007: Reorder patches to maintain bisectability. 8) Patch 0008: Change pr_debug to dev_dbg 9) Patch 0010: Change dev_info message w.r.t. allow_kdump where feature is removed. Note, I am explicitly ignoring the checkpatch error on Patch 0008 for specifying permisson of "0" instead of "0000". == v2 == 1) Fix compiler error when CONFIG_HPWDT_NMI_DECODING is not defined. 2) Break out driver version change to its own patch (0011). == v1 == The primary purposes of this patch set are to 1) Update the hpwdt driver to use the watchdog core. 2) Reduce complexity by removing unnecessary features. 3) Add customer requested features like optional pretimeout. 4) Enhance readability/maintainability of the driver. The size of the resultant driver is reduced from over 900 lines to 350 lines. Patch 1& 2 remove legacy NMI sourcing. Patch 3 adds useful indication of NMI cause to panic message Patch 4 & 5 are general cleanup Patch 6 & 7 updates the driver to user the watchdog core. Patch 8 makes the pretimeout NMI programmable. Patch 9 modifies whether the NMI handler claims the NMI. Patch 10 retracts the allow_kdump module parameter. Jerry Hoemann (11): watchdog/hpwdt: Remove legacy NMI sourcing. watchdog/hpwdt: remove include files no longer needed. watchdog/hpwdt: Update nmi_panic message. watchdog/hpwdt: white space changes watchdog/hpwdt: Update Module info. watchdog/hpwdt: Select WATCHDOG_CORE watchdog/hpwdt: Modify to use watchdog core. watchdog/hpwdt: Programable Pretimeout NMI watchdog/hpwdt: condition early return of NMI handler on iLO5 watchdog/hpwdt: remove allow_kdump module parameter. watchdog/hpwdt: Update driver version. drivers/watchdog/Kconfig | 1 + drivers/watchdog/hpwdt.c | 845 ++++++++--------------------------------------- 2 files changed, 134 insertions(+), 712 deletions(-) -- 2.13.6