Received: by 10.223.185.116 with SMTP id b49csp1055057wrg; Fri, 16 Feb 2018 11:35:20 -0800 (PST) X-Google-Smtp-Source: AH8x224YgSHuBO1BQ/ttCiFlEIgKiu7haMrlR0VrfNRnZKK3hGoP4rlndjntGA2JpI/27Pv3Urw7 X-Received: by 2002:a17:902:aa46:: with SMTP id c6-v6mr6813919plr.357.1518809720050; Fri, 16 Feb 2018 11:35:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518809720; cv=none; d=google.com; s=arc-20160816; b=I75HqGSdv1lGwZ+BnxbUSMgkN1qKw8g0MVmx+DTSoR4ca3RpckjtDcSZ60Sbe8ayHP ZavElQYgp2i5MC6AT5Hbm5h5bctDFCVge0kxjQboRsCheQIdMBL9cHpbQ5ei2vL8Qaxp mvR7XdAbHueh+h0sTPUO5VfBAtRXjf4/8owi9sJ9eMTLG/ReLNy8FFHJU8RtkzPZFOm+ rBy93X4cxs1IB/BJH42kW/cCczo4kpsLRHgFCJAcy4lS/zYXgl6z5gZLMUZ9vs+mJJtH MpKnP8VQCcLhiKMJDlebnJr2AjdyXEd3g5csytdwcO9Re0dsm3em6Z8GDoEL4lk1us7r PuPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=Pjs4odt2TuOvcKGyiUqrCXnSR7rrBJVau5W5FGrqpKs=; b=1ESkSnDLj2AUYhpqVAJNGLGnss4Itsgubx7vkyFERxaKr+NKTcBx8UDwJikrbp6gMf bfBzgsbXvh9Z29La39BlblPx04LOCXkYy4PppyCvVfBCFO/yYDfGKbYd+Wx1GZ7rkdKC EGfzoCHIo0sk2hbZbb6ZgtR2zUh++uF1eHk0iFeFslK7cdDv49L84iR5duhTlByDaSrq GB72Ude/wSL8os8uvLdV08rM+EEd6lAxZVp5oxQtO++rVva4Ll923rwTnIIy53tNzqF2 RIVjYy0XwGwzF7f3/kn0n4iVumBI2GGqc+VwGQx1wwYocLmYd2U8g3+sXImGrXtZQ14k o9qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=njfbCQ0j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si1803559pln.468.2018.02.16.11.35.06; Fri, 16 Feb 2018 11:35:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=njfbCQ0j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755210AbeBPIvH (ORCPT + 99 others); Fri, 16 Feb 2018 03:51:07 -0500 Received: from mail-oi0-f54.google.com ([209.85.218.54]:35805 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755126AbeBPIvF (ORCPT ); Fri, 16 Feb 2018 03:51:05 -0500 Received: by mail-oi0-f54.google.com with SMTP id y4so1640454oix.2; Fri, 16 Feb 2018 00:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Pjs4odt2TuOvcKGyiUqrCXnSR7rrBJVau5W5FGrqpKs=; b=njfbCQ0jlerjn6Admaa8aWennGNfmPmlX/J2Jc4j0uOMNS4+/Bq4nT3h+njIOxNnIr D7fJ/anerj0Gbu4qA3seAY6QHdRWkyXQIuRN9aDUsoApn9Jy3d0lTxH7Y2kECP9kRshM +Q/YLclAJk54g+Wr9zthxl+XN+d6a9FvIEcNQNDpAwQ0f8GH1+tIiKFqFSF5xfqrCDVO 6iV5ueqqv1lbneJmx05QY1Nb1AlVEq/BczDFw5v7gLWN4YnebF3XCSo0uSroTh5Ds2qh dwGFq2mawQm7g48WsJe680JbaiP1U9ziFsFX/1DINCWC+8OVRN06CHW2NJfG5F2L/YgN si8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Pjs4odt2TuOvcKGyiUqrCXnSR7rrBJVau5W5FGrqpKs=; b=tjWhyR9GcogViqG+hwhq25VhRfKsH5SCcwpadt1AYbqiIpsGDggTEfmPSMvB64D3Qh G/EpUYPkEqcJfgWXAcTmmeQfJQFHZNvhmVaTbeTVKRW2hfIa6SEUmmez+0bCBCpHDO/I RWr2s6oOd96C6Jvdc+KZ3e+2RZZMxYC7W9kL8OjFS/YKjPBkVBa2L4ilaRVodhhmGXK6 Le5iQzzKsUUVE2YsZOscPvPwdNbJNB/eKsyg7xAmQlvqFTSX1YDlEWG9F45NNkrX5UsG EBmo3QwmagV8kD7+Tyw+nZq7B+SzDmoMypRCJsh8dBgIX/tOFqgTlCaO3lXfmDVnBWwl UyVw== X-Gm-Message-State: APf1xPCdQ4tukt8M16MD4SM33ohqL9VwpZTAjQMLiijnY/+UqWTOWQB4 O6QqkfV8k2Z3wEYGpAscja0GN1YielAcTBhpw7A= X-Received: by 10.202.98.139 with SMTP id w133mr3564712oib.282.1518771064662; Fri, 16 Feb 2018 00:51:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.44.146 with HTTP; Fri, 16 Feb 2018 00:51:04 -0800 (PST) In-Reply-To: References: <20180216082616.25084-1-carlo@caione.org> From: "Rafael J. Wysocki" Date: Fri, 16 Feb 2018 09:51:04 +0100 X-Google-Sender-Auth: jP128vBLXyuNThDCQcIksURpms0 Message-ID: Subject: Re: [PATCH v2 0/3] power: supply: Fix AXP288 fallback when not needed To: Hans de Goede Cc: Carlo Caione , Linux Upstreaming Team , "Rafael J. Wysocki" , Len Brown , Sebastian Reichel , Chen-Yu Tsai , ACPI Devel Maling List , Linux Kernel Mailing List , Linux PM , Carlo Caione Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 16, 2018 at 9:41 AM, Hans de Goede wrote: > Hi, > > On 16-02-18 09:26, Carlo Caione wrote: >> >> From: Carlo Caione >> >> With commits af3ec837 and dccfae6d a blacklist was introduced to avoid >> using the ACPI drivers for AC and battery when a native PMIC driver was >> already present. While this is in general a good idea (because of broken >> DSDT or proprietary and undocumented ACPI opregions for the ACPI >> AC/battery devices) we have come across at least one CherryTrail laptop >> (ECS EF20EA) shipping the AXP288 together with a separate FG controller >> (a MAX17047) instead of the one embedded in the AXP288. > > > Thank you for the new version. This looks good and surprisingly > clean / small given amounts of warts surrounding this all. > > The entire series is: > > Reviewed-by: Hans de Goede Well, to be honest, I very much prefer it when changes are made to one driver at a time.