Received: by 10.223.185.116 with SMTP id b49csp1914784wrg; Sat, 17 Feb 2018 08:03:33 -0800 (PST) X-Google-Smtp-Source: AH8x225oD+S3rxDPE+MLVDZovyF/e6/ojrqBEeFOc+BDczITm5GclSS5iMqAXpzmOP5yVxhyVPEh X-Received: by 2002:a17:902:6e01:: with SMTP id u1-v6mr9048991plk.12.1518883413021; Sat, 17 Feb 2018 08:03:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518883412; cv=none; d=google.com; s=arc-20160816; b=o7zXWSff1ylvk0/EL0dOAxYxTAAeCpaZGu9TLQh+59ztjFU3RMQIptLZ0FaQC1ZN20 dIoNerVlt4gVxpfN7lWgSf+ZPmS5WUrxgipcmTjxlFmcwQSmaw5/iQwIlWdgcFqXUxU2 OQ7FteG+jZRkgJwbOaG5/uGeek50dheZKN8WOAdUsbGnpoUcHIAXk5UBx3e8jkxI732U cuTPx1NoTY6qZBYmgFay6mcLEFAAJo2Sd0X7lcjxbChrn9fhv+G6W+iT/nY7jC0nZTgF 8WECF2WPUlrh1w71NyQxqT3wHLKKu7srgMZWovrmYSmVfzQ2AHTQJvnj/FreQwbW20Ca ZIig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=K1blLIxUz9SxPJqTVrekM4FhHWZva6Fed1P+VwB+aSs=; b=funbQznOTfe2j5ioZ8Z+sUdWUaKPy9iVwlmTRL3n2JyViW6teauwi6kZiSgrVMFlC7 vtdQA0SZyjyEJ9NYsyCI2vuHhE29UG2SeokpLl4y7v3jLP2nBqX8jYazaFiIpMYMLI24 PyT42NtlKLYwtm2jqOXCLvr9dgc7QT6niURsf14wGLeV+g3j1R3fU31e+ZZBSckWtSsX TfQ5t/vJNfXo+8b1yaABcgjav1JTo8Hc59BD2r0m9mv/Zr+cCZfuJiQZPO6f80dcQK/N hHxJli1DRXROLEQtx7hJATk4FUIhEx3znECAEbCCBQN5bgXloPRB6Y2RzWD0NUlWPaiu Yusw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=p5XlE9cn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bj1-v6si1373773plb.286.2018.02.17.08.03.01; Sat, 17 Feb 2018 08:03:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=p5XlE9cn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751106AbeBQPfs (ORCPT + 99 others); Sat, 17 Feb 2018 10:35:48 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37431 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbeBQPfr (ORCPT ); Sat, 17 Feb 2018 10:35:47 -0500 Received: by mail-wm0-f54.google.com with SMTP id v71so7957343wmv.2 for ; Sat, 17 Feb 2018 07:35:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=K1blLIxUz9SxPJqTVrekM4FhHWZva6Fed1P+VwB+aSs=; b=p5XlE9cngc+RKo95zbY+KSI+kDAw4+upfUHcYFdVG+TMzmYJw0ej+HsE/o9nxTCRBj r+ODHbjo1vFwBJu8QpmBszrOW5Bj0PP7KNWZtasoLeu5sWnMzWPTrXxl7+tn4mvg8dhF Hjr5VT+UKKK2Xi8h8EtVsxOLjPzi2l5rbMb9U8ibD7zlBFKGTwiwcaYtokPx6DdRA/45 1eu9fkgcLba8dwqXJU5lxV9nRzJwVDQTspNCl/+DKFIqv89PKaTeWhazEqZIyijmMS4o MNSfqCq5qZ53ot9toytBcFKDavbxRjORck1+SKheEHJkUroZa+D7W/QXMZL7wyRj9A/K VhyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=K1blLIxUz9SxPJqTVrekM4FhHWZva6Fed1P+VwB+aSs=; b=QytDzhG9sn/prxOSo6P7cyXk5Zt7XJ7rfqPmBse3M/v9ECWbk6DRN8jZ5Uwvpqd0Tb Dl3f5ipAUZgGnZSn78iSmu1vkapp+Ki5MTGa3qoRNRtMA/Vane6IysSAiJ9L+v8HZQ3Q bdrBe0hH/y/pXg4Nq40YPBS1J1tGqDTnxZ9JiLJ97LxdNYmMjYBMIuECE0WrVko+tNg0 RvG0pJiKaK+Ndc/hcvEKbmxJ1pBjqp02K506R0ogmf+UZpZQqQk6PyqL2zsvllY+Dsbr 1u0rkE3PHmTrozG/jgfzvxVK9UQUf4lGKDM7i+M/nz97y5FUbkWJ/lQeaaZv1Y/v3SzU HyIg== X-Gm-Message-State: APf1xPAsRWw1P7fqHLj4Xc5M2QeqtmCq2cZAZYQsjoAVq/D9BZY4muHn tFwNR6bdd/pRjXJBVq/mRGHn X-Received: by 10.28.69.65 with SMTP id s62mr7350327wma.78.1518881746291; Sat, 17 Feb 2018 07:35:46 -0800 (PST) Received: from avx2 (nat4-minsk-pool-46-53-177-92.telecom.by. [46.53.177.92]) by smtp.gmail.com with ESMTPSA id g127sm18024117wmf.5.2018.02.17.07.35.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Feb 2018 07:35:45 -0800 (PST) Date: Sat, 17 Feb 2018 18:35:43 +0300 From: Alexey Dobriyan To: Andy Shevchenko Cc: Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH 2/2] proc: use set_puts() at /proc/*/wchan Message-ID: <20180217153542.GA3040@avx2> References: <20180217072011.GB16074@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 17, 2018 at 04:06:42PM +0200, Andy Shevchenko wrote: > On Sat, Feb 17, 2018 at 9:20 AM, Alexey Dobriyan wrote: > > - seq_printf(m, "%s", symname); > > + seq_puts(m, symname); > > While this might have no security concerns, the pattern might be > brainlessly used by some janitors and there would have security > implications. Unless there is some kind of preprocessor which seamlessly converts one to another I'd continue converting.