Received: by 10.223.185.116 with SMTP id b49csp2159291wrg; Sat, 17 Feb 2018 13:46:24 -0800 (PST) X-Google-Smtp-Source: AH8x227ttDVB8WSRxgTcht5cdhtf9pU/k9V0ORUkmNppCh/3p2zkxnXhJxe5vWi2W3d/HdEs/oyK X-Received: by 2002:a17:902:2943:: with SMTP id g61-v6mr9820543plb.435.1518903984316; Sat, 17 Feb 2018 13:46:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518903984; cv=none; d=google.com; s=arc-20160816; b=0BfAXtnWtXvUXMNiRRxDZZoQQ957yxqZcRxqQZr6aiq8nbHT7hcrDkXJ85Ut01Zkzm oAfZts7KH8X/9+QtOHkkGBgEwBXE6bE+PEltBoZHyUl04BP1Bp/VAv5kEgV092ruyxp3 ZTr3J5VYk6wOi5gGY/6Gh28Re7A4bzmFahZSQAtnvqJEhbkhhqowVDL5Og/jIU4LwWhk vNR3UqIWd7G+MP/n6C0VNf1MMAMUB96OdADtA4TiYaxYigDesODmH4Pw8zmzlt7wGLxk OLCeBCbWJVMO2PjlqDgIZa+Dg7wiK7vuj1P3oST8btC0U8XKePKPINH/e+S+qOcCBRlE SFJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dmarc-filter:arc-authentication-results; bh=YMYhCVaumkFRT5X/iwaeBmDvyIk6otaVrTgykFqWekE=; b=cdbTEM94XEnM6c6iEFcIOlrjQYJ1+uhx6Gq/1XXX1tFHG4ILoTr/OW9kUaeLByBdDh nsHXz259jqDatr0MF+fAo/9mf4ytwQcBd9JnLTbiAF1L3n7huC8HoMmwh/H2nESa9yg3 j+4ShHkRLQjpx7i+qheoBAR1AZ9wZNWZopFTMdKFRlYd/JdIa2DnKS2ed3DqG+e505gX uGqMgJSu5WSauG8Hx5c/b8ihCRcwd8FCDLnKI5h7nIMSUctlwNXzFXUXM0I1VBYXQACx fpSsVTiNzSmxnSXTSuxzYON8GLUax/kPcQfq0OfNgn59p5coGIv7yUTSY7+LE6SbqC9P To/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2-v6si455269pli.524.2018.02.17.13.46.10; Sat, 17 Feb 2018 13:46:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751365AbeBQVBY (ORCPT + 99 others); Sat, 17 Feb 2018 16:01:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:51616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751230AbeBQVBW (ORCPT ); Sat, 17 Feb 2018 16:01:22 -0500 Received: from kernel.org (unknown [24.6.201.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B00E21726; Sat, 17 Feb 2018 21:01:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B00E21726 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shli@kernel.org Date: Sat, 17 Feb 2018 13:01:20 -0800 From: Shaohua Li To: SF Markus Elfring Cc: linux-raid@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] md-multipath: Use seq_putc() in multipath_status() Message-ID: <20180217210120.6wwgxiwcyewbubff@kernel.org> References: <566ABCD9.1060404@users.sourceforge.net> <4a31d7a7-f70c-12f7-202f-963bd8706066@users.sourceforge.net> <6e70a1a7-fd86-914e-84ab-bd5c7facb235@users.sourceforge.net> <0b59904d-1be7-7a76-9c32-3f7f9696ff2d@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b59904d-1be7-7a76-9c32-3f7f9696ff2d@users.sourceforge.net> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 13, 2018 at 09:55:08AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 13 Jan 2018 09:49:03 +0100 > > A single character (closing square bracket) should be put into a sequence. > Thus use the corresponding function "seq_putc". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring applied, thanks > --- > drivers/md/md-multipath.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/md-multipath.c b/drivers/md/md-multipath.c > index e40065bdbfc8..0a7e99d62c69 100644 > --- a/drivers/md/md-multipath.c > +++ b/drivers/md/md-multipath.c > @@ -157,7 +157,7 @@ static void multipath_status(struct seq_file *seq, struct mddev *mddev) > seq_printf (seq, "%s", rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_"); > } > rcu_read_unlock(); > - seq_printf (seq, "]"); > + seq_putc(seq, ']'); > } > > static int multipath_congested(struct mddev *mddev, int bits) > -- > 2.15.1 >