Received: by 10.223.185.116 with SMTP id b49csp2733751wrg; Sun, 18 Feb 2018 05:35:13 -0800 (PST) X-Google-Smtp-Source: AH8x227mvG6i2XcUstUsqLy2EsbROY8WLJ1v+ekEq3eQu7BeCA415b0yBq8RErKtEw1VEHr2/Jk+ X-Received: by 2002:a17:902:6a89:: with SMTP id n9-v6mr11272598plk.212.1518960913543; Sun, 18 Feb 2018 05:35:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518960913; cv=none; d=google.com; s=arc-20160816; b=lrbAJWMbMeswZEaivBawZJlzl+Qr19uO9re3rWhASmf/nuK7PMFittXApBExaAAjFw mqLoYMo/Qa/IYjJ/h24EdM93aUWMKaym2JtbL+kAPzYPR528/CjeufaaiGH/2lyH0zKF 4fkNCPfEkB1+0MAeOcc9uXyTENG2jFghFl3QNEmjGlTESJch016WrkrMUptmLWI+A5Hg FTx80GHKVRWmWTGdFoZLe6Oh4RwxxjWWeAI9zBCDf2p8FlgmXSWXYvzPMrg9i3NWT+XZ TGhqTAfXWze7WyZmdGqJUi9hvf3G+heszuDUu3/XPsxDTWYaZPLbwgjfB4d9ihKKkc24 03yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=FW0Ad7bZrlNVPl6JC0+l3nUnkdnf+7L5OtYuPydOoHk=; b=oHR6aMOS0YBpYHxLETw/KuC6MAhI97Kugh6IEl/xU4JVxuji6lE1KRoCwEFCAaMk5w 08JNoCnnwRyXmEKSAiS38er6qjQr1PjulUfTGH9lGNGsC4CDu+Zpx4+m07G6OX1aN2if TfNW+8ZV/WEQbW7aXv5tGrZpob1DqmSeBEq0yZ0lABBcNnx0fBSh9+hRCcwgEzoX03+a 2Ajbv3U0MOz+ygRvA2WpfKO5IYUc7RLOgKoBqZwQejhi8iCvI1u3Jh/pt4f++H+SCwfY 3mkJNyYcVozRoo/QraHRr3A6cD6kQAw2BC7dDOZQ/K4cmOZbt1bmrc0hf3ZYn9ln/OR6 f4tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ou0tOTvt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w22-v6si2697632plq.605.2018.02.18.05.34.57; Sun, 18 Feb 2018 05:35:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ou0tOTvt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751457AbeBRNSj (ORCPT + 99 others); Sun, 18 Feb 2018 08:18:39 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:38188 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbeBRNSg (ORCPT ); Sun, 18 Feb 2018 08:18:36 -0500 Received: by mail-qk0-f195.google.com with SMTP id s198so9282532qke.5; Sun, 18 Feb 2018 05:18:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FW0Ad7bZrlNVPl6JC0+l3nUnkdnf+7L5OtYuPydOoHk=; b=ou0tOTvt2VMBNWgu+zb0dmJkzYclDz9pUHCJw8ImRrpiDl+a8/4dLepYmBCqW+n/sy oWFqdQPlZQwHtMYl30T3DkeS5gg0tK0kR99pcihg4Aw+jm8UX1hs74I3sMBH+un++oie WfcEMVDQkVRCIqs1Rtt65Tn6+cuc4pwVLGpU0MkK0wG8tgGIbYiS1ZG/flI7Mzp5lG4v nCoEarvVwvBAZplJLXa4IS0+Z2v4AzIYO1y//+rJxX71zp4IOesZoHK4RJZAoLFNyp18 9ZlM9atLWjAuzZ4HIDje1t8ez7JyORjF+uWc3JHLc+oXhzlZX8LtBSofuchvOkwx29MH LXMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=FW0Ad7bZrlNVPl6JC0+l3nUnkdnf+7L5OtYuPydOoHk=; b=QdMI3K0VgT83PZEbFQ95W9rQ15DUMZkfH3CW5uV9PJHmhQs/7UCp3SrqgGJp6tho+e /LCJH6xy/z/odMaDeDadsDPGochbsOmrRBj+I7oP+Fjrz3NPardyu7iN4z3l3vop7sKb m1xPoe35IHcK5bLoapqSLyuRI6gBfDGY9pu8Q8fPoNu5OKmb6xITDLXXuBRSeR1pVEOJ X2H3MMdKfUs8LDPSWdgq7L568eGUx8xgFXskm933uYiCfMHaeSYVq4UTE2mWT1if8Txn C4rrTz2yTz2t/On8SxlfAwVURN9ng3jWi1dPMCJyrHiY6W0oxgsEjxqoukGtguGtYm6z P/MQ== X-Gm-Message-State: APf1xPD1h6c6RCeVRDWClQVbEp/2xHnvC9WtX3v20bH8Bha4QynDIZAu BTVIUNmKp2fdeT5K9mTMA3I= X-Received: by 10.55.105.6 with SMTP id e6mr2404424qkc.192.1518959916023; Sun, 18 Feb 2018 05:18:36 -0800 (PST) Received: from localhost (dhcp-ec-8-6b-ed-7a-cf.cpe.echoes.net. [72.28.5.223]) by smtp.gmail.com with ESMTPSA id w201sm7791283qkb.52.2018.02.18.05.18.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Feb 2018 05:18:35 -0800 (PST) Date: Sun, 18 Feb 2018 05:18:32 -0800 From: Tejun Heo To: SF Markus Elfring Cc: linux-ide@vger.kernel.org, Bartlomiej Zolnierkiewicz , Viresh Kumar , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3] pata_arasan_cf: Move two variable assignments in arasan_cf_probe() Message-ID: <20180218131832.GA695913@devbig577.frc2.facebook.com> References: <0f5492bc-d239-401e-6f77-a27897e4ede5@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f5492bc-d239-401e-6f77-a27897e4ede5@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 16, 2018 at 05:00:11PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 16 Feb 2018 16:42:26 +0100 > > Move assignments for the local variables "irq_handler" and "pdata" > so that their setting will only be performed after a call > of the function "devm_kzalloc" succeeded by this function. > Thus adjust a corresponding if statement. I'm not gonna apply this. If there's something preventing the compiler from optimizing it, the right thing to do is fixing that. Thanks. -- tejun