Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 18 Feb 2018 15:20:22 -0800 (PST)
From:   David Rientjes <rientjes@google.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
cc:     mingo@kernel.org, jpoimboe@redhat.com, keescook@chromium.org,
        akpm@linux-foundation.org, tglx@linutronix.de,
        geert@linux-m68k.org, gregkh@linuxfoundation.org,
        thomas.lendacky@amd.com, will.deacon@arm.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Support the nonstring variable attribute (gcc >= 8)
In-Reply-To: <20180217191035.gol4woxsgzpo4bfq@gmail.com>
Message-ID: <alpine.DEB.2.10.1802181519400.205822@chino.kir.corp.google.com>
References: <20180217191035.gol4woxsgzpo4bfq@gmail.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 17 Feb 2018, Miguel Ojeda wrote:

> From the GCC manual:
> 
> The nonstring variable attribute specifies that an object or member
> declaration with type array of char or pointer to char is intended to
> store character arrays that do not necessarily contain a terminating NUL
> character. This is useful in detecting uses of such arrays or pointers
> with functions that expect NUL-terminated strings, and to avoid warnings
> when such an array or pointer is used as an argument to a bounded string
> manipulation function such as strncpy.
> 
>   https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html
> 
> Some reports are already coming to the LKML regarding these
> warnings. When they are false positives, we can use __nonstring to let
> gcc know a NUL character is not required; like in this case:
> 
>   https://lkml.org/lkml/2018/1/16/135
> 
> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: David Rientjes <rientjes@google.com>

I would have expected to have seen __nonstring used somewhere as part of 
this patch.