Received: by 10.223.185.116 with SMTP id b49csp3539491wrg; Mon, 19 Feb 2018 01:35:39 -0800 (PST) X-Google-Smtp-Source: AH8x2258rXtOzOOZVW+teV3nT3tS5hB4/DdJ6Yz/aBbK8EA1ZpGeRDCVUu0qxd3rvp+AcWzai8/U X-Received: by 10.99.7.15 with SMTP id 15mr11451185pgh.388.1519032939120; Mon, 19 Feb 2018 01:35:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519032939; cv=none; d=google.com; s=arc-20160816; b=nn59xGNK8T1cSNaY/L/vglv9gtdw7Vson3H0vJRiBhvFbdTxENOmNQFr0rvp6Z3r0z DtnC1qZzakrv3XxVJfBju46t0FCkvPkBBVKZvpnzQnavRKu7q8MA92MY0C6nsLzYIX2Q kgjJg7GOCIJohhrbNmJozrQpEc7ogOyHgurz+4vghTGkPgbudPMRDFfmvdCO+wVRANRx 5VovAX2PYZIQs8PvUNIPuHxxXJue7Lnvp0f7EjRV/Xlpf7/V2ibsobpwqjKTKtpXiF1W VgzY4NWt2Ou9zoj4U0DsJyh+c8SB/4XbF/7wqUw0yTcOurvecUq4xmQtQ/9hdGNCGY6r CVbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :organization:in-reply-to:subject:cc:to:from :arc-authentication-results; bh=gXf4WCKTzKHpnaaN53j7XcdPFHpftY3YVRusT8DeUu0=; b=wgML185xMd+Z4uif4fFgVW1+eNC0WlPJYJbkUEccw0Aia0Oj4nLwgladW2qiAVDpaV xWF0H3SXkOn/HLISqSTYjGqUms9iwqSlN7Ot0Ru4SE9r4Y1CrioBRCkMyMZESvRc67M+ 5vbGcnK31jT4wZj+OmLsN+tb0s7TXu2XRbqfbZ06sVmhZ2ufwdNJlfOqgIcLu65hpRo7 GqAZhkTFVs1fjQOEsAMFU+fC5zBJdRwqOwZFJ5jiuqPB5S5wVjM8DRMwoNIpnc3R+fxk bSazQ1l7wDFMk6l8X9fHrMpOmcT0LQp24moriTNM92ugDVzHrTHsNBrTwkOaulby0yRQ 1Oeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j19-v6si4258040pll.458.2018.02.19.01.35.25; Mon, 19 Feb 2018 01:35:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752431AbeBSJeo (ORCPT + 99 others); Mon, 19 Feb 2018 04:34:44 -0500 Received: from mga02.intel.com ([134.134.136.20]:57343 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbeBSJel (ORCPT ); Mon, 19 Feb 2018 04:34:41 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2018 01:34:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,534,1511856000"; d="scan'208";a="31882159" Received: from tkahrman-mobl.ger.corp.intel.com (HELO localhost) ([10.252.33.108]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2018 01:34:35 -0800 From: Jani Nikula To: Bjorn Helgaas , Sinan Kaya Cc: linux-pci@vger.kernel.org, timur@codeaurora.org, David Airlie , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Joonas Lahtinen , open list , "open list\:DRM DRIVERS" , Rodrigo Vivi , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3 09/29] drm/i915: deprecate pci_get_bus_and_slot() In-Reply-To: <20180216145444.GA11014@bhelgaas-glaptop.roam.corp.google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1511801886-6753-1-git-send-email-okaya@codeaurora.org> <1511801886-6753-10-git-send-email-okaya@codeaurora.org> <20180216145444.GA11014@bhelgaas-glaptop.roam.corp.google.com> Date: Mon, 19 Feb 2018 11:34:34 +0200 Message-ID: <87bmglb9w5.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Feb 2018, Bjorn Helgaas wrote: > On Mon, Nov 27, 2017 at 11:57:46AM -0500, Sinan Kaya wrote: >> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as >> where a PCI device is present. This restricts the device drivers to be >> reused for other domain numbers. >> >> Getting ready to remove pci_get_bus_and_slot() function in favor of >> pci_get_domain_bus_and_slot(). >> >> Extract the domain number from drm_device and pass it into >> pci_get_domain_bus_and_slot() function. >> >> Signed-off-by: Sinan Kaya > > I don't know what happened to this, and it didn't make it into > v4.16-rc1. I applied it to pci/deprecate-get-bus-and-slot for v4.17 > along with the patch that actually removes pci_get_bus_and_slot(). It fell between the cracks as we couldn't apply it before getting a backmerge on the dependency. Sorry about that. Ack for merging through your tree. Thanks, Jani. > >> --- >> drivers/gpu/drm/i915/i915_drv.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c >> index 9f45cfe..5a8cb79 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.c >> +++ b/drivers/gpu/drm/i915/i915_drv.c >> @@ -419,7 +419,10 @@ static int i915_getparam(struct drm_device *dev, void *data, >> >> static int i915_get_bridge_dev(struct drm_i915_private *dev_priv) >> { >> - dev_priv->bridge_dev = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0)); >> + int domain = pci_domain_nr(dev_priv->drm.pdev->bus); >> + >> + dev_priv->bridge_dev = >> + pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0)); >> if (!dev_priv->bridge_dev) { >> DRM_ERROR("bridge device not found\n"); >> return -1; >> -- >> 1.9.1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Jani Nikula, Intel Open Source Technology Center