Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V2] lib/scatterlist: Add SG_CHAIN and SG_END macros for
 LSB encodings
To:     Anshuman Khandual <khandual@linux.vnet.ibm.com>,
        kbuild test robot <lkp@intel.com>
Cc:     kbuild-all@01.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, bart.vanassche@wdc.com,
        jthumshirn@suse.de, axboe@kernel.dk, chris@chris-wilson.co.uk,
        tvrtko.ursulin@intel.com
References: <20180215033356.6978-1-khandual@linux.vnet.ibm.com>
 <201802180359.yuetSevh%fengguang.wu@intel.com>
 <c407c32f-a7b6-06c5-4a03-109445e27427@linux.vnet.ibm.com>
From:   Tvrtko Ursulin <tursulin@ursulin.net>
Message-ID: <8eacaf1d-1df8-edc6-36f6-d02748b50baa@ursulin.net>
Date:   Mon, 19 Feb 2018 10:10:23 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <c407c32f-a7b6-06c5-4a03-109445e27427@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 19/02/18 04:12, Anshuman Khandual wrote:
> On 02/18/2018 12:58 AM, kbuild test robot wrote:
>> Hi Anshuman,
>>
>> Thank you for the patch! Perhaps something to improve:
>>
>> [auto build test WARNING on linus/master]
>> [also build test WARNING on v4.16-rc1 next-20180216]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>
>> url:    https://github.com/0day-ci/linux/commits/Anshuman-Khandual/lib-scatterlist-Add-SG_CHAIN-and-SG_END-macros-for-LSB-encodings/20180218-015554
>> config: x86_64-randconfig-s3-02180201 (attached as .config)
>> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
>> reproduce:
>>          # save the attached .config to linux build tree
>>          make ARCH=x86_64
>>
>> All warnings (new ones prefixed by >>):
>>
>>     In file included from drivers/staging/rts5208/rtsx.h:180:0,
>>                      from drivers/staging/rts5208/rtsx.c:28:
>>>> drivers/staging/rts5208/rtsx_chip.h:343:0: warning: "SG_END" redefined
>>      #define SG_END   0x02
>>      
>>     In file included from include/linux/blkdev.h:28:0,
>>                      from drivers/staging/rts5208/rtsx.c:23:
>>     include/linux/scatterlist.h:69:0: note: this is the location of the previous definition
>>      #define SG_END  0x02UL
>>      
>>
>> vim +/SG_END +343 drivers/staging/rts5208/rtsx_chip.h
> 
> SG_END is already defined in a driver. Hence shall we change back
> 'SG_END' definition as 'SG_EMARK' or any other suggestions ?

Maybe SG_LAST? Going by existence of sg_is_chain and sg_is_last.

And also would probably be good to add something like:

#define SG_PAGE_BITS (SG_CHAIN | SG_LAST)
#define SG_PAGE_MASK (~SG_PAGE_BITS)

?

Regards,

Tvrtko