Received: by 10.223.185.116 with SMTP id b49csp3580892wrg; Mon, 19 Feb 2018 02:27:32 -0800 (PST) X-Google-Smtp-Source: AH8x225fEm8Cs2OMpWGaO90cG7bHoXao7mvXXbd3Knho33irqqq/U3Iq3yt2gl75vlndcIVOMdLl X-Received: by 10.98.144.213 with SMTP id q82mr14272206pfk.37.1519036052292; Mon, 19 Feb 2018 02:27:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519036052; cv=none; d=google.com; s=arc-20160816; b=0eeE7KnIX0VWgC45uavDL884zTr4pRCe7f98cvEzpPSvS2XZQu7ADpjQn2owgsV+6C 2/MuIN2IcSQlZjzhMkd06G2aFKiJqjrRh23iNl4zPXeXKAbAaUlsvbWIqkR7wmEcUMBL dPQG3M5pbeNhpJTDWFzUZLLAk96FtrTuyaumqX+mKKzkN2Xr/4OGlll91yI7JdiDyvOJ ov4N7izT1OZSSrtpZI0RjM33Sewlw3DOSd+ZHe5+AWM9q7mpYYULuzkRiyY0OFpAWcba 33iPtBLlgRG1Yq38nSPFOtl4G4eEtHarV8NAcS3dzv5Fk8NACaNTc5hl5yW2bSQHXwyy B0vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=ZC7fUza3vfoNJIL4VONRDvip55gRrMfPbX1bJXkV8zw=; b=GtGdz6LPje0bUeJjnVZANoJN9akcWj9Udc5CaGwpRcjxRQPCHrI/+5cVfl+oMZO6Af q4/LVoUkWcp9GYI4yBKbSQjC1TIY+peIaDK+3oH4Vf3JeGzWsyu2TGnEZqh29seHMlIf YIoG46V0MKPiqjUF8r+WWYahvvgAsN9APloypkAmPdQMOnfVXzBZsDlpfjegfLQ+WNRV E1bqNL1W+4k6pnToS1twud2UgUTVRffqC7t/MuXpRvNePQ4bUEatGMbqtXTv1d3SRnTf lsBxJQdeMhvrIM8elX8JlkPh/4mGNLvs2VX2/jALYuG8sioo2JN75UGvoHx7YTTTeT6Y n8LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=YoihTEve; dkim=pass header.i=@codeaurora.org header.s=default header.b=EyTA4uFp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u128si5064395pgc.587.2018.02.19.02.27.17; Mon, 19 Feb 2018 02:27:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=YoihTEve; dkim=pass header.i=@codeaurora.org header.s=default header.b=EyTA4uFp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbeBSK0l (ORCPT + 99 others); Mon, 19 Feb 2018 05:26:41 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36388 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275AbeBSK0j (ORCPT ); Mon, 19 Feb 2018 05:26:39 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 48C9260117; Mon, 19 Feb 2018 10:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519035999; bh=RktRMVUvh/FMkGSGqmC0vGLNF9/2l961DkcbPCHk5Zc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YoihTEve7iczhC0Emw2gpJKWSOY0US9AI2uGwbh98DOP1X3pbJ9NeoDkAH5vi53JA 79jBpH6vcSvpap94HGCfr1nnTLk6OFthXcVQKJT6ZUysNf+5lCKu/0/zXpAvPj0Msl w444KAUnE9B/Ty73t0b8gr0V4mOj2cCyeFb753/o= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id A2D4160117; Mon, 19 Feb 2018 10:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519035998; bh=RktRMVUvh/FMkGSGqmC0vGLNF9/2l961DkcbPCHk5Zc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EyTA4uFpC78tVLnwCqGoARmX9bqar2Tyw+BUfJ0qYfw/qmSxoKsbyzg9IHcAPOMEF v2QBa8Ry4cD7gTg0TLn/Ffgx3HHBBgO1Pg7SIjH6XcG6RP8J9wLlb5UpgZs8bmokTb 2Wn4I5hGAM5XoIXsvXP8Cr/OTWtG0qNnIURZCMms= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 19 Feb 2018 15:56:38 +0530 From: Abhishek Sahu To: Sricharan R Cc: Andy Gross , Wolfram Sang , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/12] i2c: qup: remove redundant variables for BAM SG count In-Reply-To: References: <1517644697-30806-1-git-send-email-absahu@codeaurora.org> <1517644697-30806-4-git-send-email-absahu@codeaurora.org> Message-ID: <796cbb857fe16266403d286e8047698a@codeaurora.org> X-Sender: absahu@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-02-09 07:46, Sricharan R wrote: > Hi Abhishek, > > On 2/3/2018 1:28 PM, Abhishek Sahu wrote: >> The rx_nents and tx_nents are redundant. rx_buf and tx_buf can >> be used for total number of SG entries. >> >> Signed-off-by: Abhishek Sahu >> --- >> drivers/i2c/busses/i2c-qup.c | 26 ++++++++++---------------- >> 1 file changed, 10 insertions(+), 16 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-qup.c >> b/drivers/i2c/busses/i2c-qup.c >> index c68f433..bb83a2967 100644 >> --- a/drivers/i2c/busses/i2c-qup.c >> +++ b/drivers/i2c/busses/i2c-qup.c >> @@ -692,7 +692,7 @@ static int qup_i2c_bam_do_xfer(struct qup_i2c_dev >> *qup, struct i2c_msg *msg, >> struct dma_async_tx_descriptor *txd, *rxd = NULL; >> int ret = 0, idx = 0, limit = QUP_READ_LIMIT; >> dma_cookie_t cookie_rx, cookie_tx; >> - u32 rx_nents = 0, tx_nents = 0, len, blocks, rem; >> + u32 len, blocks, rem; >> u32 i, tlen, tx_len, tx_buf = 0, rx_buf = 0, off = 0; >> u8 *tags; >> > > This is correct. Just a nit, may be rx/tx_buf can be changed to > rx/tx_count to make it more clear. > Yes, rx/tx_count will be more meaningful. rx/tx_buf gives the impression that it is uchar buffer. I will change that. Thanks, Abhishek